Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't type ENS name in "New chat" screen (when start typing "0X04" appears) #9046

Closed
churik opened this issue Sep 25, 2019 · 6 comments · Fixed by #9075
Closed

Can't type ENS name in "New chat" screen (when start typing "0X04" appears) #9046

churik opened this issue Sep 25, 2019 · 6 comments · Fixed by #9075

Comments

@churik
Copy link
Member

churik commented Sep 25, 2019

Description

Type: Bug
Summary: when start to type ENS name, can't finish because "0X04" appears on the start of the string, and it is not possible to delete it.
Also when you paste valid ENS - it is replaced by public key

Expected behavior

can type ENS

Actual behavior

0X04 appears
lop

Reproduction

  • Open Status
  • Tap on + > Start new chat
  • Start typing ENS name

Additional Information

  • Status version: nightly 25/09/2019
  • Operating System: Android, iOS
@churik
Copy link
Member Author

churik commented Sep 26, 2019

Was introduced on nightly 11/09/2019

@yenda
Copy link
Contributor

yenda commented Sep 26, 2019

@siphiuel could it be b215292 ?

@vitvly
Copy link
Contributor

vitvly commented Sep 26, 2019

@yenda hm, could be, have to investigate where this 0x04 comes from

@yenda
Copy link
Contributor

yenda commented Sep 26, 2019

It comes from status-im.ethereum.ens uncompressed public key

@yenda
Copy link
Contributor

yenda commented Sep 26, 2019

;; Set default-value as otherwise it will
                          ;; be erased in global `onWillBlur` handler
                          :default-value       new-identity

in new_chat.views, the problem is that new-identity should not be the default value if there is an error

@vitvly vitvly self-assigned this Sep 26, 2019
@vitvly
Copy link
Contributor

vitvly commented Sep 26, 2019

Will fix this, introduced in my PR, thanks @yenda for the hint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants