fix #8992 update account timestamp when login with keycard #9014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (17)
|
dmitryn
approved these changes
Sep 20, 2019
|
@yenda thanks for fixing this 👍 PR's merge target branch is |
yenda
force-pushed
the
fix/9003
branch
2 times, most recently
from
91ec199
to
8ccc858
Compare
|
Tested https://status-im-prs.ams3.digitaloceanspaces.com/StatusIm-190920-110949-70e0bc-pr.apk |
yenda
force-pushed
the
fix/8992
branch
2 times, most recently
from
7140879
to
8c546f6
Compare
Logout from keycard account was redirecting to login screen for another user because `b.multiaccountsDB.UpdateAccountTimestamp` was not called in `startNodeWithKey` as it was done in `startNodeWithAccount` in status-go The fix is therefore in status-go and this PR updates status-go version to fix that Signed-off-by: yenda <eric@status.im>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8992
Summary
Logout from keycard account was redirecting to login screen for another user
because
b.multiaccountsDB.UpdateAccountTimestampwas not called instartNodeWithKeyas it was done instartNodeWithAccountin status-goThe fix is therefore in status-go and this PR updates status-go version to
fix that
Testing notes
Tested on Android, created normal account logout then keycard account logout login screen is on keycard account as expected
status: ready