Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide 'export account' option for v1 #9040

Closed
rachelhamlin opened this issue Sep 25, 2019 · 2 comments · Fixed by #9041
Closed

Hide 'export account' option for v1 #9040

rachelhamlin opened this issue Sep 25, 2019 · 2 comments · Fixed by #9041

Comments

@rachelhamlin
Copy link
Contributor

rachelhamlin commented Sep 25, 2019 •
edited by StatusWrike
Loading

Problem

The Export account menu option needs to be hidden from the individual account settings menu for v1, as the feature will not be introduced until later:

Acceptance Criteria

When you click into an account within the account explorer and tap the '...' toolbar, you should see only the Account settings option (currently inactive, but should be implemented in #8446).
@pedropombeiro pedropombeiro self-assigned this Sep 25, 2019
pedropombeiro pushed a commit that referenced this issue Sep 25, 2019
Hide Account Export menu item in wallet for v1. Closes #9040
a777279
@pedropombeiro pedropombeiro mentioned this issue Sep 25, 2019
Merged
pedropombeiro pushed a commit that referenced this issue Sep 25, 2019
Hide Account Export menu item in wallet for v1. Closes #9040
6d6d4be
@yenda
Copy link
Contributor

yenda commented Sep 26, 2019

@rachelhamlin what was that option suppose to do exactly?

@rachelhamlin
Copy link
Contributor Author

rachelhamlin commented Sep 26, 2019 •
edited
Loading

@yenda pretty sure it's for this keystore flow: https://www.figma.com/file/XUehMnhyD1FGcWzvGz6SXqvh/Mobile-wallet?node-id=3294%3A31930 (I wasn't part of that design review)

pedropombeiro pushed a commit that referenced this issue Sep 27, 2019
Hide Account Export menu item in wallet for v1. Closes #9040
cf04e0c
pedropombeiro pushed a commit that referenced this issue Sep 27, 2019
fixup! Hide Account Export menu item in wallet for v1. Closes #9040
b3bdfa1
@yenda yenda closed this as completed in f8d447f Sep 28, 2019
@weekly-digest weekly-digest bot mentioned this issue Sep 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hide Account Export menu item in wallet for v1 status-im/status-mobile
3 participants
@pedropombeiro @yenda @rachelhamlin