Add referral share link ui #10620
Merged
Add referral share link ui #10620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (122)
|
Ferossgp
force-pushed
the
feature/referral-share-ui
branch
from
6b30a72
to
5127709
Compare
|
@Ferossgp thanks for your patience! What feedback are you helped with most?
|
|
@hesterbruikman waiting for the contract to be deployed, then I will add usage everywhere. |
|
@hesterbruikman normally if it doesn't fit we run the text into a second line |
Ferossgp
force-pushed
the
feature/referral-share-ui
branch
2 times, most recently
from
67365b1
to
58dcb55
Compare
Ferossgp
force-pushed
the
feature/referral-share-ui
branch
from
58dcb55
to
bf4ef8d
Compare
Ferossgp
force-pushed
the
feature/referral-share-ui
branch
from
bf4ef8d
to
c1f29f2
Compare
Ferossgp
force-pushed
the
feature/referral-share-ui
branch
2 times, most recently
from
01e2bcb
to
73b7636
Compare
|
Small request - could you please rebase to latest master so this commit b5fda12 gets included? This means we aren't running E2E tests on eth.prod cluster anymore, and since this happens on every push, the impact is quite big. This ensures we have more accurate metrics going forward from Jul 1 onward, which would be awesome. See https://discuss.status.im/t/user-growth-and-retention/1782 for more |
Ferossgp
force-pushed
the
feature/referral-share-ui
branch
from
73b7636
to
b20533c
Compare
Ferossgp
force-pushed
the
feature/referral-share-ui
branch
4 times, most recently
from
2e4e85f
to
62eb750
Compare
Ferossgp
force-pushed
the
feature/referral-share-ui
branch
2 times, most recently
from
11c2ae6
to
bcf0a7a
Compare
94% of end-end tests have passedFailed tests (6)Click to expand
Passed tests (92)Click to expand |
Ferossgp
force-pushed
the
feature/referral-share-ui
branch
2 times, most recently
from
3f7e0ed
to
0191451
Compare
andremedeiros
approved these changes
Jul 24, 2020
Ferossgp
force-pushed
the
feature/referral-share-ui
branch
from
da30c89
to
e3bddc1
Compare
|
As already discussed with @Ferossgp. These are my findings from testing cc @Serhy 1. Use advertiser referral link - Decline attributionSamsung Galaxy s10e
2. Use advertiser referral link - Accept attributionSamsung Galaxy s10e
3. Use a previously used referral linkSamsung Galaxy s10e
4. Invite friendsSamsung Galaxy s10e + Fairphone Android 7
5. Receive friend inviteNeed some more attempts to understand the logic of testing for this |
Ferossgp
force-pushed
the
feature/referral-share-ui
branch
from
e3bddc1
to
cb90bc4
Compare
cammellos
force-pushed
the
feature/referral-share-ui
branch
from
cb77d63
to
a91a3e6
Compare
99% of end-end tests have passedFailed tests (1)Click to expand
Passed tests (96)Click to expand
|
|
@hesterbruikman |
|
@churik this is expected, the UI is hidden only for release build by env var https://github.com/status-im/status-react/pull/10620/files#diff-95f82adffc4221e092a1ff1a67cef1c5R19 |
|
Apart from chenging invite link from general http://status.im to deeplink - no more regression is found |
Add acquisition backend methods Init referrals sharing UI Add invite on home screen Use i18n for strings Lint Update status go Pull acquisition contract to get SNT amount Use new invite component f pulling go Use screen instead of bottom sheet Handle android install referrer Post referrer to backend if present go go Add async storage for referral decisions Update with the stage backend Update contract methods Modal UI Full handling of advertiser type UI test UI Handle with universal link Allow multiple acquisition per installation Fix android bottom sheet Do not call service if no click-id received Disable invite in release Parse query params for referrer Adapt UI changes Add push notification update deps Mock react-native-push-notification Request push notifications permission on press accept Store transaction to local storage and load it back on login Separate acquisition into smaller ns Add chat invite Get referrer only on first install fix string Fix firebase crash Handle outdate click-id Cleanup business logic Update contract Revert pn Minor update to advertiser modal copy OLD - Welcome to Status! Here is some crypto to get you started NEW - Here’s some crypto to get you started! Use it to get stickers, an ENS name and try dapps OLD - By accepting you agree to the starter pack NEW - By accepting you agree to the referral program upgrade status-go Add mainnet Signed-off-by: Gheorghe Pinzaru <feross95@gmail.com>
Ferossgp
force-pushed
the
feature/referral-share-ui
branch
from
c310943
to
3c42360
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10346
Add loaders while waiting API responses