Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android tabbar replace elevation with border #10832

Merged
merged 1 commit into from
Dec 21, 2020
Merged

Android tabbar replace elevation with border #10832

merged 1 commit into from
Dec 21, 2020

Conversation

Ferossgp
Copy link
Contributor

@Ferossgp Ferossgp commented Jun 17, 2020 •
edited by StatusWrike
Loading

Fixes #10604

@Ferossgp Ferossgp requested a review from flexsurfer June 17, 2020 07:16
@Ferossgp Ferossgp requested a review from a team as a code owner June 17, 2020 07:16
@Ferossgp Ferossgp self-assigned this Jun 17, 2020
@status-im-auto
Copy link
Member

status-im-auto commented Jun 17, 2020 •
edited
Loading

Jenkins Builds

Click to see older builds (11)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ fb5c851 #1 2020-06-17 07:26:08 ~9 min android-e2e 📦apk 📲
✖️ fb5c851 #1 2020-06-17 07:28:53 ~12 min android 📦apk 📲
✖️ fb5c851 #1 2020-06-17 07:31:14 ~14 min ios 📦ipa 📲
✔️ f34759a #2 2020-06-17 07:51:51 ~9 min android-e2e 📦apk 📲
✔️ f34759a #2 2020-06-17 07:53:44 ~11 min android 📦apk 📲
✔️ f34759a #2 2020-06-17 07:57:03 ~14 min ios 📦ipa 📲
✔️ 1afa0c5 #3 2020-06-19 09:09:33 ~9 min android-e2e 📦apk 📲
✔️ 1afa0c5 #3 2020-06-19 09:11:43 ~11 min android 📦apk 📲
✔️ 1afa0c5 #3 2020-06-19 09:14:41 ~14 min ios 📦ipa 📲
❌ 1afa0c5 #1 2020-12-11 13:28:16 ~28 sec android-e2e 📄log
❌ 1afa0c5 #1 2020-12-11 13:28:17 ~24 sec android 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ acca83a #2 2020-12-11 13:47:50 ~11 min android-e2e 📦apk 📲
✔️ acca83a #2 2020-12-11 13:47:52 ~10 min android 📦apk 📲
✔️ acca83a #2 2020-12-11 13:51:26 ~14 min ios 📦ipa 📲
✔️ b007520 #3 2020-12-11 14:57:35 ~10 min android-e2e 📦apk 📲
✔️ b007520 #3 2020-12-11 14:57:41 ~11 min android 📦apk 📲
✔️ b007520 #3 2020-12-11 15:02:26 ~15 min ios 📦ipa 📲
✔️ b007520 #4 2020-12-18 11:45:11 ~15 min ios 📦ipa 📲

@Ferossgp Ferossgp force-pushed the feature/remove-android-elevation branch from fb5c851 to f34759a Compare June 17, 2020 07:42
@status-im-auto
Copy link
Member

97% of end-end tests have passed

Total executed tests: 95
Failed tests: 3
Passed tests: 92

Failed tests (3)

Click to expand
1. test_delete_chats_via_delete_button

Device 1: Wait for ChatElement
Device 1: Wait for ChatElement

Device 1: 'MultiAccountOnLoginButton' is not found on the screen; also Unexpected Alert is shown: 'java.lang.AssertionError: No System TLS'

Device sessions

2. test_connection_is_secure

Device 1: Tap on URLEditBoxLockIcon
Device 1: Looking for full text: 'Connection is secure. Make sure you really trust this site before signing transactions or entering personal data.'

Device 1: 'BaseElement' is not found on the screen

Device sessions

3. test_keycard_sign_message_from_daap

Device 1: =========================================================================
Device 1: Check logcat for sensitive data

Device 1: ['Password in logcat!!!']

Device sessions

Passed tests (92)

Click to expand
1. test_decline_transactions_in_1_1_chat
Device sessions

2. test_can_see_all_transactions_in_history
Device sessions

3. test_install_pack_and_send_sticker
Device sessions

4. test_login_with_new_account
Device sessions

5. test_timestamp_in_chats
Device sessions

6. test_password_in_logcat_sign_in
Device sessions

7. test_logcat_recovering_account
Device sessions

8. test_public_chat_clear_history
Device sessions

9. test_need_help_section
Device sessions

10. test_send_and_open_links
Device sessions

11. test_mobile_data_usage_popup_stop_syncing
Device sessions

12. test_mobile_data_usage_settings
Device sessions

13. test_create_new_group_chat
Device sessions

14. test_sign_typed_message (TestRail link is not found)
Device sessions

15. test_user_can_switch_network
Device sessions

16. test_mobile_data_usage_popup_continue_syncing
Device sessions

17. test_home_view
Device sessions

18. test_open_google_com_via_open_dapp
Device sessions

19. test_share_contact_code_and_wallet_address
Device sessions

20. test_add_to_contacts
Device sessions

21. test_add_account_to_multiaccount_instance_private_key
Device sessions

22. test_refresh_button_browsing_app_webview
Device sessions

23. test_keycard_send_two_transactions_one_after_another_in_dapp
Device sessions

24. test_can_add_existing_ens
Device sessions

25. test_transaction_wrong_password_wallet
Device sessions

26. test_public_chat_messaging
Device sessions

27. test_unread_messages_counter_public_chat
Device sessions

28. test_keycard_send_eth_from_wallet_to_address
Device sessions

29. test_keycard_fetching_balance_after_offline
Device sessions

30. test_keycard_send_transaction_from_daap
Device sessions

31. test_text_message_1_1_chat
Device sessions

32. test_can_use_purchased_stickers_on_recovered_account
Device sessions

33. test_open_transaction_on_etherscan
Device sessions

34. test_onboarding_screen_when_requesting_tokens_for_recovered_account
Device sessions

35. test_contact_profile_view
Device sessions

36. test_offline_add_new_group_chat_member
Device sessions

37. test_logcat_backup_recovery_phrase
Device sessions

38. test_start_chat_with_ens
Device sessions

39. test_add_and_remove_contact_from_public_chat
Device sessions

40. test_add_account_to_multiaccount_instance_seed_phrase
Device sessions

41. test_open_blocked_site
Device sessions

42. test_open_chat_by_pasting_public_key
Device sessions

43. test_pair_devices_sync_one_to_one_contacts_public_chat
Device sessions

44. test_send_non_english_message_to_newly_added_contact
Device sessions

45. test_ens_username_recipient
Device sessions

46. test_token_with_more_than_allowed_decimals
Device sessions

47. test_fetch_more_history_in_empty_chat
Device sessions

48. test_open_public_chat_using_deep_link
Device sessions

49. test_switch_users_and_add_new_account
Device sessions

50. test_add_account_to_multiaccount_instance_generate_new
Device sessions

51. test_copy_contact_code_and_wallet_address
Device sessions

52. test_send_transaction_from_daap
Device sessions

53. test_send_two_transactions_one_after_another_in_dapp
Device sessions

54. test_image_in_one_to_one_send_save_reply
Device sessions

55. test_add_new_keycard_account_and_login
Device sessions

56. test_long_press_delete_clear_all_dapps
Device sessions

57. test_copy_and_paste_messages
Device sessions

58. test_back_forward_buttons_browsing_website
Device sessions

59. test_password_in_logcat_creating_account
Device sessions

60. test_sign_message_from_daap
Device sessions

61. test_dapps_permissions
Device sessions

62. test_request_public_key_status_test_daap
Device sessions

63. test_long_press_to_delete_chat
Device sessions

64. test_log_level_and_fleet
Device sessions

65. test_add_and_delete_watch_only_account_to_multiaccount_instance
Device sessions

66. test_recover_account_from_new_user_seedphrase
Device sessions

67. test_send_transaction_with_custom_token
Device sessions

68. test_send_eth_in_1_1_chat
Device sessions

69. test_send_two_transactions_in_batch_in_dapp
Device sessions

70. test_ens_in_public_and_1_1_chats
Device sessions

71. test_block_user_from_public_chat
Device sessions

72. test_fetching_balance_after_offline
Device sessions

73. test_offline_status
Device sessions

74. test_wallet_set_up
Device sessions

75. test_manage_assets
Device sessions

76. test_offline_messaging_1_1_chat
Device sessions

77. test_account_recovery_with_uppercase_recovery_phrase
Device sessions

78. test_send_token_with_7_decimals
Device sessions

79. test_user_can_see_all_own_assets_after_account_recovering
Device sessions

80. test_pass_phrase_validation
Device sessions

81. test_keycard_can_see_all_transactions_in_history
Device sessions

82. test_keycard_send_two_transactions_in_batch_in_dapp
Device sessions

83. test_send_emoji
Device sessions

84. test_filters_from_daap
Device sessions

85. test_redirect_to_public_chat_tapping_tag_message
Device sessions

86. test_restore_account_from_mnemonic_to_keycard
Device sessions

87. test_send_eth_to_ens_in_chat
Device sessions

88. test_send_eth_from_wallet_to_address
Device sessions

89. test_request_and_receive_stt_in_1_1_chat_offline
Device sessions

90. test_messaging_in_different_networks
Device sessions

91. test_collectible_from_wallet_opens_in_browser_view
Device sessions

92. test_insufficient_funds_wallet_positive_balance
Device sessions

@status-im-auto
Copy link
Member

100% of end-end tests have passed

Total executed tests: 1
Failed tests: 0
Passed tests: 1

Passed tests (1)

Click to expand
1. test_keycard_sign_message_from_daap
Device sessions

@Serhy
Copy link
Contributor

Serhy commented Jun 18, 2020

Looks good on Androids

@Ferossgp Ferossgp force-pushed the feature/remove-android-elevation branch from f34759a to 1afa0c5 Compare June 19, 2020 09:00
@flexsurfer
Copy link
Member

@Ferossgp can we merge this one ?

@Ferossgp
Copy link
Contributor Author

@flexsurfer I'm experimenting with other approaches to change shadow in android, let's skip this PR for 1.5

@Ferossgp Ferossgp changed the title Android tabbar replace elevation with border WIP Android tabbar replace elevation with border Jun 23, 2020
@status-im-auto
Copy link
Member

97% of end-end tests have passed

Total executed tests: 95
Failed tests: 3
Passed tests: 92

Failed tests (3)

Click to expand
1. test_send_transaction_with_custom_token

Device 1: Tap on OkButton
Device 1: Tap on TransactionHistoryButton

Device 1: Transaction 0.0531851 WEENUS was not found on Wallet/Transaction screen

Device sessions

2. test_block_user_from_public_chat

Device 1: Wait for OkButton
Device 1: Wait for ContinueButton

Device 1: 'MultiAccountOnLoginButton' is not found on the screen; also Unexpected Alert is shown: 'java.lang.AssertionError: No System TLS'

Device sessions

3. test_can_add_existing_ens

Device 1: Tap on ShareMyProfileButton
Device 1: ENSUsernameInShareChatKeyPopup is statuse2e.stateofus.eth

Owned username is not shown in ENS Dapp.

Device sessions

Passed tests (92)

Click to expand
1. test_request_public_key_status_test_daap
Device sessions

2. test_open_public_chat_using_deep_link
Device sessions

3. test_ens_username_recipient
Device sessions

4. test_keycard_can_see_all_transactions_in_history
Device sessions

5. test_offline_status
Device sessions

6. test_open_transaction_on_etherscan
Device sessions

7. test_open_chat_by_pasting_public_key
Device sessions

8. test_back_forward_buttons_browsing_website
Device sessions

9. test_password_in_logcat_creating_account
Device sessions

10. test_can_use_purchased_stickers_on_recovered_account
Device sessions

11. test_insufficient_funds_wallet_positive_balance
Device sessions

12. test_mobile_data_usage_settings
Device sessions

13. test_open_google_com_via_open_dapp
Device sessions

14. test_logcat_backup_recovery_phrase
Device sessions

15. test_unread_messages_counter_public_chat
Device sessions

16. test_send_two_transactions_one_after_another_in_dapp
Device sessions

17. test_user_can_switch_network
Device sessions

18. test_public_chat_clear_history
Device sessions

19. test_wallet_set_up
Device sessions

20. test_timestamp_in_chats
Device sessions

21. test_delete_chats_via_delete_button
Device sessions

22. test_add_account_to_multiaccount_instance_seed_phrase
Device sessions

23. test_fetch_more_history_in_empty_chat
Device sessions

24. test_mobile_data_usage_popup_continue_syncing
Device sessions

25. test_keycard_fetching_balance_after_offline
Device sessions

26. test_add_to_contacts
Device sessions

27. test_dapps_permissions
Device sessions

28. test_long_press_delete_clear_all_dapps
Device sessions

29. test_need_help_section
Device sessions

30. test_transaction_wrong_password_wallet
Device sessions

31. test_offline_messaging_1_1_chat
Device sessions

32. test_token_with_more_than_allowed_decimals
Device sessions

33. test_add_account_to_multiaccount_instance_private_key
Device sessions

34. test_text_message_1_1_chat
Device sessions

35. test_install_pack_and_send_sticker
Device sessions

36. test_send_eth_in_1_1_chat
Device sessions

37. test_pair_devices_sync_one_to_one_contacts_public_chat
Device sessions

38. test_image_in_one_to_one_send_save_reply
Device sessions

39. test_send_emoji
Device sessions

40. test_copy_and_paste_messages
Device sessions

41. test_restore_account_from_mnemonic_to_keycard
Device sessions

42. test_add_account_to_multiaccount_instance_generate_new
Device sessions

43. test_send_eth_from_wallet_to_address
Device sessions

44. test_messaging_in_different_networks
Device sessions

45. test_start_chat_with_ens
Device sessions

46. test_logcat_recovering_account
Device sessions

47. test_offline_add_new_group_chat_member
Device sessions

48. test_connection_is_secure
Device sessions

49. test_keycard_send_transaction_from_daap
Device sessions

50. test_user_can_see_all_own_assets_after_account_recovering
Device sessions

51. test_send_eth_to_ens_in_chat
Device sessions

52. test_keycard_sign_message_from_daap
Device sessions

53. test_long_press_to_delete_chat
Device sessions

54. test_add_and_remove_contact_from_public_chat
Device sessions

55. test_send_transaction_from_daap
Device sessions

56. test_onboarding_screen_when_requesting_tokens_for_recovered_account
Device sessions

57. test_keycard_send_eth_from_wallet_to_address
Device sessions

58. test_keycard_send_two_transactions_one_after_another_in_dapp
Device sessions

59. test_add_and_delete_watch_only_account_to_multiaccount_instance
Device sessions

60. test_open_blocked_site
Device sessions

61. test_refresh_button_browsing_app_webview
Device sessions

62. test_public_chat_messaging
Device sessions

63. test_pass_phrase_validation
Device sessions

64. test_send_token_with_7_decimals
Device sessions

65. test_sign_message_from_daap
Device sessions

66. test_recover_account_from_new_user_seedphrase
Device sessions

67. test_add_new_keycard_account_and_login
Device sessions

68. test_decline_transactions_in_1_1_chat
Device sessions

69. test_send_and_open_links
Device sessions

70. test_manage_assets
Device sessions

71. test_share_contact_code_and_wallet_address
Device sessions

72. test_request_and_receive_stt_in_1_1_chat_offline
Device sessions

73. test_redirect_to_public_chat_tapping_tag_message
Device sessions

74. test_ens_in_public_and_1_1_chats
Device sessions

75. test_sign_typed_message (TestRail link is not found)
Device sessions

76. test_create_new_group_chat
Device sessions

77. test_password_in_logcat_sign_in
Device sessions

78. test_account_recovery_with_uppercase_recovery_phrase
Device sessions

79. test_mobile_data_usage_popup_stop_syncing
Device sessions

80. test_send_non_english_message_to_newly_added_contact
Device sessions

81. test_collectible_from_wallet_opens_in_browser_view
Device sessions

82. test_contact_profile_view
Device sessions

83. test_keycard_send_two_transactions_in_batch_in_dapp
Device sessions

84. test_switch_users_and_add_new_account
Device sessions

85. test_send_two_transactions_in_batch_in_dapp
Device sessions

86. test_filters_from_daap
Device sessions

87. test_login_with_new_account
Device sessions

88. test_home_view
Device sessions

89. test_log_level_and_fleet
Device sessions

90. test_copy_contact_code_and_wallet_address
Device sessions

91. test_fetching_balance_after_offline
Device sessions

92. test_can_see_all_transactions_in_history
Device sessions

@oskarth
Copy link
Contributor

oskarth commented Jul 1, 2020

Small request - could you please rebase to latest master so this commit b5fda12 gets included? This means we aren't running E2E tests on eth.prod cluster anymore, and since this happens on every push, the impact is quite big. This ensures we have more accurate metrics going forward from Jul 1 onward, which would be awesome. See https://discuss.status.im/t/user-growth-and-retention/1782 for more

@weekly-digest weekly-digest bot mentioned this pull request Jul 5, 2020
Closed
@flexsurfer
Copy link
Member

@Ferossgp any updates on this ?

@Ferossgp Ferossgp closed this Oct 26, 2020
@Ferossgp Ferossgp reopened this Dec 11, 2020
@Ferossgp Ferossgp force-pushed the feature/remove-android-elevation branch 2 times, most recently from acca83a to b007520 Compare December 11, 2020 14:46
@Ferossgp Ferossgp changed the title WIP Android tabbar replace elevation with border Android tabbar replace elevation with border Dec 14, 2020
@status-im-auto
Copy link
Member

99% of end-end tests have passed

Total executed tests: 91
Failed tests: 1
Passed tests: 90

IDs of failed tests: 6287

Failed tests (1)

Click to expand
1. test_keycard_send_two_transactions_in_batch_in_dapp, id: 6287

Device 1: Tap on TwoPinKeyboardButton
Device 1: Looking for an element by text part: 'Transaction failed'

Device 1: Transaction failed; also Unexpected Alert is shown: 'nonce too low'

Device sessions

Passed tests (90)

Click to expand
1. test_image_in_one_to_one_send_save_reply_timeline, id: 6305
Device sessions

2. test_add_account_to_multiaccount_instance_generate_new, id: 6224
Device sessions

3. test_send_eth_from_wallet_to_address, id: 5308
Device sessions

4. test_onboarding_screen_when_requesting_tokens_for_recovered_account, id: 5677
Device sessions

5. test_keycard_can_see_all_transactions_in_history, id: 6291
Device sessions

6. test_text_message_1_1_chat, id: 5305
Device sessions

7. test_push_notification_1_1_chat, id: 6283
Device sessions

8. test_delete_chats_via_delete_button, id: 5387
Device sessions

9. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244
Device sessions

10. test_long_press_delete_clear_all_dapps, id: 5390
Device sessions

11. test_open_public_chat_using_deep_link, id: 5396
Device sessions

12. test_offline_add_new_group_chat_member, id: 3998
Device sessions

13. test_copy_contact_code_and_wallet_address, id: 5375
Device sessions

14. test_add_account_to_multiaccount_instance_private_key, id: 6272
Device sessions

15. test_mobile_data_usage_popup_continue_syncing, id: 5741
Device sessions

16. test_insufficient_funds_wallet_positive_balance, id: 5412
Device sessions

17. test_create_new_group_chat, id: 3994
Device sessions

18. test_messaging_in_different_networks, id: 5338
Device sessions

19. test_send_token_with_7_decimals, id: 5350
Device sessions

20. test_recover_account_from_new_user_seedphrase, id: 6296
Device sessions

21. test_keycard_can_recover_keycard_account_card_pairing, id: 5758
Device sessions

22. test_block_user_from_public_chat, id: 5786
Device sessions

23. test_send_audio_message_with_push_notification_check, id: 6316
Device sessions

24. test_ens_username_recipient, id: 5406
Device sessions

25. test_keycard_send_eth_to_ens, id: 6295
Device sessions

26. test_send_non_english_message_to_newly_added_contact, id: 5315
Device sessions

27. test_switch_users_and_add_new_account, id: 5356
Device sessions

28. test_mobile_data_usage_popup_stop_syncing, id: 6228
Device sessions

29. test_open_transaction_on_etherscan, id: 5384
Device sessions

30. test_keycard_send_eth_from_wallet_to_address, id: 6289
Device sessions

31. test_request_public_key_status_test_daap, id: 5397
Device sessions

32. test_sign_message_from_daap, id: 5342
Device sessions

33. test_back_forward_buttons_browsing_website, id: 5321
Device sessions

34. test_account_recovery_with_uppercase_recovery_phrase_logcat, id: 5394
Device sessions

35. test_redirect_to_public_chat_tapping_tag_message, id: 5675
Device sessions

36. test_keycard_send_two_transactions_one_after_another_in_dapp, id: 6288
Device sessions

37. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
Device sessions

38. test_long_press_to_delete_chat, id: 5319
Device sessions

39. test_copy_and_paste_messages, id: 5317
Device sessions

40. test_unread_messages_counter_public_chat, id: 5360
Device sessions

41. test_user_can_see_all_own_assets_after_account_recovering, id: 5381
Device sessions

42. test_transaction_wrong_password_wallet, id: 5408
Device sessions

43. test_user_can_switch_network, id: 5299
Device sessions

44. test_start_chat_with_ens_mention_in_one_to_one, id: 5403
Device sessions

45. test_send_two_transactions_one_after_another_in_dapp, id: 5744
Device sessions

46. test_mobile_data_usage_settings, id: 6229
Device sessions

47. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265
Device sessions

48. test_add_to_contacts, id: 5316
Device sessions

49. test_fetch_more_history_in_empty_chat, id: 6205
Device sessions

50. test_install_pack_and_send_sticker, id: 5782
Device sessions

51. test_keycard_sign_message_from_daap, id: 6251
Device sessions

52. test_manage_assets, id: 5341
Device sessions

53. test_send_two_transactions_in_batch_in_dapp, id: 5743
Device sessions

54. test_timestamp_in_chats, id: 5385
Device sessions

55. test_request_stt_from_daap, id: 5309
Device sessions

56. test_send_emoji, id: 5328
Device sessions

57. test_can_use_purchased_stickers_on_recovered_account, id: 5783
Device sessions

58. test_dapps_permissions, id: 5738
Device sessions

59. test_open_chat_by_pasting_public_key, id: 5304
Device sessions

60. test_login_with_new_account_logcat, id: 5312
Device sessions

61. test_send_eth_to_ens_in_chat, id: 6279
Device sessions

62. test_open_blocked_secure_not_secure_sites, id: 6210
Device sessions

63. test_wallet_set_up, id: 5335
Device sessions

64. test_send_transaction_with_custom_token, id: 6208
Device sessions

65. test_home_view, id: 5379
Device sessions

66. test_can_add_existing_ens, id: 5502
Device sessions

67. test_logcat_backup_recovery_phrase, id: 5419
Device sessions

68. test_offline_is_shown_messaging_1_1_chat, id: 5310
Device sessions

69. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263
Device sessions

70. test_need_help_section, id: 5391
Device sessions

71. test_send_eth_in_1_1_chat, id: 6253
Device sessions

72. test_refresh_button_browsing_app_webview, id: 5354
Device sessions

73. test_collectible_from_wallet, id: 5346
Device sessions

74. test_public_chat_messaging, id: 5313
Device sessions

75. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
Device sessions

76. test_keycard_request_stt_from_daap, id: 6249
Device sessions

77. test_add_account_to_multiaccount_instance_seed_phrase, id: 6271
Device sessions

78. test_restore_account_from_mnemonic_to_keycard, id: 6240
Device sessions

79. test_add_new_keycard_account_and_login, id: 5689
Device sessions

80. test_pass_phrase_validation, id: 5363
Device sessions

81. test_send_and_open_links, id: 5373
Device sessions

82. test_share_contact_code_and_wallet_address, id: 5323
Device sessions

83. test_keycard_send_eth_in_1_1_chat, id: 6293
Device sessions

84. test_ens_mentions_and_nickname_in_public_and_1_1_chats, id: 6226
Device sessions

85. test_can_see_all_transactions_in_history, id: 5314
Device sessions

86. test_public_chat_clear_history, id: 5386
Device sessions

87. test_reactions_to_message_in_chats, id: 6315
Device sessions

88. test_filters_from_daap, id: 5353
Device sessions

89. test_fetching_balance_after_offline, id: 6237
Device sessions

90. test_keycard_fetching_balance_after_offline, id: 6290
Device sessions

@Serhy Serhy self-assigned this Dec 15, 2020
@Serhy
Copy link
Contributor

Serhy commented Dec 18, 2020 •
edited
Loading

Checked with Android 6, 8, 9, 10 - no gradient anymore with dark and light mode. And it shows on iOS.
Thanks, @Ferossgp

@Ferossgp
Android tabbar replace elevation with border
8342972 
Signed-off-by: Gheorghe Pinzaru <feross95@gmail.com>
@Ferossgp Ferossgp force-pushed the feature/remove-android-elevation branch from b007520 to 8342972 Compare December 21, 2020 12:02
@Ferossgp Ferossgp merged commit 8342972 into develop Dec 21, 2020
@Ferossgp Ferossgp deleted the feature/remove-android-elevation branch December 21, 2020 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flexsurfer flexsurfer flexsurfer approved these changes

Assignees

@Ferossgp Ferossgp

@Serhy Serhy

Labels
Tested - OK
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
Mobile bug fixes and small improvements
Development

Successfully merging this pull request may close these issues.

Disable elevation on Android Tab Bar, replace it with a 1pt divider
6 participants
@Ferossgp @status-im-auto @Serhy @flexsurfer @oskarth @hesterbruikman