[#10195] Separate keystore dir per multiacc #10847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (56)
|
|
fyi @johnlea-quiup as this relates to key management, specifically removing a 'multiaccount' (master keypair) |
rasom
force-pushed
the
key-store-per-multiacc2
branch
from
5eb0811
to
a29bfa0
Compare
rasom
force-pushed
the
key-store-per-multiacc2
branch
5 times, most recently
from
8dbc55b
to
e807a44
Compare
yenda
reviewed
Jun 26, 2020
|
Small request - could you please rebase to latest master so this commit b5fda12 gets included? This means we aren't running E2E tests on eth.prod cluster anymore, and since this happens on every push, the impact is quite big. This ensures we have more accurate metrics going forward from Jul 1 onward, which would be awesome. See https://discuss.status.im/t/user-growth-and-retention/1782 for more |
rasom
force-pushed
the
key-store-per-multiacc2
branch
2 times, most recently
from
1f8f8d3
to
a2dfae2
Compare
flexsurfer
approved these changes
Jul 2, 2020
99% of end-end tests have passedFailed tests (1)Click to expand
Passed tests (93)Click to expand |
Can't send transaction from account if it is added as separate multiaccount with keycardSteps:
Expected result: can send Transaction |
rasom
force-pushed
the
key-store-per-multiacc2
branch
from
a2dfae2
to
00e2380
Compare
@churik is this even possible? |
|
Previous issue is not reproducible with the same steps, but I've got another error: Steps:
Expected result: can send Transaction Logs: Status-debug-logs.zip |
rasom
force-pushed
the
key-store-per-multiacc2
branch
from
24bc63e
to
e9de818
Compare
'Cannot retrieve a valid key for a given multiaccount error' after upgrade with 2 multiaccountsSteps:
Expected result: Actual result: error |
rasom
force-pushed
the
key-store-per-multiacc2
branch
from
e9de818
to
eda3b12
Compare
rasom
force-pushed
the
key-store-per-multiacc2
branch
from
eda3b12
to
e2d1186
Compare
|
Tested on Android 10:
Tested on IOS 13:
Looks good to me, thank you for patience @rasom |
rasom
force-pushed
the
key-store-per-multiacc2
branch
from
e2d1186
to
c105bac
Compare
Having all keys related to specific multiacc in a separate dir will simplify removing of the multiacc. Also it will allow adding of the same account to different multiaccs.
rasom
force-pushed
the
key-store-per-multiacc2
branch
from
c105bac
to
920bc7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10195
Having all keys related to specific multiacc in a separate dir will simplify removing of the multiacc.
Also it will allow adding of the same account to different multiaccs.
depends on status-im/status-go#1993
status: ready