Add separate target/scheme for ios pr build #10867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (34)
|
|
@jakubgs can you jump in? |
|
This is great, I tried to do that a year ago in #7479 but I could not fix the builds. Kept getting: Which drove me insane. I hope this works. Here's the PR: https://github.com/status-im/status-react-jenkins/pull/9 |
Ferossgp
force-pushed
the
feature/add-separate-target-ios-pr
branch
2 times, most recently
from
db77752
to
b94f927
Compare
|
I created two new provisioning profiles with
It should work now. I'll update the branch. |
jakubgs
force-pushed
the
feature/add-separate-target-ios-pr
branch
from
d862bc9
to
24ab422
Compare
|
It doesn't seem to like the profile: The profiles |
jakubgs
force-pushed
the
feature/add-separate-target-ios-pr
branch
from
24ab422
to
a4ef7b4
Compare
|
Looks like temporarily enabling automatic signing management and re-creating profiles fixed it: |
jakubgs
force-pushed
the
feature/add-separate-target-ios-pr
branch
from
a4ef7b4
to
cbb421e
Compare
Ferossgp
force-pushed
the
feature/add-separate-target-ios-pr
branch
3 times, most recently
from
7bc8c60
to
5174428
Compare
jakubgs
approved these changes
Jun 26, 2020
| signingStyle: 'manual', | ||
| provisioningProfiles: { | ||
| "im.status.ethereum": "match AdHoc im.status.ethereum", | ||
| "im.status.ethereum.pr": "match AdHoc im.status.ethereum.pr" |
There was a problem hiding this comment.
Kinda annoying we need this, but ah well.
jakubgs
reviewed
Jun 26, 2020
Ferossgp
force-pushed
the
feature/add-separate-target-ios-pr
branch
from
637610d
to
24e7510
Compare
Build PR Scheme in PR build use named parameters, use pr_build boolean Signed-off-by: Jakub Sokołowski <jakub@status.im> Enable capabilities Signed-off-by: Jakub Sokołowski <jakub@status.im> Add custom app icon Remove user defined profile Add PR scheme Explicit provide provisioning profiles Fix pr schema Bump jenkins Pod bump Describe pr_build argument Signed-off-by: Gheorghe Pinzaru <feross95@gmail.com>
Ferossgp
force-pushed
the
feature/add-separate-target-ios-pr
branch
from
24e7510
to
d916751
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to have a separate app identifier for PR build so we can use the release version on day to day basis, and be able to test new PRs without removing the release from the phone.