New UI for chat input #10873
Merged
New UI for chat input #10873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ferossgp
force-pushed
the
feature/new-ui-for-chat-inpu
branch
2 times, most recently
from
61d970d
to
c6d3c9c
Compare
Jenkins BuildsClick to see older builds (81)
|
|
inb4, this PR is for the redesign of the chat input. I was too lazy to create an issue first but it's been heavily discussed between me and Gheorghe. This work is awesome! |
Ferossgp
force-pushed
the
feature/new-ui-for-chat-inpu
branch
from
c6d3c9c
to
a511495
Compare
|
Small request - could you please rebase to latest master so this commit b5fda12 gets included? This means we aren't running E2E tests on eth.prod cluster anymore, and since this happens on every push, the impact is quite big. This ensures we have more accurate metrics going forward from Jul 1 onward, which would be awesome. See https://discuss.status.im/t/user-growth-and-retention/1782 for more |
Ferossgp
force-pushed
the
feature/new-ui-for-chat-inpu
branch
2 times, most recently
from
7391072
to
7e347d3
Compare
Ferossgp
force-pushed
the
feature/new-ui-for-chat-inpu
branch
3 times, most recently
from
f72b4df
to
ffc2ef5
Compare
Ferossgp
force-pushed
the
feature/new-ui-for-chat-inpu
branch
5 times, most recently
from
051dbe9
to
fff1c13
Compare
|
Looks great! Tried on Samsung Galaxy S10e - Android 10 Couldn't figure out how to
|
|
correct, I'm guessing that's a bug |
Ferossgp
force-pushed
the
feature/new-ui-for-chat-inpu
branch
from
fff1c13
to
f9ab011
Compare
88% of end-end tests have passedFailed tests (12)Click to expand
Passed tests (85)Click to expand |
Ferossgp
force-pushed
the
feature/new-ui-for-chat-inpu
branch
from
b5bb38d
to
8f4a88b
Compare
cammellos
approved these changes
Jul 16, 2020
Ferossgp
force-pushed
the
feature/new-ui-for-chat-inpu
branch
from
272d6e2
to
282402f
Compare
ISSUE 7: bottom sheet is not closed when navigating to + > Start new chat (Android only, not reproducible on nightly)
|
Ferossgp
force-pushed
the
feature/new-ui-for-chat-inpu
branch
from
577a8c7
to
d48a019
Compare
|
@Ferossgp |
50% of end-end tests have passedFailed tests (1)Click to expand
Passed tests (1)Click to expand
|
Ferossgp
commented
Jul 17, 2020
Comment on lines
33
to
34
| :border-radius 4 | ||
| :resize-mode :center} |
There was a problem hiding this comment.
To remove in this PR
|
@Ferossgp |
churik
approved these changes
Jul 17, 2020
Ferossgp
force-pushed
the
feature/new-ui-for-chat-inpu
branch
from
7934371
to
7f6510e
Compare
New input UI Inverse panel height calculation Remove old chat input Better animations fix for pasting text Add buttons accessibility Fix dark mode Update react navigation to fix the keyboard issues Force close bottom sheet Unmount android bottom sheet when not visible Reset bottom sheet height android more fixes more fixes Add hidden audio icon Signed-off-by: Gheorghe Pinzaru <feross95@gmail.com>
Ferossgp
force-pushed
the
feature/new-ui-for-chat-inpu
branch
from
be2941a
to
e8fca7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.