[#10891] Add 'Add new contact' and 'Invite friends' button to Contact… #10896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (25)
|
flexsurfer
force-pushed
the
feature/new-contact
branch
from
0945208
to
2f4f957
Compare
|
@flexsurfer is it possible to flex vertically center the also, in this instance, can we use the
|
|
@errorists yes its possible but i trust only figma :) |
flexsurfer
force-pushed
the
feature/new-contact
branch
from
2f4f957
to
7a6f4c0
Compare
|
done |
flexsurfer
force-pushed
the
feature/new-contact
branch
from
7a6f4c0
to
477241c
Compare
|
Small request - could you please rebase to latest master so this commit b5fda12 gets included? This means we aren't running E2E tests on eth.prod cluster anymore, and since this happens on every push, the impact is quite big. This ensures we have more accurate metrics going forward from Jul 1 onward, which would be awesome. See https://discuss.status.im/t/user-growth-and-retention/1782 for more EDIT: Since this is a recent PR, it might've been included already. All good if so |
flexsurfer
force-pushed
the
feature/new-contact
branch
from
477241c
to
34c664a
Compare
flexsurfer
force-pushed
the
feature/new-contact
branch
2 times, most recently
from
91cf452
to
a5d448f
Compare
100% of end-end tests have passedPassed tests (94)Click to expand
|
flexsurfer
force-pushed
the
feature/new-contact
branch
from
a5d448f
to
f841adf
Compare
flexsurfer
requested review from
rasom
and removed request for
a team,
vitvly and
Ferossgp
98% of end-end tests have passedFailed tests (2)Click to expand
Passed tests (95)Click to expand
|
cammellos
approved these changes
Jul 6, 2020
|
@flexsurfer please rebase it to current develop, I'll take it. |
flexsurfer
force-pushed
the
feature/new-contact
branch
2 times, most recently
from
ee1293b
to
be332a3
Compare
flexsurfer
force-pushed
the
feature/new-contact
branch
from
be332a3
to
82ac190
Compare
|
@flexsurfer tappable area for "Add new contact": BTW: when I tap on it second time, the tappable area is changed to expected. |
|
@churik its regular list item, it worked before quo merge, so its not in the scope of this PR |
98% of end-end tests have passedFailed tests (2)Click to expand
Passed tests (94)Click to expand
|
|
@Ferossgp let me know when I can retest. |
… screen Signed-off-by: andrey <motor4ik@gmail.com>
flexsurfer
force-pushed
the
feature/new-contact
branch
from
82ac190
to
3800f3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10891
fixes #10892