ci: fix what version is set for iOS PR builds #10907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (25)
|
jakubgs
force-pushed
the
fix-ios-pr-build-version
branch
2 times, most recently
from
d712fe5
to
9064159
Compare
|
Fails in a way that gives no useful information: |
|
The #!/bin/sh
#!/usr/bin/env bash
source "${PROJECT_DIR}/scripts/set_xcode_version.sh"Which is our own script: |
jakubgs
force-pushed
the
fix-ios-pr-build-version
branch
from
9064159
to
309cfb9
Compare
jakubgs
force-pushed
the
fix-ios-pr-build-version
branch
4 times, most recently
from
f39b5e4
to
e6de12a
Compare
|
Okay, managed to get some logs out of it: |
jakubgs
force-pushed
the
fix-ios-pr-build-version
branch
from
e6de12a
to
50e2a80
Compare
|
Oh snap, I think I fixed it. The newest iOS build worked on my iPhone 5s that previously didn't work. @churik can you check this one? |
jakubgs
force-pushed
the
fix-ios-pr-build-version
branch
from
50e2a80
to
8d1b3a9
Compare
|
Tried last build https://i.diawi.com/ffy3yR - doesn't work, #10904 - the same problem |
|
Works for me with lat build https://i.diawi.com/Pfbwmc , can install app and create account |
jakubgs
force-pushed
the
fix-ios-pr-build-version
branch
from
8d1b3a9
to
619a353
Compare
|
Failed e2e are not related to PR |
Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
force-pushed
the
fix-ios-pr-build-version
branch
from
619a353
to
b95056f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #10904. Testing if using the right version might fix the iOS PR builds.
Also changes
ios/scripts/set_xcode_version.shto fix an issue with:Not sure how that was caused, so I'd prefer if someone from Core tested the iOS build locally.
Related: https://github.com/status-im/status-react-jenkins/pull/10