[#10179] Create invite link for group chat #10937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (33)
|
|
@flexsurfer Noticing the two open tasks:
Are you blocked by anything? Still think this is relevant. Could probably use the flow for moderated public chats (organization channels) lateron as well. Designs got a little lost in the thread, but are here Let me know if you have any doubts about the work |
|
@hesterbruikman no i'm not blocking anymore and i keep working on it, i don't have experience with go and messages, so it will take some time for me |
flexsurfer
force-pushed
the
feature/group-chat-invite
branch
from
c7f28c4
to
f9bc183
Compare
flexsurfer
changed the title
97% of end-end tests have passedFailed tests (3)Click to expand
Passed tests (94)Click to expand |
96% of end-end tests have passedFailed tests (4)Click to expand
Passed tests (93)Click to expand |
|
Fantastic work @flexsurfer! Had a true moment of delight seeing a familiar group right after onboarding! Use case 1: User A (admin) creates invite link on Android. User B opens link on iOS(Status already downloaded, onboarding not completed, can't test join.status flow yet) Use case 2: User B sends membership requestResult: Group admin sees group membership request
Use case 3: User A (admin) accepts membership requestResult: User B gets group chat invite and can join as per current invite
Use case 4: User A (admin) declines membership requestResult: User B gets
Use case 5: User B retries membership requestResult: User A sees
Use case 6: User B removes groupResult: User A sees
Use case 7: User B opens invite link when Status is installed and account is openResult: App is opened in Group chat membership request view
Use case 8: User B opens invite link when Status is installed, account is lockedResult: App is opened, after unlock, Group chat membership request view opens
Use case 9: User B opens invite link when Status is installed, app not runningResult: App is opened, after unlock, Group chat membership request view opens
Use case 10: User B opens link with install that already has an existing multiaccount (open or not)
|
flexsurfer
force-pushed
the
feature/group-chat-invite
branch
from
9931233
to
9e0de02
Compare
|
thanks @hesterbruikman , Issue 2: and Issue 5 have been fixed |
|
not sure how to reproduce |
flexsurfer
force-pushed
the
feature/group-chat-invite
branch
from
9e0de02
to
b4efa64
Compare
74% of end-end tests have passedFailed tests (25)Click to expand
Passed tests (73)Click to expand |
|
@flexsurfer regarding issue 1, here's a recording of iPhone 8. @errorists can you see if it's reproducible on a newer model |
flexsurfer
force-pushed
the
feature/group-chat-invite
branch
from
f2eb630
to
093c004
Compare
|
@churik fixed 10 and 11 |
|
@flexsurfer sorry for delay! QUESTION 7: no indicators of pending membership request on home viewNot resolved according to #10937 (comment) ISSUE 12: user is redirected to home view instead membership request after onboarding (when new multiaccount is created)After tapping on valid ISSUE 13: List in 'Group invite' is not scrollableIf Group invites > 4 (tested on IPhone 7), last 3 items are unaccessible ISSUE 14: Limit of 10 members is not working with group invitesAs the number of membership requests is not limited, you can accept any amount of requests and exceed the limit of 10 members. ISSUE 15: Can click 'Join', 'Accept' several timesConsequense: |
|
ISSUE 14: Limit of 10 members is not working with group invites |
flexsurfer
force-pushed
the
feature/group-chat-invite
branch
from
093c004
to
3eac425
Compare
|
thanks @churik 13-15 have been fixed, QUESTION 7 and ISSUE 12 won't be addressed in this PR |
97% of end-end tests have passedFailed tests (3)Click to expand
Passed tests (95)Click to expand
|
100% of end-end tests have passedPassed tests (3)Click to expand
|
flexsurfer
force-pushed
the
feature/group-chat-invite
branch
2 times, most recently
from
d02d849
to
81fd672
Compare
99% of end-end tests have passedFailed tests (1)Click to expand
Passed tests (98)Click to expand
|
Signed-off-by: andrey <motor4ik@gmail.com>
flexsurfer
force-pushed
the
feature/group-chat-invite
branch
from
81fd672
to
89ad4f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10179