-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mentions #10953
Conversation
fa769b3
to
1201a20
Compare
Jenkins BuildsClick to see older builds (7)
|
@yenda what do you suspect is not working? TestedSamsung S10e Android 10
Findings
Issue 1On iOS, need to tap again on the text input field to make the whole name a Issue 2On iOS, need to enter the first letter to pull up list to select name. Not a blocker IMO @yenda @errorists can you please join #xyz to try? Mentions on iOS |
In short, great work @yenda! Let's dig some more for issues that really require addressing for a first mentions release. Most prominent for me is seeing if there is a way to send a notification on mention. I didn't receive any on Android. |
just to confirm I tested on iOS and the noticeable bugs that impacted the previous PR are still present here too, most notably deleting letters in input and inserting them right after. |
some notes, |
Just rebased PR onto current |
@hesterbruikman
Do we have steps to reproduce and more details on this somewhere? |
The issue @errorists described does need insurance that it's resolved as it caused a regression to message input in general. I'll check as you rebased onto develop. @errorists can you please do the same and check again on this rebased PR. my eyes are not a reliable source to capture that jitter issue |
Some more findings and recapping earlier comments. I think all, except 1, should be addressed in a separate PR (bounty) if they are not regressions to text input in general. Functionality of receiving a notification when mentioned is more important To address in this PR
To address in separate PR
Earlier comments
cc @churik @Serhy |
I can confirm that the issue of jittery text input is gone on iOS 🎉 should not be the case, it can only reach the bottom of the top bar, not cover it. |
@hesterbruikman this PR was only about suggestion in input, I can try to check what's wrong there but it looks totally unrelated to the rest of PR |
@hesterbruikman There are many more little bugs besides those which are already mentioned in the PR, and it is really hard to debug and fix them at the moment. So I'm going to try to implement parts of it separately from the scratch, because fixing existing implementation takes too long. One comment regarding issues mentioned in the comments: you want to have mention to be parsed from the input without tapping on the user in suggestion, but that's not how it works in some other messengers (for instance in discord you actually have to tap on suggestions, otherwise mention will not be highlighted). So my question is: do we have a written spec on how it should work (not only tapping on suggestion) or do we use some other app as a reference? |
btw in Telegram/Discord the chat is opened in this case, not profile. So it would be really great to see the list of all those requirements somewhere. |
Just to summarise it:
and so on, we need the full list |
@rasom I'm afraid there is no requirements list, we're making this up as we're going along, like say with the issue of tapping on mentioned username, I wouldn't have an opinion on it without trying it out in the live implementation first.
yes, on iOS where it's a possibility. I think it's a no brainer, on less tap to start a mention. Specifically it should be the
yes, it's the better UX, if you write down the exact username following
yes, 100% defo
yes, to confirm that this will register as a mention and not plain text |
so what's happening next:
|
working well on Android but not iOS?