Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix: allow XCode versions 11.5 and higher #11019

Merged
merged 1 commit into from
Jul 31, 2020
Merged

Conversation

jakubgs
Copy link
Member

@jakubgs jakubgs commented Jul 30, 2020

This is kinda hacky, but is simple enough since the version check uses grep.

For details see:
https://github.com/status-im/nixpkgs/blob/status-mods/pkgs/development/mobile/xcodeenv/compose-xcodewrapper.nix

@status-im-auto
Copy link
Member

status-im-auto commented Jul 30, 2020

Jenkins Builds

Click to see older builds (26)
Commit #️⃣ Finished (UTC) Duration Platform Result
f9de5e6 #1 2020-07-30 15:11:38 ~3 min ios 📄log
554567e #2 2020-07-30 15:18:19 ~2 min ios 📄log
✔️ 554567e #2 2020-07-30 15:29:01 ~13 min android-e2e 📦apk 📲
✔️ 554567e #2 2020-07-30 15:29:06 ~13 min android 📦apk 📲
7ba9ce3 #3 2020-07-30 15:34:53 ~2 min ios 📄log
a35e2a4 #4 2020-07-30 15:45:20 ~2 min ios 📄log
✔️ a35e2a4 #4 2020-07-30 15:55:30 ~13 min android 📦apk 📲
✔️ a35e2a4 #4 2020-07-30 15:55:34 ~13 min android-e2e 📦apk 📲
71dfcea #5 2020-07-30 17:03:03 ~2 min ios 📄log
✔️ 71dfcea #5 2020-07-30 17:11:43 ~11 min android-e2e 📦apk 📲
✔️ 71dfcea #5 2020-07-30 17:12:13 ~12 min android 📦apk 📲
c4ce30f #6 2020-07-30 17:43:18 ~2 min ios 📄log
c89edbb #7 2020-07-30 17:52:23 ~2 min ios 📄log
✔️ c89edbb #7 2020-07-30 18:02:30 ~13 min android-e2e 📦apk 📲
✔️ c89edbb #7 2020-07-30 18:02:40 ~13 min android 📦apk 📲
4f62684 #8 2020-07-30 18:23:39 ~3 min ios 📄log
✔️ 4f62684 #8 2020-07-30 18:32:46 ~13 min android-e2e 📦apk 📲
✔️ 4f62684 #8 2020-07-30 18:32:57 ~13 min android 📦apk 📲
f2b7a92 #9 2020-07-30 22:26:07 ~2 min ios 📄log
5129034 #10 2020-07-30 22:30:53 ~2 min ios 📄log
aaae48f #11 2020-07-30 22:35:48 ~2 min ios 📄log
✔️ aaae48f #11 2020-07-30 22:42:01 ~9 min android-e2e 📦apk 📲
✔️ aaae48f #11 2020-07-30 22:42:49 ~9 min android 📦apk 📲
a54a8cd #12 2020-07-31 08:38:09 ~2 min ios 📄log
a54a8cd #12 2020-07-31 08:38:15 ~3 min android 📄log
a54a8cd #12 2020-07-31 08:38:15 ~3 min android-e2e 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 8d4aefb #13 2020-07-31 08:58:13 ~11 min android-e2e 📦apk 📲
✔️ 8d4aefb #13 2020-07-31 08:58:13 ~11 min android 📦apk 📲
✔️ 8d4aefb #13 2020-07-31 09:03:00 ~16 min ios 📦ipa 📲
✔️ 16316e8 #14 2020-07-31 10:27:24 ~10 min android 📦apk 📲
✔️ 16316e8 #14 2020-07-31 10:30:19 ~13 min android-e2e 📦apk 📲
✔️ 16316e8 #14 2020-07-31 10:53:22 ~36 min ios 📦ipa 📲

@jakubgs jakubgs force-pushed the allow-higher-xcode branch 3 times, most recently from 7ba9ce3 to a35e2a4 Compare July 30, 2020 15:42
@jakubgs
Copy link
Member Author

jakubgs commented Jul 30, 2020

Ah damn, I can't use a regex like that because it's also included in the package name.

@jakubgs jakubgs force-pushed the allow-higher-xcode branch 10 times, most recently from 8d4aefb to 16316e8 Compare July 31, 2020 10:17
@jakubgs
Copy link
Member Author

jakubgs commented Jul 31, 2020

I updated the xcodeWrapper by putting our own version at nix/pkgs/xcodeenv/compose-xcodewrapper.nix and adding it to the packages overlay. It now supports the allowHigher argument which defaults to false but we set it to true.

I might try getting this into official Nixpkgs.

This is kinda hacky, but is simple enough since the version check uses grep.

For details see:
https://github.com/status-im/nixpkgs/blob/status-mods/pkgs/development/mobile/xcodeenv/compose-xcodewrapper.nix

Signed-off-by: Jakub Sokołowski <jakub@status.im>
@jakubgs jakubgs merged commit 933c0f8 into develop Jul 31, 2020
@jakubgs jakubgs deleted the allow-higher-xcode branch July 31, 2020 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants