Add UI for referrals flow #11032
Add UI for referrals flow #11032
Conversation
Jenkins BuildsClick to see older builds (43)
|
Ferossgp
force-pushed
the
feature/referrals-ui
branch
2 times, most recently
from
e03f3d6
to
af5935b
Compare
Ferossgp
force-pushed
the
feature/referrals-ui
branch
2 times, most recently
from
e11e7bc
to
6e1fe0d
Compare
|
Check ahead of release 1.6 which is to include advertiser flow for referral program only (based on new contract) plus only high-prio fixes that would otherwise go into a Does this PR include any dependencies on |
Ferossgp
force-pushed
the
feature/referrals-ui
branch
from
3f2672d
to
8a1bb74
Compare
There was a problem hiding this comment.
As far as I can assess and reviewing Sergey's test findings, this PR includes everything required for release 1.6 (Advertiser referrals flow only), hiding 1:1 friend invite flow UI (Referrer and Recipient) behind a feature flag). Note that the advertiser flow does not rely on contract interactions.
|
@Ferossgp is this still wip? or can be reviewed ? |
| @@ -93,3 +100,8 @@ | |||
| {} | |||
| [_] | |||
| {::check-referrer nil}) | |||
|
|
|||
| (re-frame/reg-sub | |||
There was a problem hiding this comment.
we still don't have decision regarding subs.cljs . so better to move it there, and use reg-root-subs
| (handle-error error) | ||
| (re-frame/dispatch [::on-error (:error error)]))))}}) | ||
| (re-frame/reg-sub | ||
| ::network-status |
|
@flexsurfer it can be reviewed, it is WIP in the plan that it points to the old mainnet contract and I will need to rebase on #11055 for the new one |
Ferossgp
force-pushed
the
feature/referrals-ui
branch
from
6f72630
to
c4b7379
Compare
Ferossgp
force-pushed
the
feature/referrals-ui
branch
from
d24bf2a
to
bed0a06
Compare
In the Invite friends view there are empty values and no icons (no issue on Rinkeby, - everything is present there):
|
|
Looks good to me! |
|
Note: Invite Friends is showing now the 'Referral bonus' view on Mainnet and Rinkeby. I suppose it's because of no "Disable 1-1 invite" flag is set. |
Believe this is because the feature flag is set for |
|
Yes, it is hidden only for release, as in 1.5 |
|
Then, let's merge, @Ferossgp ! |
Cleanup http events Add loaders Add dapp flow Fix tests Fix dapp success event Hide reward based on referrals metadata New flows Terms link TX watcher event Do not show success popup Use new rewardable field from backend Fix referral pulling Update copy Translate advertiser modal Move modal styles into style ns Signed-off-by: Gheorghe Pinzaru <feross95@gmail.com>
Ferossgp
force-pushed
the
feature/referrals-ui
branch
from
17e229d
to
f17b401
Compare
Depends on #11055