-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GitHub releases #11036
Merged
Merged
Fix GitHub releases #11036
+13
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins Builds
|
I ran a manual release build for this branch to test the GitHub artifact upload: |
jakubgs
force-pushed
the
fix-github-releases
branch
from
August 5, 2020 15:15
377d136
to
af9f973
Compare
flexsurfer
approved these changes
Aug 5, 2020
jakubgs
force-pushed
the
fix-github-releases
branch
2 times, most recently
from
August 6, 2020 10:07
1446494
to
6d5ddec
Compare
Signed-off-by: Jakub Sokołowski <jakub@status.im>
Specifically filenames and the diff link. Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
force-pushed
the
fix-github-releases
branch
from
August 6, 2020 12:28
6d5ddec
to
7a80eca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had some issues with how artifacts were named after publishing a release to GitHub, this fixes it.
Specifically this part was causing the filenames to contain a
pkgs.
prefix.Related: https://github.com/status-im/status-react-jenkins/pull/13
I also snuck in a simplified build of
gomobile
.