[#11469] Browser bookmarks #11533
Merged
[#11469] Browser bookmarks #11533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (21)
|
96% of end-end tests have passedFailed tests (4)Click to expand
Passed tests (87)Click to expand
|
25% of end-end tests have passedFailed tests (3)Click to expand
Passed tests (1) |
Ferossgp
approved these changes
Dec 10, 2020
| :icon (if fav? :main-icons/delete :main-icons/favourite) | ||
| :on-press #(hide-sheet-and-dispatch (if fav? | ||
| [:browser/delete-bookmark url] | ||
| [:navigate-to :new-bookmark {:url url}]))}] |
There was a problem hiding this comment.
Looks like here the name is missing, which should autofill the default value in input on the new-bookmark screen?
There was a problem hiding this comment.
if there is no name , it means its a new bookmark
There was a problem hiding this comment.
Yes, I mean that in other browsers the default name uses the site title, while in our case it is empty
ISSUE 1: Error "v must satisfy IVector" if open some website or dapp and quickly tap on the back button several timesScenario 1:
Scenario 2:
Android, iOS
|
|
thanks @qoqobolo fixed |
ISSUE 2: No Сancel or cross button for the URL input fieldCurrently there is no way to delete the entered URL and close a website with one button. Need to remove it manually or tap back button or close all tabs (Tabs view). Case 1: Case 2 (iOS has cross button here): |
|
thanks ISSUE 2 |
87% of end-end tests have passedFailed tests (22)Click to expand
Passed tests (152)Click to expand
|
|
list of improvements |
• browser screen doesn't have transition because of #10189
• agree its weird, but it will require to store empty tabs :( and manage them, so i decided to move it as a separate feature, if we really want it |
is it? then the designer is wrong :) there should be a clear input icon. The 'Cancel' button is likewise necessary to dismiss the input, it's not only for search. otherwise I can't dismiss the input once I open it.
|
|
thanks @errorists , @qoqobolo ready for review |
|
@flexsurfer can I ask you to add accessibility ids to following items if possible? |
57% of end-end tests have passedFailed tests (10)Click to expand
Passed tests (13)Click to expand
|
ISSUE 3: Crash when trying to edit favorite bookmark, if it was added to favorites with default nameSteps:
Android, iOS
|
|
@flexsurfer great work, thanks! |
flexsurfer
force-pushed
the
feature/browser-bookmarks
branch
from
03f0762
to
23fdf91
Compare
Signed-off-by: andrey <motor4ik@gmail.com>
flexsurfer
force-pushed
the
feature/browser-bookmarks
branch
from
23fdf91
to
3241d32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11469
this PR doesn't include:
issue #11538