Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Wallet Connect 1.0 #13032

Merged
merged 1 commit into from
Mar 20, 2022
Merged

Conversation

briansztamfater
Copy link
Member

@briansztamfater briansztamfater commented Jan 24, 2022

fixes #12870

Summary

This PR integrates Wallet Connect 1.0 in addition to 2.0

Testing notes

Platforms

  • Android
  • iOS
Functional
  • wallet / transactions
  • dapps / app browsing

Steps to test

Steps should be the same as #12701 but with dapps that uses Wallet Connect 1.0

status: ready

@briansztamfater briansztamfater self-assigned this Jan 24, 2022
@briansztamfater briansztamfater marked this pull request as draft January 24, 2022 06:30
@status-im-auto
Copy link
Member

status-im-auto commented Jan 24, 2022

Jenkins Builds

Click to see older builds (54)
Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ 234a028 #1 2022-01-24 06:37:54 ~8 min android-e2e 📦apk 📲
✖️ 234a028 #1 2022-01-24 06:38:20 ~8 min android 📦apk 📲
✖️ 234a028 #1 2022-01-24 06:42:40 ~12 min ios 📦ipa 📲
✖️ 0df9f24 #2 2022-01-28 14:16:16 ~8 min android-e2e 📦apk 📲
✖️ 0df9f24 #2 2022-01-28 14:18:02 ~9 min android 📦apk 📲
✖️ 0df9f24 #2 2022-01-28 14:22:33 ~14 min ios 📦ipa 📲
6f65205 #3 2022-02-01 13:15:41 ~19 sec android-e2e 📄log
6f65205 #3 2022-02-01 13:17:04 ~1 min android 📄log
6f65205 #3 2022-02-01 13:18:18 ~2 min ios 📄log
e38e15f #4 2022-02-01 23:57:43 ~18 sec ios 📄log
e38e15f #4 2022-02-01 23:57:44 ~21 sec android-e2e 📄log
e38e15f #4 2022-02-01 23:57:44 ~21 sec android 📄log
✖️ 9495755 #5 2022-02-02 00:21:49 ~8 min android 📦apk 📲
✖️ 9495755 #5 2022-02-02 00:21:59 ~9 min android-e2e 📦apk 📲
✖️ 9495755 #5 2022-02-02 00:29:23 ~16 min ios 📦ipa 📲
✔️ 3b9dc86 #6 2022-02-02 00:31:20 ~8 min android-e2e 📦apk 📲
✔️ 3b9dc86 #6 2022-02-02 00:31:22 ~8 min android 📦apk 📲
✔️ 3b9dc86 #6 2022-02-02 00:33:06 ~10 min ios 📦ipa 📲
✔️ d56b35a #7 2022-02-08 14:24:44 ~8 min android-e2e 📦apk 📲
✔️ d56b35a #7 2022-02-08 14:24:45 ~8 min android 📦apk 📲
✔️ d56b35a #7 2022-02-08 14:27:08 ~11 min ios 📦ipa 📲
✔️ 143ba97 #8 2022-02-17 14:43:01 ~9 min android 📦apk 📲
✔️ 143ba97 #8 2022-02-17 14:43:58 ~10 min android-e2e 📦apk 📲
✔️ 143ba97 #8 2022-02-17 14:51:23 ~17 min ios 📦ipa 📲
✔️ 4426074 #9 2022-02-17 15:01:48 ~9 min android-e2e 📦apk 📲
✔️ 4426074 #9 2022-02-17 15:01:50 ~9 min android 📦apk 📲
✔️ 4426074 #9 2022-02-17 15:09:49 ~17 min ios 📦ipa 📲
✔️ e738e9c #10 2022-02-21 20:08:46 ~9 min android-e2e 📦apk 📲
✔️ e738e9c #10 2022-02-21 20:08:54 ~9 min android 📦apk 📲
✔️ e738e9c #10 2022-02-21 20:13:25 ~13 min ios 📦ipa 📲
✔️ 3484a81 #11 2022-02-22 15:30:11 ~9 min android-e2e 📦apk 📲
✔️ 3484a81 #11 2022-02-22 15:30:19 ~9 min android 📦apk 📲
✔️ 3484a81 #11 2022-02-22 15:36:59 ~15 min ios 📦ipa 📲
✔️ 6bb6658 #12 2022-02-22 16:12:06 ~8 min android-e2e 📦apk 📲
✔️ 6bb6658 #12 2022-02-22 16:12:13 ~8 min android 📦apk 📲
✔️ 6bb6658 #12 2022-02-22 16:14:55 ~11 min ios 📦ipa 📲
✔️ e2fcbb6 #13 2022-02-24 04:34:08 ~9 min android 📦apk 📲
✔️ e2fcbb6 #13 2022-02-24 04:34:17 ~9 min android-e2e 📦apk 📲
✔️ e2fcbb6 #13 2022-02-24 04:43:10 ~18 min ios 📦ipa 📲
✔️ ed1837a #14 2022-02-24 15:55:35 ~8 min android-e2e 📦apk 📲
✔️ ed1837a #14 2022-02-24 15:55:46 ~8 min android 📦apk 📲
✔️ ed1837a #14 2022-02-24 16:01:01 ~13 min ios 📦ipa 📲
✔️ 9cf7138 #15 2022-02-24 16:04:45 ~10 min android-e2e 📦apk 📲
✔️ 9cf7138 #15 2022-02-24 16:04:46 ~10 min android 📦apk 📲
✔️ 9cf7138 #15 2022-02-24 16:09:38 ~15 min ios 📦ipa 📲
✔️ 2871e48 #16 2022-03-02 12:42:28 ~7 min android-e2e 📦apk 📲
✔️ 2871e48 #16 2022-03-02 12:43:17 ~8 min android 📦apk 📲
✔️ 2871e48 #16 2022-03-02 12:48:40 ~13 min ios 📦ipa 📲
✔️ d2b7665 #17 2022-03-02 12:59:21 ~7 min android 📦apk 📲
✔️ d2b7665 #17 2022-03-02 12:59:34 ~7 min android-e2e 📦apk 📲
✔️ d2b7665 #17 2022-03-02 13:03:18 ~11 min ios 📦ipa 📲
✔️ 7fb2a31 #18 2022-03-02 14:15:46 ~7 min android-e2e 📦apk 📲
✔️ 7fb2a31 #18 2022-03-02 14:15:53 ~7 min android 📦apk 📲
✔️ 7fb2a31 #18 2022-03-02 14:20:03 ~11 min ios 📦ipa 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
afb4f58 #19 2022-03-03 16:43:16 ~3 min ios 📄log
✔️ afb4f58 #19 2022-03-03 16:47:06 ~7 min android-e2e 📦apk 📲
✔️ afb4f58 #19 2022-03-03 16:47:23 ~7 min android 📦apk 📲
✔️ afb4f58 #20 2022-03-03 17:05:12 ~12 min ios 📦ipa 📲
afb4f58 #21 2022-03-17 06:50:06 ~21 sec ios 📄log
afb4f58 #20 2022-03-17 06:51:20 ~1 min android-e2e 📄log
afb4f58 #20 2022-03-17 06:51:36 ~1 min android 📄log
✔️ 466d441 #21 2022-03-20 20:06:26 ~9 min android 📦apk 📲
✔️ 466d441 #21 2022-03-20 20:06:32 ~9 min android-e2e 📦apk 📲
✔️ 466d441 #22 2022-03-20 20:11:16 ~13 min ios 📦ipa 📲

@briansztamfater briansztamfater force-pushed the feat/wallet-connect-2.0 branch from 94a8bf7 to 38b8891 Compare February 1, 2022 13:15
@briansztamfater briansztamfater force-pushed the feat/wallet-connect-1.0 branch from e38e15f to 9495755 Compare February 2, 2022 00:12
@briansztamfater briansztamfater changed the title [WIP] Implement Wallet Connect 1.0 Implement Wallet Connect 1.0 Feb 2, 2022
@caffeinum
Copy link

amazing! is there a testflight link?

@churik
Copy link
Member

churik commented Feb 8, 2022

@briansztamfater it is still WIP and not ready for review?

@briansztamfater briansztamfater force-pushed the feat/wallet-connect-2.0 branch from da5f397 to 24f0ab3 Compare February 8, 2022 14:02
@briansztamfater briansztamfater force-pushed the feat/wallet-connect-1.0 branch from 3b9dc86 to d56b35a Compare February 8, 2022 14:15
@briansztamfater briansztamfater marked this pull request as ready for review February 8, 2022 14:20
@briansztamfater
Copy link
Member Author

@briansztamfater it is still WIP and not ready for review?

It is ready for review, just updated the PR description and status. However, it points to feat/wallet-connect-2.0 branch at the moment because it deeply depends on it, so I'd wait until 2.0 is merged before starting testing this one. Code review can be done though.

Thanks!!

@briansztamfater briansztamfater linked an issue Feb 8, 2022 that may be closed by this pull request
Copy link
Contributor

@Jonathansoufer Jonathansoufer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. Herculean work since it's a delicate topic. Awesome job!

@status-im-auto
Copy link
Member

96% of end-end tests have passed

Total executed tests: 83
Failed tests: 3
Passed tests: 80
IDs of failed tests: 5675,5346,6228 

Failed tests (3)

Click to expand
  • Rerun tests

  • 1. test_public_fetch_more_history, id: 5675

    ## Public chat 'hzrjauv' is created successfully!
    # STEP: Check that can fetch previous history for several days

    Device 1: "Feb 7, 2022" is not shown

    Device sessions

    2. test_collectible_from_wallet, id: 5346

    Device 1: Find 'Text' by 'xpath': `//*[@text='CryptoKitties']//following-sibling::android.widget.TextView`
    Device 1: Tap on found: Text

    Device 1: Kitty is not shown after opening it from collectibles!

    Device sessions

    3. test_mobile_data_usage_complex_settings, id: 6228

    Device 1: Find 'Button' by 'xpath': `//*[@text="Use mobile data"]/following-sibling::android.widget.Switch[1]`
    Device 1: Find 'Button' by 'xpath': `//*[@text="Ask me when on mobile network"]/following-sibling::android.widget.Switch[1]`

    Not connected to history node after enabling fetching on mobile data Chat history was not fetched with mobile data fetching ON

    Device sessions

    Passed tests (80)

    Click to expand

    1. test_can_add_existing_ens_on_mainnet, id: 5502
    Device sessions

    2. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244
    Device sessions

    3. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
    Device sessions

    4. test_keycard_can_recover_keycard_account_card_pairing, id: 5758
    Device sessions

    5. test_public_mark_all_messages_as_read, id: 6270
    Device sessions

    6. test_restore_account_from_mnemonic_to_keycard, id: 6240
    Device sessions

    7. test_add_account_to_wallet_private_key_and_seed_phrase, id: 6272
    Device sessions

    8. test_can_use_purchased_stickers_on_recovered_account, id: 5783
    Device sessions

    9. test_group_leave_relogin, id: 3997
    Device sessions

    10. test_keycard_create_login_restore_unlock_same_seed, id: 5689
    Device sessions

    11. test_image_in_one_to_one_send_save_reply_timeline, id: 6305
    Device sessions

    12. test_public_chat_open_using_deep_link, id: 700739
    Device sessions

    13. test_public_delete_chat_long_press, id: 5319
    Device sessions

    14. test_send_token_with_7_decimals, id: 5350
    Device sessions

    15. test_send_eth_to_ens_in_chat, id: 6279
    Device sessions

    16. test_public_tag_message, id: 700738
    Device sessions

    17. test_reactions_to_message_in_chats, id: 6315
    Device sessions

    18. test_send_eth_in_1_1_chat_transaction_push, id: 6253
    Device sessions

    19. test_open_transaction_on_etherscan_copy_tx_hash, id: 5384
    Device sessions

    20. test_send_eth_from_wallet_to_address_incorrect_password, id: 5308
    Device sessions

    21. test_recover_set_up_wallet_sign_phrase, id: 700749
    Device sessions

    22. test_keycard_send_eth_from_wallet_to_address, id: 6289
    Device sessions

    23. test_public_message_edit, id: 700734
    Device sessions

    24. test_open_blocked_secure_not_secure_inlalid_offline_urls, id: 6210
    Device sessions

    25. test_keycard_sign_message_and_transactions_from_daap, id: 6251
    Device sessions

    26. test_public_link_send_open, id: 700736
    Device sessions

    27. test_onboarding_add_new_multiaccount_username_by_position_pass_validation, id: 700747
    Device sessions

    28. test_onboarding_home_initial_popup, id: 700742
    Device sessions

    29. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
    Device sessions

    30. test_restore_account_migrate_multiaccount_to_keycard, id: 6645
    Device sessions

    31. test_edit_delete_message_in_one_to_one_, id: 695843
    Device sessions

    32. test_public_links_with_previews_github_youtube_twitter_gif_send_enable, id: 700737
    Device sessions

    33. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310
    Device sessions

    34. test_send_and_open_emoji_link_in_one_to_one, id: 5373
    Device sessions

    35. test_block_user_from_public_chat, id: 5786
    Device sessions

    36. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
    Device sessions

    37. test_install_pack_and_send_sticker, id: 5782
    Device sessions

    38. test_keycard_request_stt_from_daap, id: 6249
    Device sessions

    39. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
    Device sessions

    40. test_browser_managing_bookmarks, id: 6633
    Device sessions

    41. test_group_add_new_member_activity_centre, id: 700732
    Device sessions

    42. test_onboarding_share_contact_address, id: 700743
    Device sessions

    43. test_onboarding_backup_seed_phrase_restore_same_login_logcat, id: 700745
    Device sessions

    44. test_send_transaction_with_custom_token, id: 6208
    Device sessions

    45. test_user_can_see_collectibles_on_rinkeby_after_account_recovering, id: 5381
    Device sessions

    46. test_can_see_balance_and_all_transactions_history_on_cellular, id: 5314
    Device sessions

    47. test_recover_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 700748
    Device sessions

    48. test_send_audio_message_with_push_notification_check, id: 6316
    Device sessions

    49. test_add_account_to_multiaccount_instance_generate_new, id: 6224
    Device sessions

    50. test_onboarding_cant_sign_in_with_invalid_password_logcat, id: 700746
    Device sessions

    51. test_request_stt_from_dapp, id: 5309
    Device sessions

    52. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
    Device sessions

    53. test_insufficient_funds_wallet_positive_balance, id: 5412
    Device sessions

    54. test_fetching_balance_after_offline, id: 6237
    Device sessions

    55. test_set_profile_picture, id: 6646
    Device sessions

    56. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263
    Device sessions

    57. test_delete_close_all_tabs, id: 5390
    Device sessions

    58. test_public_unread_messages_counter_for_mentions_relogin, id: 700718
    Device sessions

    59. test_onboarding_share_wallet_address, id: 700744
    Device sessions

    60. test_group_offline_pn, id: 3998
    Device sessions

    61. test_public_navigate_to_chat_when_relaunch, id: 5396
    Device sessions

    62. test_recover_validation_seed_phrase_field, id: 700750
    Device sessions

    63. test_delete_chats_via_delete_button_rejoin, id: 5387
    Device sessions

    64. test_dapps_permissions, id: 5738
    Device sessions

    65. test_group_pn_system_messages_when_invited, id: 3994
    Device sessions

    66. test_group_decline_invite_chat_highligted, id: 5756
    Device sessions

    67. test_public_message_send_check_timestamps_while_on_different_tab, id: 5313
    Device sessions

    68. test_manage_assets, id: 5341
    Device sessions

    69. test_send_transaction_set_recipient_options, id: 6328
    Device sessions

    70. test_public_unread_messages_counter, id: 5360
    Device sessions

    71. test_keycard_send_eth_in_1_1_chat, id: 6293
    Device sessions

    72. test_public_emoji_send_copy_paste_reply, id: 700719
    Device sessions

    73. test_public_message_delete, id: 700735
    Device sessions

    74. test_copy_and_paste_messages, id: 5317
    Device sessions

    75. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
    Device sessions

    76. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265
    Device sessions

    77. test_start_chat_with_ens_mention_in_one_to_one, id: 5403
    Device sessions

    78. test_group_join_send_text_messages_pn, id: 700731
    Device sessions

    79. test_keycard_can_see_all_transactions_in_history, id: 6291
    Device sessions

    80. test_sign_message_and_2tx_in_batch_and_transactions_filters_from_daap, id: 5342
    Device sessions

    @status-im-auto
    Copy link
    Member

    79% of end-end tests have passed

    Total executed tests: 73
    Failed tests: 15
    Passed tests: 58
    
    IDs of failed tests: 700768,6279,6253,700734,6645,700769,6263,5756,700767,5313,5360,6293,700719,6265,5342 
    

    Failed tests (15)

    Click to expand
  • Rerun tests

  • 1. test_keycard_relogin_after_restore, id: 700768

    Device 1: Button element not found
    Device 1: Find 'Text' by 'accessibility id': `default-username`

    Device 1: Text by accessibility id: `default-username` is not found on the screen

    Device sessions

    2. test_send_eth_to_ens_in_chat, id: 6279

    Device 1: Tap on found: Button
    Device 1: Find 'Button' by 'xpath': `//*[@text="Okay, got it"]`

    Device 1: Button by xpath: `//*[@text="Okay, got it"]` is not found on the screen

    Device sessions

    3. test_send_eth_in_1_1_chat_transaction_push, id: 6253

    Device 1: Find 'Button' by 'accessibility id': `send-transaction-bottom-sheet`
    Device 1: Tap on found: Button

    Device 1: No message is shown after sending ETH in 1-1 chat for sender

    Device sessions

    4. test_public_message_edit, id: 700734

    Device 1: Find 'SendMessageButton' by 'accessibility id': `send-message-button`
    Device 1: Tap on found: SendMessageButton

    No mark in message bubble about this message was edited Message is not edited

    Device sessions

    5. test_restore_account_migrate_multiaccount_to_keycard, id: 6645

    Device 1: SilentButton element not found
    Device 1: Enter default pin 111111

    Device 1: 'SilentButton' by accessibility id:'numpad-button-1' not found on the screen

    Device sessions

    6. test_keycard_send_tx_sign_message_request_stt_testdapp, id: 700769

    Device 1: Double tap on: HomeButton
    Device 1: Find 'HomeButton' by 'xpath': `//*[contains(@content-desc,'tab, 1 out of 5')]`

    Device 1: HomeButton by xpath: `//*[contains(@content-desc,'tab, 1 out of 5')]` is not found on the screen

    Device sessions

    7. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263

    Device 2: EditBox element not found
    Device 2: Find 'EditBox' by 'accessibility id': `enter-password-input`

    Device 2: EditBox by accessibility id: `enter-password-input` is not found on the screen

    Device sessions

    8. test_group_decline_invite_chat_highligted, id: 5756

    Device 2: Tap on found: Button
    Device 1: Looking for a message by text: Loving Humongous Finch left the group

    ERROR The test with session id f858be9390334603853106407c74648a has already finished, and can't receive further commands. You can learn more at https://app.saucelabs.com/tests/f858be9390334603853106407c74648a For help, please check https://docs.s

    Device sessions

    9. test_keycard_send_tx_eth, id: 700767

    Device 1: SilentButton element not found
    Device 1: Enter default pin 111111

    Device 1: 'SilentButton' by accessibility id:'numpad-button-1' not found on the screen

    Device sessions

    10. test_public_message_send_check_timestamps_while_on_different_tab, id: 5313

    Device 1: Find 'Text' by 'xpath': `//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='sent']`
    Device 1: Find 'Text' by 'xpath': `//*[@content-desc='message-timestamp']`

    Device 1: Text by xpath: `//*[@content-desc='message-timestamp']` is not found on the screen

    Device sessions

    11. test_public_unread_messages_counter, id: 5360

    Device 1: Find 'BackButton' by 'accessibility id': `Navigate Up`
    Device 2: Sending message 'test message'

    Device 2: EditBox by accessibility id: `chat-message-input` is not found on the screen

    Device sessions

    12. test_keycard_send_eth_in_1_1_chat, id: 6293

    Device 1: Find 'Button' by 'accessibility id': `send-transaction-bottom-sheet`
    Device 1: Tap on found: Button

    Device 1: No message is shown after sending ETH in 1-1 chat for sender

    Device sessions

    13. test_public_emoji_send_copy_paste_reply, id: 700719

    Device 2: Quoting '🤾🏽' message
    Device 2: Find 'Button' by 'xpath': `//*[contains(@text, "🤾🏽")]`

    Device 2: Button by xpath: `//*[contains(@text, "🤾🏽")]` is not found on the screen

    Device sessions

    14. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265

    Device 2: Find 'HomeButton' by 'xpath': `//*[contains(@content-desc,'tab, 1 out of 5')]`
    Device 2: Click until 'EditBox' by 'accessibility id': `chat-message-input` will be presented

    Device 2: DeclineTransaction by xpath: `//*[starts-with(@text,'↓ Incoming transaction')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@text="Decline"]` is not found on the screen

    Device sessions

    15. test_sign_message_and_2tx_in_batch_and_transactions_filters_from_daap, id: 5342

    Device 1: EditBox element not found
    Device 1: Find 'EditBox' by 'accessibility id': `enter-password-input`

    Device 1: EditBox by accessibility id: `enter-password-input` is not found on the screen

    Device sessions

    Passed tests (58)

    Click to expand

    1. test_can_add_existing_ens_on_mainnet, id: 5502
    Device sessions

    2. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
    Device sessions

    3. test_wallet_manage_assets, id: 700758
    Device sessions

    4. test_public_mark_all_messages_as_read, id: 6270
    Device sessions

    5. test_can_use_purchased_stickers_on_recovered_account, id: 5783
    Device sessions

    6. test_group_leave_relogin, id: 3997
    7. test_keycard_create_login_restore_unlock_same_seed, id: 5689
    Device sessions

    8. test_image_in_one_to_one_send_save_reply_timeline, id: 6305
    Device sessions

    9. test_public_chat_open_using_deep_link, id: 700739
    Device sessions

    10. test_public_delete_chat_long_press, id: 5319
    Device sessions

    11. test_public_tag_message, id: 700738
    Device sessions

    12. test_reactions_to_message_in_chats, id: 6315
    Device sessions

    13. test_recover_set_up_wallet_sign_phrase, id: 700749
    Device sessions

    14. test_open_blocked_secure_not_secure_inlalid_offline_urls, id: 6210
    Device sessions

    15. test_public_link_send_open, id: 700736
    Device sessions

    16. test_onboarding_add_new_multiaccount_username_by_position_pass_validation, id: 700747
    Device sessions

    17. test_onboarding_home_initial_popup, id: 700742
    Device sessions

    18. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
    Device sessions

    19. test_edit_delete_message_in_one_to_one_, id: 695843
    Device sessions

    20. test_public_links_with_previews_github_youtube_twitter_gif_send_enable, id: 700737
    Device sessions

    21. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310
    Device sessions

    22. test_send_and_open_emoji_link_in_one_to_one, id: 5373
    Device sessions

    23. test_wallet_add_hide_unhide_account_private_key, id: 700761
    Device sessions

    24. test_block_user_from_public_chat, id: 5786
    Device sessions

    25. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
    Device sessions

    26. test_install_pack_and_send_sticker, id: 5782
    Device sessions

    27. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
    Device sessions

    28. test_browser_managing_bookmarks, id: 6633
    Device sessions

    29. test_group_add_new_member_activity_centre, id: 700732
    Device sessions

    30. test_public_fetch_more_history, id: 5675
    Device sessions

    31. test_onboarding_share_contact_address, id: 700743
    Device sessions

    32. test_onboarding_backup_seed_phrase_restore_same_login_logcat, id: 700745
    Device sessions

    33. test_wallet_tx_history_copy_tx_hash_on_lte, id: 700756
    Device sessions

    34. test_recover_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 700748
    Device sessions

    35. test_send_audio_message_with_push_notification_check, id: 6316
    Device sessions

    36. test_onboarding_cant_sign_in_with_invalid_password_logcat, id: 700746
    Device sessions

    37. test_request_stt_from_dapp, id: 5309
    Device sessions

    38. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
    Device sessions

    39. test_wallet_add_delete_watch_only_account, id: 700760
    Device sessions

    40. test_set_profile_picture, id: 6646
    Device sessions

    41. test_delete_close_all_tabs, id: 5390
    Device sessions

    42. test_public_unread_messages_counter_for_mentions_relogin, id: 700718
    Device sessions

    43. test_onboarding_share_wallet_address, id: 700744
    Device sessions

    44. test_mobile_data_usage_complex_settings, id: 6228
    Device sessions

    45. test_group_offline_pn, id: 3998
    Device sessions

    46. test_public_navigate_to_chat_when_relaunch, id: 5396
    Device sessions

    47. test_recover_validation_seed_phrase_field, id: 700750
    Device sessions

    48. test_delete_chats_via_delete_button_rejoin, id: 5387
    Device sessions

    49. test_wallet_fetching_balance_after_offline_insufficient_funds_errors, id: 700766
    Device sessions

    50. test_dapps_permissions, id: 5738
    Device sessions

    51. test_group_pn_system_messages_when_invited, id: 3994
    Device sessions

    52. test_wallet_add_account_generate_new, id: 700759
    Device sessions

    53. test_public_message_delete, id: 700735
    Device sessions

    54. test_copy_and_paste_messages, id: 5317
    Device sessions

    55. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
    Device sessions

    56. test_start_chat_with_ens_mention_in_one_to_one, id: 5403
    Device sessions

    57. test_keycard_wallet_recover_pairing_check_balance_after_offline_tx_history, id: 700770
    Device sessions

    58. test_group_join_send_text_messages_pn, id: 700731
    Device sessions

    @rasom
    Copy link
    Contributor

    rasom commented Mar 2, 2022

    @briansztamfater @qoqobolo I'm fine with merging it if we are in a hurry, but there are still a few issues in the code which should be fixed. It might happen separately from PR if necessary.

    @briansztamfater briansztamfater force-pushed the feat/wallet-connect-2.0 branch from c0f5c57 to 1046cae Compare March 2, 2022 12:44
    @briansztamfater briansztamfater force-pushed the feat/wallet-connect-1.0 branch from 2871e48 to d2b7665 Compare March 2, 2022 12:51
    @briansztamfater
    Copy link
    Member Author

    @rasom pending comments now fixed

    @rasom
    Copy link
    Contributor

    rasom commented Mar 2, 2022

    @briansztamfater thank you

    @briansztamfater
    Copy link
    Member Author

    @qoqobolo can you please make a final testing round to recheck I didn't break anything while fixing comments? :D

    @status-im-auto
    Copy link
    Member

    81% of end-end tests have passed

    Total executed tests: 155
    Failed tests: 30
    Passed tests: 125
    
    IDs of failed tests: 5784,6330,700768,6305,6279,6253,700702,6645,5310,6294,700769,5675,6342,6295,5395,6257,6263,6311,6326,700767,695842,6293,5317,695845,6310,6265,695855,6636,5456,5342 
    

    Failed tests (30)

    Click to expand
  • Rerun tests

  • 1. test_sign_typed_message_deploy_simple_contract_request_pub_key_from_dapp, id: 5784

    Device 1: EditBox element not found
    Device 1: Find 'EditBox' by 'accessibility id': `enter-password-input`

    Device 1: EditBox by accessibility id: `enter-password-input` is not found on the screen

    Device sessions

    2. test_can_send_all_tokens_via_max_option, id: 6330

    Device 1: EditBox element not found
    Device 1: Find 'EditBox' by 'accessibility id': `enter-password-input`

    Device 1: EditBox by accessibility id: `enter-password-input` is not found on the screen

    Device sessions

    3. test_keycard_relogin_after_restore, id: 700768

    Device 1: Button element not found
    Device 1: Find 'Text' by 'accessibility id': `default-username`

    Device 1: Text by accessibility id: `default-username` is not found on the screen

    Device sessions

    4. test_image_in_one_to_one_send_save_reply_timeline, id: 6305

    Device 2: Find 'AllowButton' by 'xpath': `//*[@text="Allow" or @text="ALLOW"]`
    Device 2: Find 'Button' by 'xpath': `//*[@content-desc='open-gallery']/following-sibling::android.view.ViewGroup[1]`

    Status of another user not shown when open another user profile

    Device sessions

    5. test_send_eth_to_ens_in_chat, id: 6279

    Device 1: Tap on found: Button
    Device 1: Find 'Button' by 'xpath': `//*[@text="Okay, got it"]`

    Device 1: Button by xpath: `//*[@text="Okay, got it"]` is not found on the screen

    Device sessions

    6. test_send_eth_in_1_1_chat_transaction_push, id: 6253

    Device 1: Find 'Button' by 'accessibility id': `send-transaction-bottom-sheet`
    Device 1: Tap on found: Button

    Device 1: No message is shown after sending ETH in 1-1 chat for sender

    Device sessions

    7. test_backup_of_contacts, id: 700702

    Device 1: Find 'Button' by 'accessibility id': `contacts-button`
    Device 1: Tap on found: Button

    Device 1: Contact was not backed up!

    Device sessions

    8. test_restore_account_migrate_multiaccount_to_keycard, id: 6645

    Device 1: SilentButton element not found
    Device 1: Enter default pin 111111

    Device 1: 'SilentButton' by accessibility id:'numpad-button-1' not found on the screen

    Device sessions

    9. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310

    Device 1: Looking for chat: 'Narrow Bitesized Spiketail'
    Device 1: Wait for element 'Button' for max 60s and click when it is available

    Device 1: Button by accessibility id:`notifications-unread-badge` is not found on the screen

    Device sessions

    10. test_keycard_request_and_receive_stt_in_1_1_chat_offline_opened_from_push, id: 6294

    Device 2: Tap on found: AirplaneModeButton
    Device 2: Find 'Button' by 'xpath': `//*[@text="Request transaction"]`

    Device 2: Button by xpath: `//*[@text="Request transaction"]` is not found on the screen

    Device sessions

    11. test_keycard_send_tx_sign_message_request_stt_testdapp, id: 700769

    Device 1: Double tap on: HomeButton
    Device 1: Find 'HomeButton' by 'xpath': `//*[contains(@content-desc,'tab, 1 out of 5')]`

    Device 1: HomeButton by xpath: `//*[contains(@content-desc,'tab, 1 out of 5')]` is not found on the screen

    Device sessions

    12. test_public_fetch_more_history, id: 5675

    Device 1: Click until 'Button' by 'xpath': `//*[contains(@text, "Sync history for")]` will be presented
    Device 1: Find 'ProfileButton' by 'xpath': `//*[contains(@content-desc,'5 out of 5')]`

    'Quiet here for 12 days' is not shown after fetching more history

    Device sessions

    13. test_different_status_in_timeline, id: 6342

    Device 2: Tap on found: ViewProfileButton
    Device 2: Looking for a message by text: some text

    Device 2: ChatElementByText by xpath: `//*[starts-with(@text,'some text')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen

    Device sessions

    14. test_keycard_send_eth_to_ens, id: 6295

    Device 1: SilentButton element not found
    Device 1: Enter default pin 111111

    Device 1: 'SilentButton' by accessibility id:'numpad-button-1' not found on the screen

    Device sessions

    15. test_back_forward_refresh_navigation_history_kept_after_relogin, id: 5395

    Device 1: Find 'AllowButton' by 'xpath': `//*[@text="Allow" or @text="ALLOW"]`
    Device 1: Find 'Button' by 'xpath': `//*[@text="Select a token"]`

    Device 1: Button by xpath: `//*[@text="Select a token"]` is not found on the screen

    Device sessions

    16. test_network_mismatch_for_send_request_in_1_1_chat, id: 6257

    Device 1: EditBox element not found
    Device 1: Find 'EditBox' by 'accessibility id': `enter-password-input`

    Device 1: EditBox by accessibility id: `enter-password-input` is not found on the screen

    Device sessions

    17. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263

    Device 2: EditBox element not found
    Device 2: Find 'EditBox' by 'accessibility id': `enter-password-input`

    Device 2: EditBox by accessibility id: `enter-password-input` is not found on the screen

    Device sessions

    18. test_same_seed_added_inside_multiaccount_and_keycard, id: 6311

    Device 1: EditBox element not found
    Device 1: Find 'EditBox' by 'accessibility id': `enter-password-input`

    Device 1: EditBox by accessibility id: `enter-password-input` is not found on the screen

    Device sessions

    19. test_mention_users_not_in_chats_if_not_in_contacts, id: 6326

    ## Group chat new_group_chat is created successfully!
    Device 1: Find 'EditBox' by 'accessibility id': `chat-message-input`

    Device 1: EditBox by accessibility id: `chat-message-input` is not found on the screen

    Device sessions

    20. test_keycard_send_tx_eth, id: 700767

    Device 1: SilentButton element not found
    Device 1: Enter default pin 111111

    Device 1: 'SilentButton' by accessibility id:'numpad-button-1' not found on the screen

    Device sessions

    21. test_creating_community_accept_membership, id: 695842

    Device 2: Wait for 'EditBox'
    ## Public chat 'wzgbogw' is created successfully!

    Device 2: Button by xpath: `//*[@text="some name"]` is not found on the screen

    Device sessions

    22. test_keycard_send_eth_in_1_1_chat, id: 6293

    Device 1: Find 'Button' by 'accessibility id': `send-transaction-bottom-sheet`
    Device 1: Tap on found: Button

    Device 1: No message is shown after sending ETH in 1-1 chat for sender

    Device sessions

    23. test_copy_and_paste_messages, id: 5317

    Device 1: Looking for a message by text: https://status.im
    Device 1: Find 'Text' by 'xpath': `//*[starts-with(@text,'https://status.im')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='sent']`

    Device 1: Text by xpath: `//*[starts-with(@text,'https://status.im')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='sent']` is not found on the screen

    Device sessions

    24. test_notification_in_activity_center_for_mention_in_community_and_group_chat, id: 695845

    Device 1: Find 'BackButton' by 'accessibility id': `Navigate Up`
    # STEP: Tapping on community link and request membership

    Device 2: Button by xpath: `//*[@text="some name"]` is not found on the screen

    Device sessions

    25. test_keycard_sign_typed_message_deploy_simple_contract, id: 6310

    Device 1: SilentButton element not found
    Device 1: Enter default pin 111111

    Device 1: 'SilentButton' by accessibility id:'numpad-button-1' not found on the screen

    Device sessions

    26. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265

    Device 2: Find 'HomeButton' by 'xpath': `//*[contains(@content-desc,'tab, 1 out of 5')]`
    Device 2: Click until 'EditBox' by 'accessibility id': `chat-message-input` will be presented

    Device 2: DeclineTransaction by xpath: `//*[starts-with(@text,'↓ Incoming transaction')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@text="Decline"]` is not found on the screen

    Device sessions

    27. test_custom_gas_settings, id: 695855

    Device 1: Tap on found: Button
    Device 1: Wait for element 'Button' for max 30s and click when it is available

    Device 1: Button by xpath:`//*[@text="Okay, got it"]` is not found on the screen

    Device sessions

    28. test_show_profile_picture_of_setting_online_indicator, id: 6636

    Device 2: Looking for chat: 'Hefty Defenseless Fowl'
    Device 2: Find 'ChatImage' by 'xpath': `//*[@content-desc='chat-icon']`

    Profile picture was not updated on user Profile view

    Device sessions

    29. test_can_access_images_by_link, id: 5456

    Device 1: Find 'Button' by 'accessibility id': `previous-page-button`
    Device 1: EditBox element not found

    Web page does not match expected template url1.png Web page does not match expected template url3.png

    Device sessions

    30. test_sign_message_and_2tx_in_batch_and_transactions_filters_from_daap, id: 5342

    Device 1: EditBox element not found
    Device 1: Find 'EditBox' by 'accessibility id': `enter-password-input`

    Device 1: EditBox by accessibility id: `enter-password-input` is not found on the screen

    Device sessions

    Passed tests (125)

    Click to expand

    1. test_can_add_existing_ens_on_mainnet, id: 5502
    Device sessions

    2. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
    Device sessions

    3. test_wallet_manage_assets, id: 700758
    Device sessions

    4. test_activity_center_group_chats_trusted_contacts, id: 695771
    Device sessions

    5. test_unread_messages_counter_preview_highlited_1_1_chat, id: 5362
    Device sessions

    6. test_keycard_send_funds_between_accounts_set_max_in_multiaccount_instance, id: 6292
    Device sessions

    7. test_can_scan_qr_with_chat_key_from_home_start_chat, id: 6298
    Device sessions

    8. test_resolve_ipns_name, id: 6323
    Device sessions

    9. test_can_pin_messages_in_one_to_one_and_group_chats, id: 695847
    Device sessions

    10. test_keycard_interruption_creating_onboarding_flow, id: 5742
    Device sessions

    11. test_public_mark_all_messages_as_read, id: 6270
    Device sessions

    12. test_can_use_purchased_stickers_on_recovered_account, id: 5783
    Device sessions

    13. test_group_leave_relogin, id: 3997
    Device sessions

    14. test_gap_in_public_chat, id: 700727
    Device sessions

    15. test_keycard_create_login_restore_unlock_same_seed, id: 5689
    Device sessions

    16. test_keycard_interruption_access_key_onboarding_flow, id: 6246
    Device sessions

    17. test_keycard_settings_pin_puk_pairing, id: 695841
    Device sessions

    18. test_public_chat_open_using_deep_link, id: 700739
    Device sessions

    19. test_public_delete_chat_long_press, id: 5319
    Device sessions

    20. test_block_and_unblock_user_from_group_chat_via_group_info, id: 5752
    Device sessions

    21. test_public_tag_message, id: 700738
    Device sessions

    22. test_can_scan_different_links_with_universal_qr_scanner, id: 6322
    Device sessions

    23. test_keycard_can_recover_keycard_account_offline_and_add_watch_only_acc, id: 6243
    Device sessions

    24. test_reactions_to_message_in_chats, id: 6315
    Device sessions

    25. test_add_remove_contact_via_contacts_view, id: 6312
    Device sessions

    26. test_block_user_from_one_to_one_header_check_push_notification_service, id: 5763
    Device sessions

    27. test_privacy_policy_terms_of_use_node_version_need_help_in_profile, id: 5453
    Device sessions

    28. test_public_clear_history_via_options_and_long_press, id: 5426
    Device sessions

    29. test_pair_devices_sync_photo_community_group_chats, id: 695856
    Device sessions

    30. test_recover_set_up_wallet_sign_phrase, id: 700749
    Device sessions

    31. test_can_use_another_fleets_and_networks_advanced_set_nonce, id: 695890
    Device sessions

    32. test_use_pinned_mailserver, id: 5766
    Device sessions

    33. test_public_message_edit, id: 700734
    Device sessions

    34. test_open_blocked_secure_not_secure_inlalid_offline_urls, id: 6210
    Device sessions

    35. test_public_link_send_open, id: 700736
    Device sessions

    36. test_markdown_support_in_messages, id: 5425
    Device sessions

    37. test_remove_member_from_group_chat, id: 4001
    Device sessions

    38. test_onboarding_add_new_multiaccount_username_by_position_pass_validation, id: 700747
    Device sessions

    39. test_deep_link_with_invalid_user_public_key_own_profile_key, id: 5781
    Device sessions

    40. test_validation_amount_errors, id: 5437
    Device sessions

    41. test_onboarding_home_initial_popup, id: 700742
    Device sessions

    42. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
    Device sessions

    43. test_custom_bootnodes, id: 5432
    Device sessions

    44. test_edit_delete_message_in_one_to_one_, id: 695843
    Device sessions

    45. test_public_links_with_previews_github_youtube_twitter_gif_send_enable, id: 700737
    Device sessions

    46. test_open_user_profile_using_deep_link, id: 5441
    Device sessions

    47. test_send_and_open_emoji_link_in_one_to_one, id: 5373
    Device sessions

    48. test_make_admin_member_of_group_chat, id: 5694
    Device sessions

    49. test_backup_recovery_phrase_warning_from_wallet, id: 5358
    Device sessions

    50. test_webview_camera_permission, id: 6635
    Device sessions

    51. test_deny_access_camera_and_gallery, id: 6319
    Device sessions

    52. test_wallet_add_hide_unhide_account_private_key, id: 700761
    Device sessions

    53. test_can_not_connect_to_mailserver, id: 5767
    Device sessions

    54. test_block_user_from_public_chat, id: 5786
    Device sessions

    55. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
    Device sessions

    56. test_install_pack_and_send_sticker, id: 5782
    Device sessions

    57. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
    Device sessions

    58. test_can_scan_eip_681_links, id: 6282
    Device sessions

    59. test_invite_to_group_chat_handling, id: 6324
    Device sessions

    60. test_browser_managing_bookmarks, id: 6633
    Device sessions

    61. test_change_log_level_and_fleet, id: 5368
    Device sessions

    62. test_group_add_new_member_activity_centre, id: 700732
    Device sessions

    63. test_open_user_profile_long_press_on_message, id: 6267
    Device sessions

    64. test_send_funds_between_accounts_in_multiaccount_instance, id: 6225
    Device sessions

    65. test_onboarding_share_contact_address, id: 700743
    Device sessions

    66. test_onboarding_backup_seed_phrase_restore_same_login_logcat, id: 700745
    Device sessions

    67. test_wallet_tx_history_copy_tx_hash_on_lte, id: 700756
    Device sessions

    68. test_disable_use_history_node, id: 6332
    Device sessions

    69. test_reply_to_message_in_chats, id: 6233
    Device sessions

    70. test_open_dapp_using_deep_link, id: 5442
    Device sessions

    71. test_recover_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 700748
    Device sessions

    72. test_invite_friends, id: 5433
    Device sessions

    73. test_add_switch_delete_custom_mailserver, id: 5436
    Device sessions

    74. test_send_audio_message_with_push_notification_check, id: 6316
    Device sessions

    75. test_onboarding_cant_sign_in_with_invalid_password_logcat, id: 700746
    Device sessions

    76. test_rename_group_chat, id: 6280
    Device sessions

    77. test_can_reset_password, id: 695850
    Device sessions

    78. test_request_stt_from_dapp, id: 5309
    Device sessions

    79. test_can_delete_several_multiaccounts, id: 6318
    Device sessions

    80. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
    Device sessions

    81. test_add_custom_network, id: 5431
    Device sessions

    82. test_switching_accounts_in_dapp, id: 6232
    Device sessions

    83. test_wallet_add_delete_watch_only_account, id: 700760
    Device sessions

    84. test_set_profile_picture, id: 6646
    Device sessions

    85. test_nicknames_ens_group_chats, id: 6327
    Device sessions

    86. test_delete_close_all_tabs, id: 5390
    Device sessions

    87. test_can_change_account_settings, id: 6235
    Device sessions

    88. test_public_unread_messages_counter_for_mentions_relogin, id: 700718
    Device sessions

    89. test_onboarding_share_wallet_address, id: 700744
    Device sessions

    90. test_mobile_data_usage_complex_settings, id: 6228
    Device sessions

    91. test_push_notifications_reactions_for_messages_in_stickers_audio_image, id: 6321
    Device sessions

    92. test_offline_can_login_cant_send_transaction, id: 5407
    Device sessions

    93. test_keycard_blocked_card_lost_or_frozen_flows, id: 695852
    Device sessions

    94. test_group_offline_pn, id: 3998
    Device sessions

    95. test_open_url_with_non_english_text_connect_revoke_wallet_new_tab_open_chat_options, id: 5424
    Device sessions

    96. test_public_navigate_to_chat_when_relaunch, id: 5396
    Device sessions

    97. test_recover_validation_seed_phrase_field, id: 700750
    Device sessions

    98. test_delete_chats_via_delete_button_rejoin, id: 5387
    Device sessions

    99. test_app_on_background_by_back_button, id: 6221
    Device sessions

    100. test_recover_accounts_with_certain_seedphrase, id: 5455
    Device sessions

    101. test_wallet_fetching_balance_after_offline_insufficient_funds_errors, id: 700766
    Device sessions

    102. test_set_currency, id: 5429
    Device sessions

    103. test_can_accept_or_reject_multiple_chats_from_activity_center, id: 695782
    Device sessions

    104. test_dapps_permissions, id: 5738
    Device sessions

    105. test_share_user_profile_url_public_chat, id: 5498
    Device sessions

    106. test_group_pn_system_messages_when_invited, id: 3994
    Device sessions

    107. test_group_decline_invite_chat_highligted, id: 5756
    Device sessions

    108. test_search_chat_on_home, id: 5757
    Device sessions

    109. test_public_message_send_check_timestamps_while_on_different_tab, id: 5313
    Device sessions

    110. test_search_asset_and_currency, id: 6269
    Device sessions

    111. test_public_unread_messages_counter, id: 5360
    Device sessions

    112. test_keycard_frozen_card_flows, id: 695851
    Device sessions

    113. test_cant_add_more_twenty_participants_to_group_chat, id: 5721
    Device sessions

    114. test_wallet_add_account_generate_new, id: 700759
    Device sessions

    115. test_public_emoji_send_copy_paste_reply, id: 700719
    Device sessions

    116. test_public_message_delete, id: 700735
    Device sessions

    117. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
    Device sessions

    118. test_set_primary_ens_custom_domain, id: 6219
    Device sessions

    119. test_pair_devices_group_chat_different_messages_nicknames, id: 6317
    Device sessions

    120. test_unblocked_user_is_not_added_in_contacts, id: 6213
    Device sessions

    121. test_start_chat_with_ens_mention_in_one_to_one, id: 5403
    Device sessions

    122. test_keycard_wallet_recover_pairing_check_balance_after_offline_tx_history, id: 700770
    Device sessions

    123. test_delete_cut_and_paste_messages, id: 5322
    Device sessions

    124. test_group_join_send_text_messages_pn, id: 700731
    Device sessions

    125. test_can_start_chat_from_suggestions_using_search_chat, id: 6320
    Device sessions

    @status-im-auto
    Copy link
    Member

    60% of end-end tests have passed

    Total executed tests: 5
    Failed tests: 2
    Passed tests: 3
    
    IDs of failed tests: 5310,6636 
    

    Failed tests (2)

    Click to expand
  • Rerun tests

  • 1. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310

    Device 1: Looking for chat: 'Magnificent Dreary Foal'
    Device 1: Wait for element 'Button' for max 60s and click when it is available

    Device 1: Button by accessibility id:`notifications-unread-badge` is not found on the screen

    Device sessions

    2. test_show_profile_picture_of_setting_online_indicator, id: 6636

    Device 2: Find 'Button' by 'xpath': `//*[@text="Unselfish Free Woodnymphbutterfly"]`
    Device 2: Tap on found: Button

    Device 2: Button by accessibility id:`online-profile-photo-dot` is not found on the screen

    Device sessions

    Passed tests (3)

    Click to expand

    1. test_mention_users_not_in_chats_if_not_in_contacts, id: 6326
    Device sessions

    2. test_copy_and_paste_messages, id: 5317
    Device sessions

    3. test_can_access_images_by_link, id: 5456
    Device sessions

    @qoqobolo
    Copy link
    Contributor

    qoqobolo commented Mar 3, 2022

    Thanks @briansztamfater! Still looks good! :)
    Please, take a look at the conflicting files, and let's merge!

    @briansztamfater briansztamfater force-pushed the feat/wallet-connect-1.0 branch from 7fb2a31 to afb4f58 Compare March 3, 2022 16:39
    @briansztamfater briansztamfater force-pushed the feat/wallet-connect-2.0 branch 2 times, most recently from 36d0fa9 to 9915d07 Compare March 14, 2022 20:13
    @briansztamfater briansztamfater force-pushed the feat/wallet-connect-2.0 branch from a20605e to bd7da02 Compare March 17, 2022 06:47
    Base automatically changed from feat/wallet-connect-2.0 to develop March 17, 2022 06:49
    @briansztamfater briansztamfater force-pushed the feat/wallet-connect-1.0 branch from afb4f58 to 466d441 Compare March 20, 2022 19:57
    Signed-off-by: Brian Sztamfater <brian@status.im>
    @briansztamfater briansztamfater force-pushed the feat/wallet-connect-1.0 branch from 466d441 to a7b0764 Compare March 20, 2022 23:40
    @briansztamfater briansztamfater merged commit a7b0764 into develop Mar 20, 2022
    @briansztamfater briansztamfater deleted the feat/wallet-connect-1.0 branch March 20, 2022 23:40
    @caffeinum
    Copy link

    yay! merged!

    wen AppStore?

    @cammellos
    Copy link
    Contributor

    @caffeinum out already, you will have to enable it in advanced settings, since currently we haven't implemented revoking permissions on mobile (you'd have to do that from desktop), which is coming in the next release.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    No open projects
    Archived in project
    Development

    Successfully merging this pull request may close these issues.

    Wallet Connect 1.0 integration
    9 participants