Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quo2, Switcher Navigation #13167

Merged
merged 3 commits into from
May 10, 2022
Merged

Quo2, Switcher Navigation #13167

merged 3 commits into from
May 10, 2022

Conversation

Parveshdhull
Copy link
Member

@Parveshdhull Parveshdhull commented Mar 13, 2022

Summary

PR implements bottom navigation bar and basic navigation for switcher implementation.
Implementation is rough draft to test how switcher can be part of navigation

Optimized for Android only

status: wip

@Parveshdhull Parveshdhull self-assigned this Mar 13, 2022
@status-im-auto
Copy link
Member

status-im-auto commented Mar 13, 2022

Jenkins Builds

Click to see older builds (30)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 7685b2a #1 2022-03-13 22:51:10 ~10 min android-e2e 📦apk 📲
✔️ 7685b2a #1 2022-03-13 22:51:10 ~10 min android 📦apk 📲
✔️ 7685b2a #1 2022-03-13 22:52:21 ~11 min ios 📦ipa 📲
✔️ 534a961 #2 2022-03-13 23:07:48 ~8 min android-e2e 📦apk 📲
✔️ 534a961 #2 2022-03-13 23:07:53 ~8 min android 📦apk 📲
✔️ 534a961 #2 2022-03-13 23:11:27 ~11 min ios 📦ipa 📲
✔️ 69abb56 #3 2022-03-13 23:22:34 ~8 min android-e2e 📦apk 📲
✔️ 69abb56 #3 2022-03-13 23:22:36 ~8 min android 📦apk 📲
✔️ 69abb56 #3 2022-03-13 23:25:25 ~10 min ios 📦ipa 📲
9b7cb23 #4 2022-03-20 21:33:48 ~20 sec android-e2e 📄log
9b7cb23 #4 2022-03-20 21:33:48 ~21 sec android 📄log
9b7cb23 #4 2022-03-20 21:33:49 ~21 sec ios 📄log
f996385 #5 2022-03-20 21:43:48 ~8 min android-e2e 📄log
f996385 #5 2022-03-20 21:44:01 ~8 min android 📄log
f996385 #5 2022-03-20 21:47:53 ~12 min ios 📄log
✔️ 7d456f8 #6 2022-03-20 22:07:58 ~8 min android-e2e 📦apk 📲
✔️ 7d456f8 #6 2022-03-20 22:08:01 ~8 min android 📦apk 📲
✔️ 7d456f8 #6 2022-03-20 22:12:53 ~13 min ios 📦ipa 📲
✔️ cdeefd5 #7 2022-04-06 12:06:17 ~10 min android 📦apk 📲
✔️ cdeefd5 #7 2022-04-06 12:08:17 ~12 min android-e2e 📦apk 📲
✔️ cdeefd5 #7 2022-04-06 12:08:59 ~12 min ios 📦ipa 📲
✖️ cfffa31 #8 2022-05-09 12:45:47 ~13 min android-e2e 📦apk 📲
✖️ cfffa31 #8 2022-05-09 12:46:46 ~14 min android 📦apk 📲
✖️ cfffa31 #8 2022-05-09 12:49:26 ~16 min ios 📦ipa 📲
✔️ 767f4a0 #9 2022-05-09 12:53:01 ~9 min android 📦apk 📲
✔️ 767f4a0 #9 2022-05-09 12:53:21 ~9 min android-e2e 📦apk 📲
✔️ 767f4a0 #9 2022-05-09 12:59:57 ~16 min ios 📦ipa 📲
✔️ 0af7e13 #10 2022-05-09 20:06:01 ~10 min android 📦apk 📲
✔️ 0af7e13 #10 2022-05-09 20:06:23 ~11 min android-e2e 📦apk 📲
✔️ 0af7e13 #10 2022-05-09 20:13:29 ~18 min ios 📦ipa 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 523cc90 #12 2022-05-09 20:19:46 ~9 min android 📦apk 📲
✔️ 523cc90 #12 2022-05-09 20:23:00 ~12 min android-e2e 📦apk 📲
✔️ 523cc90 #12 2022-05-09 20:27:47 ~17 min ios 📦ipa 📲
✔️ 8bd2860 #11 2022-05-09 20:20:37 ~11 min android-e2e 📦apk 📲
✔️ 8bd2860 #11 2022-05-09 20:20:38 ~11 min android 📦apk 📲

@Parveshdhull Parveshdhull force-pushed the feature/quo2-switcher branch 2 times, most recently from 534a961 to 69abb56 Compare March 13, 2022 23:14
@flexsurfer
Copy link
Member

hey @Parveshdhull great start :) i think that switcher shouldn't be a part of quo2, because its not really a component which can be reused somehow, so I would implement it in status-im/switcher package, and all navigation in status-im/navigation2 instead, wdyt ?

@Parveshdhull
Copy link
Member Author

hey @Parveshdhull great start :) i think that switcher shouldn't be a part of quo2, because its not really a component which can be reused somehow, so I would implement it in status-im/switcher package, and all navigation in status-im/navigation2 instead, wdyt ?

Yes, that sounds better. I will move them 👍 Thank you

@Parveshdhull Parveshdhull force-pushed the feature/quo2-switcher branch 2 times, most recently from 9b7cb23 to f996385 Compare March 20, 2022 21:35
@Parveshdhull Parveshdhull marked this pull request as ready for review May 9, 2022 12:36
@Parveshdhull Parveshdhull changed the title [WIP] - Quo2, Switcher Navigation Quo2, Switcher Navigation May 9, 2022
@Parveshdhull
Copy link
Member Author

PR is still in WIP, I wanted to merge it for now to avoid complex rebase

@Parveshdhull
Copy link
Member Author

Most of the code consists only in Switcher and Navigation2 directory, so that it will not effect current develop

@flexsurfer
Copy link
Member

regarding icons names, im not sure how to it better, i understand we will have two versions of icons, probably instead of -new we could use prefix redesign- so we can easily find these icons they will be sorted by this prefix wdyt ?

src/quo/react_native.cljs Show resolved Hide resolved
src/status_im/switcher/constants.cljs Outdated Show resolved Hide resolved
@churik
Copy link
Member

churik commented May 10, 2022

Please, ping me in case of any possible regression, thanks!

@status-im-auto
Copy link
Member

83% of end-end tests have passed

Total executed tests: 84
Failed tests: 14
Passed tests: 70
IDs of failed tests: 700762,700764,702196,700763,700765,702186,702157,5342,6316,702194,702198,702199,702195,702197 

Failed tests (14)

Click to expand
  • Rerun failed tests

  • 1. test_wallet_add_account_seed_phrase_collectibles_rinkeby_set_as_profile_image, id: 700762

    Device 1: Find `Text` by `xpath`: `//*[@text='Coins & Steel Exclusive Item Skin V2']//following-sibling::android.widget.TextView`
    Device 1: Find `Text` by `xpath`: `//*[@text='Coins & Steel Exclusive Item Skin V2']//following-sibling::android.widget.TextView`

    Device 1: Text by xpath: `//*[@text='Coins & Steel Exclusive Item Skin V2']//following-sibling::android.widget.TextView` is not found on the screen

    Class: TestWalletManagementDeviceMerged

    Device sessions

    2. test_send_tx_token_7_decimals, id: 700764

    Device 1: ADI value is 499.9189599
    Device 1: Waiting 400s for ADI updated balance

    Device 1: Balance ADI 499.9189599 is not changed during 400 seconds!

    Class: TestSendTxDeviceMerged

    Device sessions

    3. test_pairing_sync_contacts_block_unblock, id: 702196
    Test setup failed: Sauce could not start your job. For more information on what happened, please visit https://app.saucelabs.com/tests/4125de3fcb754f5aa783e230d9bbcbb0

    Class: TestPairingSyncMultipleDevicesMerged

    4. test_send_tx_eth_check_logcat, id: 700763

    Transaction #5, amount is 0.0
    {'blockNumber': '12241887', 'timeStamp': '1651828462', 'hash': '0x3ca12e22ce067a168445f64b5163c4cfbb60ffd92acad4eae901b94d95315737', 'nonce': '1363', 'blockHash': '0xc2523b18307105020eb6d429dcf20aa72ceca1dce6c25f8f066558770908a58f', 'transactionIndex': '5', 'from': '0x512543419b894307ea979c8d24219c279be2315b', 'to': '0xe639e24346d646e927f323558e6e0031bfc93581', 'value': '0', 'gas': '41235', 'gasPrice': '27674221360', 'isError': '0', 'txreceipt_status': '1', 'input': '0xa9059cbb000000000000000000000000aa2c8fbfed0e36e793aa51707c4f575d2b7f2dc800000000000000000000000000000000000000000000000000000000000008b7', 'contractAddress': '', 'cumulativeGasUsed': '583451', 'gasUsed': '34363', 'confirmations': '11225'}

    Transaction with amount 0.0006271 is not found in list of ETH transactions, address is 512543419b894307EA979C8d24219c279Be2315B during 300s

    Class: TestSendTxDeviceMerged

    Device sessions

    5. test_send_tx_custom_token_18_decimals_invalid_password, id: 700765

    Device 1: Double tap on: WalletButton
    Device 1: Find `WalletButton` by `xpath`: `//*[contains(@content-desc,'tab, 3 out of 5')]`

    Device 1: WalletButton by xpath: `//*[contains(@content-desc,'tab, 3 out of 5')]` is not found on the screen; also Unexpected Alert is shown: 'replacement transaction underpriced'

    Class: TestSendTxDeviceMerged

    Device sessions

    6. test_keycard_command_send_tx_eth_1_1_chat, id: 702186

    # STEP: Check 'Confirmed' state for sender and receiver(use pull-to-refresh to update history)
    Device 2: Click until `Button` by `accessibility id`: `accounts-more-options` will be presented

    E http.client.RemoteDisconnected: Remote end closed connection without response

    During handling of the above exception, another exception occurred:
    ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response'))


    Class: TestContactBlockMigrateKeycardMultipleSharedDevices

    Device sessions

    7. test_sticker_1_1_public_chat, id: 702157

    Device 2: Find Button by xpath: //*[@content-desc='sticker-pack-name'][@text='Tozemoon']/..//*[@content-desc='sticker-pack-price']
    Device 2: Find Button by xpath: //*[@content-desc='sticker-pack-name'][@text='Tozemoon']/..//*[@content-desc='sticker-pack-price']

    Device 2: Button by xpath: //*[@content-desc='sticker-pack-name'][@text='Tozemoon']/..//*[@content-desc='sticker-pack-price'] is not found on the screen

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    8. test_send_tx_sign_message_2tx_in_batch_tx_filters_request_stt_testdapp, id: 5342

    Device 1: Click until Button by xpath: //*[@text="Sign"] is NOT presented
    Device 1: Find Button by xpath: //*[@text="Sign"]

    Device 1: Transaction failed; also Unexpected Alert is shown: 'replacement transaction underpriced'

    Class: TestSendTxDeviceMerged

    Device sessions

    9. test_1_1_chat_text_message_with_push, id: 6316

    Device 2: Find Text by xpath: //*[@content-desc='play-pause-audio-message-button']/../..//android.widget.TextView[1]
    Device 2: Text is 00:09

    Listened 5 seconds but timer shows different listened time in audio message

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    10. test_pairing_sync_initial_contacts_blocked_users, id: 702194
    Test setup failed:
    Sauce could not start your job. For more information on what happened, please visit https://app.saucelabs.com/tests/4125de3fcb754f5aa783e230d9bbcbb0


    Class: TestPairingSyncMultipleDevicesMerged

    11. test_pairing_sync_1_1_chat_message, id: 702198
    Test setup failed:
    Sauce could not start your job. For more information on what happened, please visit https://app.saucelabs.com/tests/4125de3fcb754f5aa783e230d9bbcbb0


    Class: TestPairingSyncMultipleDevicesMerged

    12. test_pairing_sync_public_chat_add_remove, id: 702199
    Test setup failed:
    Sauce could not start your job. For more information on what happened, please visit https://app.saucelabs.com/tests/4125de3fcb754f5aa783e230d9bbcbb0


    Class: TestPairingSyncMultipleDevicesMerged

    13. test_pairing_sync_initial_public_chats, id: 702195
    Test setup failed:
    Sauce could not start your job. For more information on what happened, please visit https://app.saucelabs.com/tests/4125de3fcb754f5aa783e230d9bbcbb0


    Class: TestPairingSyncMultipleDevicesMerged

    14. test_pairing_sync_contacts_add_remove_set_nickname_ens, id: 702197
    Test setup failed:
    Sauce could not start your job. For more information on what happened, please visit https://app.saucelabs.com/tests/4125de3fcb754f5aa783e230d9bbcbb0


    Class: TestPairingSyncMultipleDevicesMerged

    Passed tests (70)

    Click to expand

    1. test_wallet_manage_assets, id: 700758

    Class: TestWalletManagementDeviceMerged

    Device sessions

    2. test_public_chat_message_edit, id: 700734

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    3. test_contact_block_unblock_public_chat_offline, id: 702176

    Class: TestContactBlockMigrateKeycardMultipleSharedDevices

    Device sessions

    4. test_1_1_chat_text_message_edit_delete_push_disappear, id: 695843

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    5. test_keycard_relogin_after_restore, id: 700768

    Class: TestKeycardTxOneDeviceMerged

    Device sessions

    6. test_group_chat_push_system_messages_when_invited, id: 3994

    Class: TestGroupChatMultipleDeviceMerged

    Device sessions

    7. test_ens_command_send_tx_eth_1_1_chat, id: 702153

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    8. test_contact_add_remove_mention_default_username_nickname_public_chat, id: 702175

    Class: TestContactBlockMigrateKeycardMultipleSharedDevices

    Device sessions

    9. test_public_chat_open_using_deep_link, id: 700739

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    10. test_public_chat_unread_messages_counter, id: 5360

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    11. test_1_1_chat_command_decline_eth_push_changing_state, id: 6265

    Class: TestCommandsMultipleDevicesMerged

    Device sessions

    12. test_public_chat_emoji_send_copy_paste_reply, id: 700719

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    13. test_1_1_chat_command_request_and_send_tx_stt_in_1_1_chat_offline, id: 6263

    Class: TestCommandsMultipleDevicesMerged

    Device sessions

    14. test_browser_bookmarks_create_edit_remove, id: 702077

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    15. test_public_chat_unread_messages_counter_for_mention_relogin, id: 700718

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    16. test_onboarding_add_new_multiaccount_username_by_position_pass_validation, id: 700747

    Class: TestOnboardingOneDeviceMerged

    Device sessions

    17. test_public_chat_delete_chat_long_press, id: 5319

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    18. test_onboarding_home_initial_popup, id: 700742

    Class: TestOnboardingOneDeviceMerged

    Device sessions

    19. test_browser_blocked_url, id: 702072

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    20. test_wallet_add_hide_unhide_account_private_key, id: 700761

    Class: TestWalletManagementDeviceMerged

    Device sessions

    21. test_1_1_chat_message_reaction, id: 6315

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    22. test_ens_mention_push_highlighted_public_chat, id: 702156

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    23. test_keycard_send_tx_sign_message_request_stt_testdapp, id: 700769

    Class: TestKeycardTxOneDeviceMerged

    Device sessions

    24. test_1_1_chat_image_send_save_reply, id: 6305

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    25. test_1_1_chat_emoji_and_link_send_and_open, id: 5373

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    26. test_public_chat_link_send_open, id: 700736

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    27. test_onboarding_share_contact_address, id: 700743

    Class: TestOnboardingOneDeviceMerged

    Device sessions

    28. test_onboarding_backup_seed_phrase_restore_same_login_logcat, id: 700745

    Class: TestOnboardingOneDeviceMerged

    Device sessions

    29. test_restore_set_up_wallet_sign_phrase, id: 700749

    Class: TestRestoreOneDeviceMerged

    Device sessions

    30. test_ens_mention_nickname_1_1_chat, id: 702155

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    31. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 5310

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    32. test_browser_delete_close_tabs, id: 702076

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    33. test_public_chat_mark_all_messages_as_read, id: 6270

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    34. test_browser_connection_is_secure_not_secure_warning, id: 702073

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    35. test_send_tx_set_recipient_options, id: 700757

    Class: TestSendTxDeviceMerged

    Device sessions

    36. test_onboarding_cant_sign_in_with_invalid_password_logcat, id: 700746

    Class: TestOnboardingOneDeviceMerged

    Device sessions

    37. test_group_chat_join_send_text_messages_push, id: 700731

    Class: TestGroupChatMultipleDeviceMerged

    Device sessions

    38. test_browser_web3_permissions_testdapp, id: 702078

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    39. test_wallet_add_delete_watch_only_account, id: 700760

    Class: TestWalletManagementDeviceMerged

    Device sessions

    40. test_group_chat_decline_invite_chat_highligted, id: 5756

    Class: TestGroupChatMultipleDeviceMerged

    Device sessions

    41. test_public_chat_tag_message, id: 700738

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    42. test_onboarding_share_wallet_address, id: 700744

    Class: TestOnboardingOneDeviceMerged

    Device sessions

    43. test_keycard_create_account_unlock_same_seed, id: 5689

    Class: TestKeycardTxOneDeviceMerged

    Device sessions

    44. test_1_1_chat_command_send_tx_eth_outgoing_tx_push, id: 6253

    Class: TestCommandsMultipleDevicesMerged

    Device sessions

    45. test_public_chat_navigate_to_chat_when_relaunch, id: 5396

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    46. test_public_chat_copy_and_paste_message_in_chat_input, id: 5317

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    47. test_public_chat_fetch_more_history, id: 5675

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    48. test_wallet_fetching_balance_after_offline_insufficient_funds_errors, id: 700766

    Class: TestWalletManagementDeviceMerged

    Device sessions

    49. test_group_chat_offline_pn, id: 3998

    Class: TestGroupChatMultipleDeviceMerged

    Device sessions

    50. test_restore_account_migrate_multiaccount_to_keycard_db_saved, id: 702177

    Class: TestContactBlockMigrateKeycardMultipleSharedDevices

    Device sessions

    51. test_group_chat_add_new_member_activity_centre, id: 700732

    Class: TestGroupChatMultipleDeviceMerged

    Device sessions

    52. test_public_chat_links_with_previews_github_youtube_twitter_gif_send_enable, id: 700737

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    53. test_ens_purchased_in_profile, id: 702152

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    54. test_1_1_chat_non_latin_message_to_newly_added_contact_with_profile_picture_on_different_networks, id: 5315

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    55. test_keycard_send_tx_eth, id: 700767

    Class: TestKeycardTxOneDeviceMerged

    Device sessions

    56. test_restore_account_migrate_multiaccount_to_keycard_no_db_saved_add_wallet_send_tx, id: 702189

    Class: TestRestoreOneDeviceMerged

    Device sessions

    57. test_browser_offline, id: 702075

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    58. test_browser_invalid_url, id: 702074

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    59. test_restore_seed_phrase_field_validation, id: 700750

    Class: TestRestoreOneDeviceMerged

    Device sessions

    60. test_wallet_add_account_generate_new, id: 700759

    Class: TestWalletManagementDeviceMerged

    Device sessions

    61. test_start_new_chat_public_key_validation, id: 702158

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    62. test_restore_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 700748

    Class: TestRestoreOneDeviceMerged

    Device sessions

    63. test_public_chat_message_send_check_timestamps_while_on_different_tab, id: 5313

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    64. test_wallet_tx_history_copy_tx_hash_on_cellular, id: 700756

    Class: TestWalletManagementDeviceMerged

    Device sessions

    65. test_cellular_settings_on_off_public_chat_fetching_history, id: 702188

    Class: TestContactBlockMigrateKeycardMultipleSharedDevices

    Device sessions

    66. test_1_1_chat_delete_via_delete_button_relogin, id: 5387

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    67. test_group_chat_leave_relogin, id: 3997

    Class: TestGroupChatMultipleDeviceMerged

    Device sessions

    68. test_public_chat_message_delete, id: 700735

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    69. test_keycard_wallet_recover_pairing_check_balance_after_offline_tx_history, id: 700770

    Class: TestKeycardTxOneDeviceMerged

    Device sessions

    70. test_1_1_chat_push_emoji, id: 6283

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    @Parveshdhull Parveshdhull merged commit 2a81814 into develop May 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    No open projects
    Archived in project
    Development

    Successfully merging this pull request may close these issues.

    4 participants