-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quo2, Switcher Navigation #13167
Quo2, Switcher Navigation #13167
Conversation
Jenkins BuildsClick to see older builds (30)
|
534a961
to
69abb56
Compare
hey @Parveshdhull great start :) i think that switcher shouldn't be a part of quo2, because its not really a component which can be reused somehow, so I would implement it in |
Yes, that sounds better. I will move them 👍 Thank you |
9b7cb23
to
f996385
Compare
7d456f8
to
cdeefd5
Compare
cdeefd5
to
cfffa31
Compare
PR is still in WIP, I wanted to merge it for now to avoid complex rebase |
Most of the code consists only in Switcher and Navigation2 directory, so that it will not effect current develop |
regarding icons names, im not sure how to it better, i understand we will have two versions of icons, probably instead of |
0af7e13
to
8bd2860
Compare
8bd2860
to
523cc90
Compare
Please, ping me in case of any possible regression, thanks! |
83% of end-end tests have passed
Failed tests (14)Click to expand
Passed tests (70)Click to expand
|
Summary
PR implements bottom navigation bar and basic navigation for switcher implementation.
Implementation is rough draft to test how switcher can be part of navigation
status: wip