-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix currency and sticker synchronisation #13243
Conversation
Jenkins BuildsClick to see older builds (63)
|
2ce5b85
to
5837a08
Compare
0dc51c6
to
8579206
Compare
8579206
to
cb9b461
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
50eb2bf
to
720f4fa
Compare
Hey @audriu, builds for this PR were not built, could you please take a look, rebase it against the latest develop, and ping someone from the QA team when it's ready to be tested (or just move it to the |
68ccaad
to
a06f500
Compare
a06f500
to
8d530d7
Compare
95% of end-end tests have passed
Failed tests (4)Click to expand
Passed tests (80)Click to expand
|
0% of end-end tests have passed
Failed tests (4)Click to expand
|
1883f2d
to
12d08f1
Compare
0% of end-end tests have passed
Failed tests (84)Click to expand
|
0% of end-end tests have passed
Failed tests (84)Click to expand
|
@audriu thanx for the PR. Please, take a look at next issues. ISSUE 1 Stickers are not synced throughout devices after syncingSTR:
Actual result: stickerpack is not synced from Device 1 to Device 2 ISSUE 2 Stickers are not synced on paired devicesSTR:
Actual result: stickerpack did not appear on paired Device 2 ISSUE 3 Stickerpacks are not backed upAccording to @cammellos description "This settings should also be backed up, similarly as we do for contacts." Currently back up does not work. STR:
Actual result: stickerpack did not appear on Device 2 after back up Attached video demonstrates the process of reproduction of all 3 issues. On the left screen side is Android, on the right is IOS. sticker_sync_bug.mp4I've attached logs only from Android device, as sharing logs from IOS is currently broken. |
0% of end-end tests have passed
Failed tests (84)Click to expand
|
86% of end-end tests have passed
Failed tests (12)Click to expand
Passed tests (72)Click to expand
|
8f6b797
to
0f5b3cf
Compare
@audriu Thank you for fixes. ISSUES 1 and 2 are fixed. Although still reproducing ISSUE 3. |
@pavloburykh thanks for testing. Backups will come when I implement this ticket #13193 |
88% of end-end tests have passed
Failed tests (10)Click to expand
Passed tests (74)Click to expand
|
100% of end-end tests have passed
Not executed tests (168)Passed tests (7)Click to expand
|
50% of end-end tests have passed
Failed tests (5)Click to expand
Passed tests (5)Click to expand
|
@audriu thanx. Ready for merge. |
38ed694
to
5d0a1f7
Compare
5d0a1f7
to
743d5c0
Compare
status-im/status-go@640793f...a244d77 Signed-off-by: Audrius Molis <masta@dr.com>
743d5c0
to
4909ec9
Compare
Closes #12889
Closes #13190
Summary
Enable currency settings and installed sticker pack synchronization between devices on the same account.
Testing notes
there are some steps to reproduce currency synchronization
#13053 (comment)
Platforms
Functional
Steps to test
there are some steps to reproduce currency synchronization
#13053 (comment)
status: READY