Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nickname not setted on adding contact #13341

Merged
merged 2 commits into from
May 10, 2022
Merged

Conversation

Parveshdhull
Copy link
Member

@Parveshdhull Parveshdhull commented May 9, 2022

fixes #13328

Issue cause: Initialization of nickname reagent atom was the part of component/view definition, so whenever nickname changed component rendered again and atom reinitialized with empty value.

status: ready

@status-im-auto
Copy link
Member

status-im-auto commented May 9, 2022

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ e11797a #1 2022-05-09 22:30:51 ~8 min android-e2e 📦apk 📲
✔️ e11797a #1 2022-05-09 22:31:16 ~9 min android 📦apk 📲
✔️ e11797a #1 2022-05-09 22:34:38 ~12 min ios 📦ipa 📲
✔️ a1caecc #2 2022-05-10 12:11:39 ~9 min android 📦apk 📲
✔️ a1caecc #2 2022-05-10 12:12:43 ~10 min android-e2e 📦apk 📲
✔️ a1caecc #2 2022-05-10 12:18:13 ~15 min ios 📦ipa 📲

@status-im-auto
Copy link
Member

79% of end-end tests have passed

Total executed tests: 80
Failed tests: 17
Passed tests: 63
Not executed tests: 4
IDs of not executed tests: 700748,700749,702189,700750 
IDs of failed tests: 700762,700764,700739,702077,700763,702072,702157,702076,702073,702078,700738,5396,5317,5675,700767,702075,702074 

Not executed tests (4)

Click to expand
  • Rerun not executed tests
  • Failed tests (17)

    Click to expand
  • Rerun failed tests

  • 1. test_wallet_add_account_seed_phrase_collectibles_rinkeby_set_as_profile_image, id: 700762

    Device 1: Find `Text` by `xpath`: `//*[@text='Coins & Steel Exclusive Item Skin V2']//following-sibling::android.widget.TextView`
    Device 1: Find `Text` by `xpath`: `//*[@text='Coins & Steel Exclusive Item Skin V2']//following-sibling::android.widget.TextView`

    Device 1: Text by xpath: `//*[@text='Coins & Steel Exclusive Item Skin V2']//following-sibling::android.widget.TextView` is not found on the screen

    Class: TestWalletManagementDeviceMerged

    Device sessions

    2. test_send_tx_token_7_decimals, id: 700764

    Device 1: ADI value is 499.9189599
    Device 1: Waiting 400s for ADI updated balance

    Device 1: Balance ADI 499.9189599 is not changed during 400 seconds!

    Class: TestSendTxDeviceMerged

    Device sessions

    3. test_public_chat_open_using_deep_link, id: 700739
    Test setup failed: Sauce could not start your job. For more information on what happened, please visit https://app.saucelabs.com/tests/b21b9e5d532d4ba5bda29216f2e70cbb

    Class: TestPublicChatBrowserOneDeviceMerged

    4. test_browser_bookmarks_create_edit_remove, id: 702077
    Test setup failed: Sauce could not start your job. For more information on what happened, please visit https://app.saucelabs.com/tests/b21b9e5d532d4ba5bda29216f2e70cbb

    Class: TestPublicChatBrowserOneDeviceMerged

    5. test_send_tx_eth_check_logcat, id: 700763

    Transaction #5, amount is 0.0
    {'blockNumber': '12241887', 'timeStamp': '1651828462', 'hash': '0x3ca12e22ce067a168445f64b5163c4cfbb60ffd92acad4eae901b94d95315737', 'nonce': '1363', 'blockHash': '0xc2523b18307105020eb6d429dcf20aa72ceca1dce6c25f8f066558770908a58f', 'transactionIndex': '5', 'from': '0x512543419b894307ea979c8d24219c279be2315b', 'to': '0xe639e24346d646e927f323558e6e0031bfc93581', 'value': '0', 'gas': '41235', 'gasPrice': '27674221360', 'isError': '0', 'txreceipt_status': '1', 'input': '0xa9059cbb000000000000000000000000aa2c8fbfed0e36e793aa51707c4f575d2b7f2dc800000000000000000000000000000000000000000000000000000000000008b7', 'contractAddress': '', 'cumulativeGasUsed': '583451', 'gasUsed': '34363', 'confirmations': '10635'}

    Transaction with amount 0.0008761 is not found in list of ETH transactions, address is 512543419b894307EA979C8d24219c279Be2315B during 300s

    Class: TestSendTxDeviceMerged

    Device sessions

    6. test_browser_blocked_url, id: 702072
    Test setup failed: Sauce could not start your job. For more information on what happened, please visit https://app.saucelabs.com/tests/b21b9e5d532d4ba5bda29216f2e70cbb

    Class: TestPublicChatBrowserOneDeviceMerged

    7. test_sticker_1_1_public_chat, id: 702157

    Device 2: Find `Button` by `xpath`: `//*[@content-desc='sticker-pack-name'][@text='Tozemoon']/..//*[@content-desc='sticker-pack-price']`
    Device 2: Find `Button` by `xpath`: `//*[@content-desc='sticker-pack-name'][@text='Tozemoon']/..//*[@content-desc='sticker-pack-price']`

    Device 2: Button by xpath: `//*[@content-desc='sticker-pack-name'][@text='Tozemoon']/..//*[@content-desc='sticker-pack-price']` is not found on the screen

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    8. test_browser_delete_close_tabs, id: 702076
    Test setup failed: Sauce could not start your job. For more information on what happened, please visit https://app.saucelabs.com/tests/b21b9e5d532d4ba5bda29216f2e70cbb

    Class: TestPublicChatBrowserOneDeviceMerged

    9. test_browser_connection_is_secure_not_secure_warning, id: 702073
    Test setup failed: Sauce could not start your job. For more information on what happened, please visit https://app.saucelabs.com/tests/b21b9e5d532d4ba5bda29216f2e70cbb

    Class: TestPublicChatBrowserOneDeviceMerged

    10. test_browser_web3_permissions_testdapp, id: 702078
    Test setup failed: Sauce could not start your job. For more information on what happened, please visit https://app.saucelabs.com/tests/b21b9e5d532d4ba5bda29216f2e70cbb

    Class: TestPublicChatBrowserOneDeviceMerged

    11. test_public_chat_tag_message, id: 700738
    Test setup failed: Sauce could not start your job. For more information on what happened, please visit https://app.saucelabs.com/tests/b21b9e5d532d4ba5bda29216f2e70cbb

    Class: TestPublicChatBrowserOneDeviceMerged

    12. test_public_chat_navigate_to_chat_when_relaunch, id: 5396
    Test setup failed: Sauce could not start your job. For more information on what happened, please visit https://app.saucelabs.com/tests/b21b9e5d532d4ba5bda29216f2e70cbb

    Class: TestPublicChatBrowserOneDeviceMerged

    13. test_public_chat_copy_and_paste_message_in_chat_input, id: 5317
    Test setup failed: Sauce could not start your job. For more information on what happened, please visit https://app.saucelabs.com/tests/b21b9e5d532d4ba5bda29216f2e70cbb

    Class: TestPublicChatBrowserOneDeviceMerged

    14. test_public_chat_fetch_more_history, id: 5675
    Test setup failed: Sauce could not start your job. For more information on what happened, please visit https://app.saucelabs.com/tests/b21b9e5d532d4ba5bda29216f2e70cbb

    Class: TestPublicChatBrowserOneDeviceMerged

    15. test_keycard_send_tx_eth, id: 700767

    Device 1: Waiting 400s for ETH updated balance
    Device 1: Selecting ETH asset

    E http.client.RemoteDisconnected: Remote end closed connection without response

    During handling of the above exception, another exception occurred:
    ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response'))


    Class: TestKeycardTxOneDeviceMerged

    Device sessions

    16. test_browser_offline, id: 702075
    Test setup failed:
    Sauce could not start your job. For more information on what happened, please visit https://app.saucelabs.com/tests/b21b9e5d532d4ba5bda29216f2e70cbb


    Class: TestPublicChatBrowserOneDeviceMerged

    17. test_browser_invalid_url, id: 702074
    Test setup failed:
    Sauce could not start your job. For more information on what happened, please visit https://app.saucelabs.com/tests/b21b9e5d532d4ba5bda29216f2e70cbb


    Class: TestPublicChatBrowserOneDeviceMerged

    Passed tests (63)

    Click to expand

    1. test_wallet_manage_assets, id: 700758

    Class: TestWalletManagementDeviceMerged

    Device sessions

    2. test_public_chat_message_edit, id: 700734

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    3. test_contact_block_unblock_public_chat_offline, id: 702176

    Class: TestContactBlockMigrateKeycardMultipleSharedDevices

    Device sessions

    4. test_1_1_chat_text_message_edit_delete_push_disappear, id: 695843

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    5. test_keycard_relogin_after_restore, id: 700768

    Class: TestKeycardTxOneDeviceMerged

    Device sessions

    6. test_group_chat_push_system_messages_when_invited, id: 3994

    Class: TestGroupChatMultipleDeviceMerged

    Device sessions

    7. test_ens_command_send_tx_eth_1_1_chat, id: 702153

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    8. test_contact_add_remove_mention_default_username_nickname_public_chat, id: 702175

    Class: TestContactBlockMigrateKeycardMultipleSharedDevices

    Device sessions

    9. test_public_chat_unread_messages_counter, id: 5360

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    10. test_1_1_chat_command_decline_eth_push_changing_state, id: 6265

    Class: TestCommandsMultipleDevicesMerged

    Device sessions

    11. test_pairing_sync_contacts_block_unblock, id: 702196

    Class: TestPairingSyncMultipleDevicesMerged

    Device sessions

    12. test_public_chat_emoji_send_copy_paste_reply, id: 700719

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    13. test_1_1_chat_command_request_and_send_tx_stt_in_1_1_chat_offline, id: 6263

    Class: TestCommandsMultipleDevicesMerged

    Device sessions

    14. test_public_chat_unread_messages_counter_for_mention_relogin, id: 700718

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    15. test_send_tx_custom_token_18_decimals_invalid_password, id: 700765

    Class: TestSendTxDeviceMerged

    Device sessions

    16. test_onboarding_add_new_multiaccount_username_by_position_pass_validation, id: 700747

    Class: TestOnboardingOneDeviceMerged

    Device sessions

    17. test_public_chat_delete_chat_long_press, id: 5319

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    18. test_onboarding_home_initial_popup, id: 700742

    Class: TestOnboardingOneDeviceMerged

    Device sessions

    19. test_wallet_add_hide_unhide_account_private_key, id: 700761

    Class: TestWalletManagementDeviceMerged

    Device sessions

    20. test_1_1_chat_message_reaction, id: 6315

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    21. test_ens_mention_push_highlighted_public_chat, id: 702156

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    22. test_keycard_send_tx_sign_message_request_stt_testdapp, id: 700769

    Class: TestKeycardTxOneDeviceMerged

    Device sessions

    23. test_1_1_chat_image_send_save_reply, id: 6305

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    24. test_1_1_chat_emoji_and_link_send_and_open, id: 5373

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    25. test_public_chat_link_send_open, id: 700736

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    26. test_keycard_command_send_tx_eth_1_1_chat, id: 702186

    Class: TestContactBlockMigrateKeycardMultipleSharedDevices

    Device sessions

    27. test_onboarding_share_contact_address, id: 700743

    Class: TestOnboardingOneDeviceMerged

    Device sessions

    28. test_onboarding_backup_seed_phrase_restore_same_login_logcat, id: 700745

    Class: TestOnboardingOneDeviceMerged

    Device sessions

    29. test_ens_mention_nickname_1_1_chat, id: 702155

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    30. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 5310

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    31. test_public_chat_mark_all_messages_as_read, id: 6270

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    32. test_send_tx_set_recipient_options, id: 700757

    Class: TestSendTxDeviceMerged

    Device sessions

    33. test_onboarding_cant_sign_in_with_invalid_password_logcat, id: 700746

    Class: TestOnboardingOneDeviceMerged

    Device sessions

    34. test_send_tx_sign_message_2tx_in_batch_tx_filters_request_stt_testdapp, id: 5342

    Class: TestSendTxDeviceMerged

    Device sessions

    35. test_group_chat_join_send_text_messages_push, id: 700731

    Class: TestGroupChatMultipleDeviceMerged

    Device sessions

    36. test_1_1_chat_text_message_with_push, id: 6316

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    37. test_wallet_add_delete_watch_only_account, id: 700760

    Class: TestWalletManagementDeviceMerged

    Device sessions

    38. test_group_chat_decline_invite_chat_highligted, id: 5756

    Class: TestGroupChatMultipleDeviceMerged

    Device sessions

    39. test_onboarding_share_wallet_address, id: 700744

    Class: TestOnboardingOneDeviceMerged

    Device sessions

    40. test_keycard_create_account_unlock_same_seed, id: 5689

    Class: TestKeycardTxOneDeviceMerged

    Device sessions

    41. test_1_1_chat_command_send_tx_eth_outgoing_tx_push, id: 6253

    Class: TestCommandsMultipleDevicesMerged

    Device sessions

    42. test_pairing_sync_initial_contacts_blocked_users, id: 702194

    Class: TestPairingSyncMultipleDevicesMerged

    Device sessions

    43. test_pairing_sync_1_1_chat_message, id: 702198

    Class: TestPairingSyncMultipleDevicesMerged

    Device sessions

    44. test_pairing_sync_public_chat_add_remove, id: 702199

    Class: TestPairingSyncMultipleDevicesMerged

    Device sessions

    45. test_wallet_fetching_balance_after_offline_insufficient_funds_errors, id: 700766

    Class: TestWalletManagementDeviceMerged

    Device sessions

    46. test_group_chat_offline_pn, id: 3998

    Class: TestGroupChatMultipleDeviceMerged

    Device sessions

    47. test_restore_account_migrate_multiaccount_to_keycard_db_saved, id: 702177

    Class: TestContactBlockMigrateKeycardMultipleSharedDevices

    Device sessions

    48. test_group_chat_add_new_member_activity_centre, id: 700732

    Class: TestGroupChatMultipleDeviceMerged

    Device sessions

    49. test_public_chat_links_with_previews_github_youtube_twitter_gif_send_enable, id: 700737

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    50. test_ens_purchased_in_profile, id: 702152

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    51. test_1_1_chat_non_latin_message_to_newly_added_contact_with_profile_picture_on_different_networks, id: 5315

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    52. test_wallet_add_account_generate_new, id: 700759

    Class: TestWalletManagementDeviceMerged

    Device sessions

    53. test_start_new_chat_public_key_validation, id: 702158

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    54. test_public_chat_message_send_check_timestamps_while_on_different_tab, id: 5313

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    55. test_wallet_tx_history_copy_tx_hash_on_cellular, id: 700756

    Class: TestWalletManagementDeviceMerged

    Device sessions

    56. test_cellular_settings_on_off_public_chat_fetching_history, id: 702188

    Class: TestContactBlockMigrateKeycardMultipleSharedDevices

    Device sessions

    57. test_1_1_chat_delete_via_delete_button_relogin, id: 5387

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    58. test_group_chat_leave_relogin, id: 3997

    Class: TestGroupChatMultipleDeviceMerged

    Device sessions

    59. test_public_chat_message_delete, id: 700735

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    60. test_keycard_wallet_recover_pairing_check_balance_after_offline_tx_history, id: 700770

    Class: TestKeycardTxOneDeviceMerged

    Device sessions

    61. test_1_1_chat_push_emoji, id: 6283

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    62. test_pairing_sync_initial_public_chats, id: 702195

    Class: TestPairingSyncMultipleDevicesMerged

    Device sessions

    63. test_pairing_sync_contacts_add_remove_set_nickname_ens, id: 702197

    Class: TestPairingSyncMultipleDevicesMerged

    Device sessions

    @status-im-auto
    Copy link
    Member

    100% of end-end tests have passed

    Total executed tests: 4
    Failed tests: 0
    Passed tests: 4
    Not executed tests: 1
    
    IDs of not executed tests: 702160 
    

    Not executed tests (1)

    Click to expand
  • Rerun not executed tests
  • Passed tests (4)

    Click to expand

    1. test_restore_set_up_wallet_sign_phrase, id: 700749

    Class: TestRestoreOneDeviceMerged

    Device sessions

    2. test_restore_account_migrate_multiaccount_to_keycard_no_db_saved_add_wallet_send_tx, id: 702189

    Class: TestRestoreOneDeviceMerged

    Device sessions

    3. test_restore_seed_phrase_field_validation, id: 700750

    Class: TestRestoreOneDeviceMerged

    Device sessions

    4. test_restore_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 700748

    Class: TestRestoreOneDeviceMerged

    Device sessions

    @qoqobolo qoqobolo self-assigned this May 10, 2022
    @qoqobolo
    Copy link
    Contributor

    @Parveshdhull thanks for the fix! LGTM!
    But just wondering, is it possible to save a pre-populated value for a nickname in the case of a QR scanning?
    I mean now it works like on the video below, the nickname is lost if you first enter it and then scan QR.
    But I'm not sure it's possible to implement.

    IMG_1134.MP4

    @Parveshdhull
    Copy link
    Member Author

    @qoqobolo should be fixed now

    @qoqobolo
    Copy link
    Contributor

    Thank you @Parveshdhull, works great!
    PR can be merged.

    @Parveshdhull Parveshdhull merged commit b160670 into develop May 10, 2022
    @Parveshdhull Parveshdhull deleted the fix/nickname-issue branch May 10, 2022 14:18
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    No open projects
    Archived in project
    Development

    Successfully merging this pull request may close these issues.

    Nickname is not set if adding contact via "Contacts" in Profile
    4 participants