Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of React Native Blur view for android #13663

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

Parveshdhull
Copy link
Member

@Parveshdhull Parveshdhull commented Jul 13, 2022

fixes: #13664

Summary

PR implements React Native Blur view for android.

Entire screen inside visual area of blur-view will be blurred, except children's of blur-view.
It doesn't matter if another view inside the visual area was above or below of the blur-view. Blur-view takes a snapshot of the visual area and blurs it.

Uses

[react/blur-view
 {:style         style
  :blur-amount   4
  :overlay-color :transparent
  :blur-type     :light}
 ;; Child view
] 

Note: overlay-color is required, otherwise blur-view will also affect surrounding view (ref)

status: ready

@Parveshdhull Parveshdhull self-assigned this Jul 13, 2022
@status-im-auto
Copy link
Member

status-im-auto commented Jul 13, 2022

Jenkins Builds

Click to see older builds (6)
Commit #️⃣ Finished (UTC) Duration Platform Result
65b3351 #1 2022-07-13 17:05:58 ~4 min android-e2e 📄log
65b3351 #1 2022-07-13 17:05:58 ~4 min android 📄log
✔️ 65b3351 #1 2022-07-13 17:11:58 ~10 min ios 📦ipa 📲
✖️ 994646f #2 2022-07-13 18:00:11 ~9 min android-e2e 📦apk 📲
✖️ 994646f #2 2022-07-13 18:00:27 ~9 min android 📦apk 📲
✖️ 994646f #2 2022-07-13 18:01:24 ~10 min ios 📦ipa 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
30a5b44 #3 2022-07-13 20:36:57 ~3 min android-e2e 📄log
30a5b44 #3 2022-07-13 20:37:01 ~4 min android 📄log
✖️ 30a5b44 #3 2022-07-13 20:44:17 ~11 min ios 📦ipa 📲
✔️ 5d54577 #4 2022-07-13 21:03:38 ~9 min android-e2e 📦apk 📲
✔️ 5d54577 #4 2022-07-13 21:03:51 ~9 min android 📦apk 📲
✔️ 5d54577 #4 2022-07-13 21:04:05 ~9 min ios 📦ipa 📲

@Parveshdhull Parveshdhull force-pushed the feature/switcher-blurred-view branch 2 times, most recently from 994646f to 30a5b44 Compare July 13, 2022 20:32
@Parveshdhull Parveshdhull force-pushed the feature/switcher-blurred-view branch from 30a5b44 to 5d54577 Compare July 13, 2022 20:53
@Parveshdhull Parveshdhull changed the title [WIP]: Implement blurred background for switcher Implementation of React Native Blur for android Jul 13, 2022
@Parveshdhull Parveshdhull changed the title Implementation of React Native Blur for android Implementation of React Native Blur view for android Jul 13, 2022
@Parveshdhull Parveshdhull requested a review from cammellos July 13, 2022 23:04
@Parveshdhull Parveshdhull marked this pull request as ready for review July 13, 2022 23:04
@Parveshdhull Parveshdhull requested a review from jakubgs as a code owner July 13, 2022 23:04
@@ -18,3 +18,5 @@ include ':react-native-status'
project(':react-native-status').projectDir = new File(rootProject.projectDir, '../modules/react-native-status/android')
include ':react-native-status-keycard'
project(':react-native-status-keycard').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-status-keycard/android')
include ':react-native-blur'
project(':react-native-blur').projectDir = new File(rootProject.projectDir, '../node_modules/@react-native-community/blur/android')
Copy link
Member Author

@Parveshdhull Parveshdhull Jul 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Project name don't allow / @, So instead of using @react-native-community/blur as project name, library name is being used here. (same as ref)

@@ -16,7 +16,7 @@
"@babel/preset-typescript": "^7.17.12",
"@react-native-community/async-storage": "^1.11.0",
"@react-native-community/audio-toolkit": "git+https://github.com/tbenr/react-native-audio-toolkit.git#refs/tags/v2.0.3-status-v6",
"@react-native-community/blur": "^3.6.0",
"@react-native-community/blur": "git+https://github.com/Kureev/react-native-blur#refs/tags/v3.6.1",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v3.6.1 is required for fixing crash on android while navigating (ref). But for some reason it only available on repo and not published on npm, even though it was created on Apr 27, 2021

@status-im-auto
Copy link
Member

90% of end-end tests have passed

Total executed tests: 84
Failed tests: 8
Passed tests: 76
IDs of failed tests: 702153,702196,6263,6305,5310,702194,702188,5387 

Failed tests (8)

Click to expand
  • Rerun failed tests

  • 1. test_ens_command_send_tx_eth_1_1_chat, id: 702153

    Device 2: Looking for chat: 'Forked Slategray Vampirebat'
    Device 2: Click until `EditBox` by `accessibility id`: `chat-message-input` will be presented

    /home/jenkins/.local/lib/python3.8/site-packages/urllib3/connectionpool.py:699: in urlopen httplib_response = self._make_request( /home/jenkins/.local/lib/python3.8/site-packages/urllib3/connectionpool.py:445: in _make_request six.raise_from(e, No

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    2. test_pairing_sync_contacts_block_unblock, id: 702196

    Device 2: Tap on found: Button
    Device 2: Find `Button` by `accessibility id`: `blocked-users-list-button`

    critical/test_pairing_devices_sync.py:193: in test_pairing_sync_contacts_block_unblock self.profile_2.blocked_users_button.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element r

    Class: TestPairingSyncMultipleDevicesMerged

    Device sessions

    3. test_1_1_chat_command_request_and_send_tx_stt_in_1_1_chat_offline, id: 6263

    Device 1: Find `HomeButton` by `xpath`: `//*[contains(@content-desc,'tab, 1 out of 5')]`
    Device 1: Find `HomeButton` by `xpath`: `//*[contains(@content-desc,'tab, 1 out of 5')]`

    critical/chats/test_1_1_public_chats.py:197: in test_1_1_chat_command_request_and_send_tx_stt_in_1_1_chat_offline home.connection_offline_icon.wait_for_invisibility_of_element(100) ../views/base_element.py:144: in wait_for_invisibility_of_element

    Class: TestCommandsMultipleDevicesMerged

    Device sessions

    4. test_1_1_chat_image_send_save_reply, id: 6305

    Device 2: Tap 'Confirm' on native keyboard
    Device 2: Find `Button` by `accessibility id`: `save-button`

    critical/chats/test_1_1_public_chats.py:547: in test_1_1_chat_image_send_save_reply self.chat_2.save_image_icon_button.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    5. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 5310

    Device 2: Looking for chat: 'Attractive Hidden Woodborer'
    Device 2: Wait for element `Button` for max 30s and click when it is available

    critical/chats/test_1_1_public_chats.py:574: in test_1_1_chat_is_shown_message_sent_delivered_from_offline self.home_2.get_chat(username=self.default_username_1).click() ../views/home_view.py:254: in get_chat self.notifications_unread_badge.wait_a

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    6. test_pairing_sync_initial_contacts_blocked_users, id: 702194

    Device 2: Tap on found: Button
    Device 2: Find `Button` by `accessibility id`: `blocked-users-list-button`

    critical/test_pairing_devices_sync.py:159: in test_pairing_sync_initial_contacts_blocked_users self.profile_2.blocked_users_button.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_eleme

    Class: TestPairingSyncMultipleDevicesMerged

    Device sessions

    7. test_cellular_settings_on_off_public_chat_fetching_history, id: 702188

    Device 1: Find `Button` by `xpath`: `//*[@text="Use mobile data"]/following-sibling::android.widget.Switch[1]`
    Device 1: Find `Button` by `xpath`: `//*[@text="Ask me when on mobile network"]/following-sibling::android.widget.Switch[1]`

    critical/chats/test_1_1_public_chats.py:931: in test_cellular_settings_on_off_public_chat_fetching_history self.errors.verify_no_errors() base_test_case.py:189: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self

    Class: TestContactBlockMigrateKeycardMultipleSharedDevices

    Device sessions

    8. test_1_1_chat_delete_via_delete_button_relogin, id: 5387

    Device 2: Looking for chat: 'Attractive Hidden Woodborer'
    Device 2: Wait for element `Button` for max 30s and click when it is available

    critical/chats/test_1_1_public_chats.py:604: in test_1_1_chat_delete_via_delete_button_relogin self.home_2.get_chat(username=self.default_username_1).click() ../views/home_view.py:254: in get_chat self.notifications_unread_badge.wait_and_click(wai

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    Passed tests (76)

    Click to expand

    1. test_wallet_manage_assets, id: 700758

    Class: TestWalletManagementDeviceMerged

    Device sessions

    2. test_public_chat_message_edit, id: 700734

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    3. test_contact_block_unblock_public_chat_offline, id: 702176

    Class: TestContactBlockMigrateKeycardMultipleSharedDevices

    Device sessions

    4. test_1_1_chat_text_message_edit_delete_push_disappear, id: 695843

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    5. test_keycard_relogin_after_restore, id: 700768

    Class: TestKeycardTxOneDeviceMerged

    Device sessions

    6. test_group_chat_push_system_messages_when_invited, id: 3994

    Class: TestGroupChatMultipleDeviceMerged

    Device sessions

    7. test_send_tx_token_7_decimals, id: 700764

    Class: TestSendTxDeviceMerged

    Device sessions

    8. test_contact_add_remove_mention_default_username_nickname_public_chat, id: 702175

    Class: TestContactBlockMigrateKeycardMultipleSharedDevices

    Device sessions

    9. test_public_chat_open_using_deep_link, id: 700739

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    10. test_public_chat_unread_messages_counter, id: 5360

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    11. test_1_1_chat_command_decline_eth_push_changing_state, id: 6265

    Class: TestCommandsMultipleDevicesMerged

    Device sessions

    12. test_public_chat_emoji_send_copy_paste_reply, id: 700719

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    13. test_browser_bookmarks_create_edit_remove, id: 702077

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    14. test_send_tx_eth_check_logcat, id: 700763

    Class: TestSendTxDeviceMerged

    Device sessions

    15. test_public_chat_unread_messages_counter_for_mention_relogin, id: 700718

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    16. test_send_tx_custom_token_18_decimals_invalid_password, id: 700765

    Class: TestSendTxDeviceMerged

    Device sessions

    17. test_onboarding_add_new_multiaccount_username_by_position_pass_validation, id: 700747

    Class: TestOnboardingOneDeviceMerged

    Device sessions

    18. test_wallet_add_account_seed_phrase_validation, id: 700762

    Class: TestWalletManagementDeviceMerged

    Device sessions

    19. test_public_chat_delete_chat_long_press, id: 5319

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    20. test_onboarding_home_initial_popup, id: 700742

    Class: TestOnboardingOneDeviceMerged

    Device sessions

    21. test_browser_blocked_url, id: 702072

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    22. test_wallet_add_hide_unhide_account_private_key, id: 700761

    Class: TestWalletManagementDeviceMerged

    Device sessions

    23. test_1_1_chat_message_reaction, id: 6315

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    24. test_ens_mention_push_highlighted_public_chat, id: 702156

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    25. test_1_1_chat_emoji_send_reply_and_open_link, id: 5373

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    26. test_keycard_send_tx_sign_message_request_stt_testdapp, id: 700769

    Class: TestKeycardTxOneDeviceMerged

    Device sessions

    27. test_group_chat_highligted, id: 5756

    Class: TestGroupChatMultipleDeviceMerged

    Device sessions

    28. test_public_chat_link_send_open, id: 700736

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    29. test_keycard_command_send_tx_eth_1_1_chat, id: 702186

    Class: TestContactBlockMigrateKeycardMultipleSharedDevices

    Device sessions

    30. test_onboarding_share_contact_address, id: 700743

    Class: TestOnboardingOneDeviceMerged

    Device sessions

    31. test_sticker_1_1_public_chat, id: 702157

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    32. test_onboarding_backup_seed_phrase_restore_same_login_logcat, id: 700745

    Class: TestOnboardingOneDeviceMerged

    Device sessions

    33. test_restore_set_up_wallet_sign_phrase, id: 700749

    Class: TestRestoreOneDeviceMerged

    Device sessions

    34. test_ens_mention_nickname_1_1_chat, id: 702155

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    35. test_browser_delete_close_tabs, id: 702076

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    36. test_public_chat_mark_all_messages_as_read, id: 6270

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    37. test_browser_connection_is_secure_not_secure_warning, id: 702073

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    38. test_send_tx_set_recipient_options, id: 700757

    Class: TestSendTxDeviceMerged

    Device sessions

    39. test_onboarding_cant_sign_in_with_invalid_password_logcat, id: 700746

    Class: TestOnboardingOneDeviceMerged

    Device sessions

    40. test_send_tx_sign_message_2tx_in_batch_tx_filters_request_stt_testdapp, id: 5342

    Class: TestSendTxDeviceMerged

    Device sessions

    41. test_group_chat_join_send_text_messages_push, id: 700731

    Class: TestGroupChatMultipleDeviceMerged

    Device sessions

    42. test_browser_web3_permissions_testdapp, id: 702078

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    43. test_1_1_chat_text_message_with_push, id: 6316

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    44. test_wallet_add_delete_watch_only_account, id: 700760

    Class: TestWalletManagementDeviceMerged

    Device sessions

    45. test_public_chat_tag_message, id: 700738

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    46. test_onboarding_share_wallet_address, id: 700744

    Class: TestOnboardingOneDeviceMerged

    Device sessions

    47. test_keycard_create_account_unlock_same_seed, id: 5689

    Class: TestKeycardTxOneDeviceMerged

    Device sessions

    48. test_1_1_chat_command_send_tx_eth_outgoing_tx_push, id: 6253

    Class: TestCommandsMultipleDevicesMerged

    Device sessions

    49. test_public_chat_navigate_to_chat_when_relaunch, id: 5396

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    50. test_pairing_sync_1_1_chat_message, id: 702198

    Class: TestPairingSyncMultipleDevicesMerged

    Device sessions

    51. test_pairing_sync_public_chat_add_remove, id: 702199

    Class: TestPairingSyncMultipleDevicesMerged

    Device sessions

    52. test_public_chat_copy_and_paste_message_in_chat_input, id: 5317

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    53. test_public_chat_fetch_more_history, id: 5675

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    54. test_wallet_fetching_balance_after_offline_insufficient_funds_errors, id: 700766

    Class: TestWalletManagementDeviceMerged

    Device sessions

    55. test_group_chat_offline_pn, id: 3998

    Class: TestGroupChatMultipleDeviceMerged

    Device sessions

    56. test_restore_account_migrate_multiaccount_to_keycard_db_saved, id: 702177

    Class: TestContactBlockMigrateKeycardMultipleSharedDevices

    Device sessions

    57. test_group_chat_add_new_member_activity_centre, id: 700732

    Class: TestGroupChatMultipleDeviceMerged

    Device sessions

    58. test_public_chat_links_with_previews_github_youtube_twitter_gif_send_enable, id: 700737

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    59. test_ens_purchased_in_profile, id: 702152

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    60. test_1_1_chat_non_latin_message_to_newly_added_contact_with_profile_picture_on_different_networks, id: 5315

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    61. test_keycard_send_tx_eth, id: 700767

    Class: TestKeycardTxOneDeviceMerged

    Device sessions

    62. test_restore_account_migrate_multiaccount_to_keycard_no_db_saved_add_wallet_send_tx, id: 702189

    Class: TestRestoreOneDeviceMerged

    Device sessions

    63. test_browser_offline, id: 702075

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    64. test_browser_invalid_url, id: 702074

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    65. test_restore_seed_phrase_field_validation, id: 700750

    Class: TestRestoreOneDeviceMerged

    Device sessions

    66. test_wallet_add_account_generate_new, id: 700759

    Class: TestWalletManagementDeviceMerged

    Device sessions

    67. test_start_new_chat_public_key_validation, id: 702158

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    68. test_restore_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 700748

    Class: TestRestoreOneDeviceMerged

    Device sessions

    69. test_public_chat_message_send_check_timestamps_while_on_different_tab, id: 5313

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    70. test_wallet_tx_history_copy_tx_hash_on_cellular, id: 700756

    Class: TestWalletManagementDeviceMerged

    Device sessions

    71. test_group_chat_leave_relogin, id: 3997

    Class: TestGroupChatMultipleDeviceMerged

    Device sessions

    72. test_public_chat_message_delete, id: 700735

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    73. test_keycard_wallet_recover_pairing_check_balance_after_offline_tx_history, id: 700770

    Class: TestKeycardTxOneDeviceMerged

    Device sessions

    74. test_1_1_chat_push_emoji, id: 6283

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    75. test_pairing_sync_initial_public_chats, id: 702195

    Class: TestPairingSyncMultipleDevicesMerged

    Device sessions

    76. test_pairing_sync_contacts_add_remove_set_nickname_ens, id: 702197

    Class: TestPairingSyncMultipleDevicesMerged

    Device sessions

    @Parveshdhull Parveshdhull merged commit 236bbff into develop Jul 14, 2022
    @Parveshdhull Parveshdhull deleted the feature/switcher-blurred-view branch July 14, 2022 11:57
    @churik churik mentioned this pull request Jul 14, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    No open projects
    Archived in project
    Development

    Successfully merging this pull request may close these issues.

    Implement react-native-blur view for android
    4 participants