-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13564] account-avatar component #13700
Conversation
Jenkins BuildsClick to see older builds (90)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great job
88% of end-end tests have passed
Not executed tests (3)Failed tests (10)Click to expand
Passed tests (74)Click to expand
|
95% of end-end tests have passed
Not executed tests (3)Failed tests (4)Click to expand
Passed tests (80)Click to expand
|
98% of end-end tests have passed
Not executed tests (3)Failed tests (2)Click to expand
Passed tests (82)Click to expand
|
@cammellos @ibrkhalil : I'll be taking this up for a quick Design Review |
@ibrkhalil Design issue 1 There seems to be some issue with the dimensions of the icon that you have used, in this scenario it gets cut from the right hand side. you also need to work on retrieving the values of dark/light modes from theme instead of adding a boolean input field. |
90% of end-end tests have passed
Not executed tests (1)Failed tests (9)Click to expandClass TestKeycardTxOneDeviceMerged:
Class TestContactBlockMigrateKeycardMultipleSharedDevices:
Class TestEnsStickersMultipleDevicesMerged:
Class TestCommandsMultipleDevicesMerged:
Class TestSendTxDeviceMerged:
Passed tests (77)Click to expandClass TestRestoreOneDeviceMerged:
Class TestKeycardTxOneDeviceMerged:
Class TestOnboardingOneDeviceMerged:
Class TestWalletManagementDeviceMerged:
Class TestContactBlockMigrateKeycardMultipleSharedDevices:
Class TestOneToOneChatMultipleSharedDevices:
Class TestPublicChatBrowserOneDeviceMerged:
Class TestGroupChatMultipleDeviceMerged:
Class TestPublicChatMultipleDeviceMerged:
Class TestEnsStickersMultipleDevicesMerged:
Class TestPairingSyncMultipleDevicesMerged:
Class TestSendTxDeviceMerged:
|
@ibrkhalil please, re-request review on this PR and rebase your work to current |
71c3ac1
to
e3ab123
Compare
23e715f
to
669b3fb
Compare
100% of end-end tests have passed
Passed tests (87)Click to expandClass TestOnboardingOneDeviceMerged:
Class TestPublicChatMultipleDeviceMerged:
Class TestPairingSyncMultipleDevicesMerged:
Class TestRestoreOneDeviceMerged:
Class TestEnsStickersMultipleDevicesMerged:
Class TestKeycardTxOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevices:
Class TestCommandsMultipleDevicesMerged:
Class TestPublicChatBrowserOneDeviceMerged:
Class TestSendTxDeviceMerged:
Class TestGroupChatMultipleDeviceMerged:
Class TestWalletManagementDeviceMerged:
Class TestContactBlockMigrateKeycardMultipleSharedDevices:
|
100% of end-end tests have passed
Passed tests (10)Click to expandClass TestEnsStickersMultipleDevicesMerged:
Class TestSendTxDeviceMerged:
Class TestCommandsMultipleDevicesMerged:
Class TestKeycardTxOneDeviceMerged:
Class TestContactBlockMigrateKeycardMultipleSharedDevices:
|
02a2b58
to
51af638
Compare
Hi @ibrkhalil, Please can you rebase this PR and remove unused changes so that we can merge it? |
f551907
to
c090ec8
Compare
c090ec8
to
81acd1a
Compare
fixes #13564
status: ready