-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#13804] Extend integration tests to back up seed phrase #13853
Conversation
Jenkins BuildsClick to see older builds (34)
|
ba0de3d
to
462a279
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of minor points, but looks good!
src/status_im/profile/core.cljs
Outdated
(fx/defn finish | ||
{:events [:my-profile/finish]} | ||
[{:keys [db] :as cofx}] | ||
[cofx] | ||
(fx/merge cofx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need (fx/merge
anymore in this case, you can do:
...
[cofx]
(multiaccounts.update/clean-seed-phrase
cofx
{:on-success ....})
src/status_im/integration_test.cljs
Outdated
@@ -131,5 +140,38 @@ | |||
(rf-test/wait-for [::logout/logout-method] ; we need to logout to make sure the node is not in an inconsistent state between tests | |||
(assert-logout)))))))) | |||
|
|||
(deftest back-up-seed-phrase-test | |||
(println "========= back-up-seed-phrase-test") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could use log
instead of println
?
462a279
to
be7f86b
Compare
61% of end-end tests have passed
Not executed tests (2)Failed tests (33)Click to expandClass TestEnsStickersMultipleDevicesMerged:
Class TestSendTxDeviceMerged:
Class TestPublicChatBrowserOneDeviceMerged:
Class TestCommandsMultipleDevicesMerged:
Class TestContactBlockMigrateKeycardMultipleSharedDevices:
Class TestOnboardingOneDeviceMerged:
Class TestPairingSyncMultipleDevicesMerged:
Passed tests (52)Click to expandClass TestPublicChatMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevices:
Class TestKeycardTxOneDeviceMerged:
Class TestPublicChatBrowserOneDeviceMerged:
Class TestWalletManagementDeviceMerged:
Class TestRestoreOneDeviceMerged:
Class TestGroupChatMultipleDeviceMerged:
|
be7f86b
to
0afeb20
Compare
79% of end-end tests have passed
Failed tests (7)Click to expandClass TestSendTxDeviceMerged:
Class TestCommandsMultipleDevicesMerged:
Class TestContactBlockMigrateKeycardMultipleSharedDevices:
Class TestEnsStickersMultipleDevicesMerged:
Passed tests (26)Click to expandClass TestPairingSyncMultipleDevicesMerged:
Class TestPublicChatBrowserOneDeviceMerged:
Class TestSendTxDeviceMerged:
Class TestEnsStickersMultipleDevicesMerged:
Class TestContactBlockMigrateKeycardMultipleSharedDevices:
Class TestOnboardingOneDeviceMerged:
|
8d21262
to
f60a5e0
Compare
f60a5e0
to
45e47ad
Compare
fixes #13804
Areas that may be impacted
status: ready