issue-13832: Implement account selector in manage app connection and persist when offline #13883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (191)
|
ibrkhalil
changed the title
flexsurfer
requested changes
Aug 30, 2022
flexsurfer
approved these changes
Aug 31, 2022
91% of end-end tests have passedFailed tests (8)Click to expandClass TestKeycardTxOneDeviceMerged:
Class TestCommandsMultipleDevicesMerged:
Class TestContactBlockMigrateKeycardMultipleSharedDevices:
Class TestSendTxDeviceMerged:
Class TestEnsStickersMultipleDevicesMerged:
Passed tests (79)Click to expandClass TestOneToOneChatMultipleSharedDevices:
Class TestSendTxDeviceMerged:
Class TestPublicChatMultipleDeviceMerged:
Class TestPublicChatBrowserOneDeviceMerged:
Class TestKeycardTxOneDeviceMerged:
Class TestPairingSyncMultipleDevicesMerged:
Class TestGroupChatMultipleDeviceMerged:
Class TestContactBlockMigrateKeycardMultipleSharedDevices:
Class TestOnboardingOneDeviceMerged:
Class TestWalletManagementDeviceMerged:
Class TestRestoreOneDeviceMerged:
Class TestEnsStickersMultipleDevicesMerged:
|
100% of end-end tests have passedPassed tests (8)Click to expandClass TestSendTxDeviceMerged:
Class TestCommandsMultipleDevicesMerged:
Class TestEnsStickersMultipleDevicesMerged:
Class TestContactBlockMigrateKeycardMultipleSharedDevices:
Class TestKeycardTxOneDeviceMerged:
|
|
@ibrkhalil thanx for the PR. Please take a look at the following issue Selected account is always being reset to the primary chosen account after re-loginPreconditions: User has 2 or more wallets within his account. Steps:
Actual result: primary selected Account 1 is selected telegram-cloud-document-2-5240492011068333736.mp4Expected result: the last selected Account 2 should be elected |
|
@ibrkhalil also, could you please rebase the branch to the latest develop? Thanx! |
ibrkhalil
force-pushed
the
issue-13832
branch
from
2919cbd
to
5d6b4c8
Compare
Done, Both .. Please check when you have time |
99% of end-end tests have passedFailed tests (1)Click to expandClass TestPublicChatBrowserOneDeviceMerged:
Passed tests (86)Click to expandClass TestPublicChatBrowserOneDeviceMerged:
Class TestPairingSyncMultipleDevicesMerged:
Class TestOneToOneChatMultipleSharedDevices:
Class TestEnsStickersMultipleDevicesMerged:
Class TestContactBlockMigrateKeycardMultipleSharedDevices:
Class TestCommandsMultipleDevicesMerged:
Class TestRestoreOneDeviceMerged:
Class TestKeycardTxOneDeviceMerged:
Class TestSendTxDeviceMerged:
Class TestWalletManagementDeviceMerged:
Class TestGroupChatMultipleDeviceMerged:
Class TestOnboardingOneDeviceMerged:
Class TestPublicChatMultipleDeviceMerged:
|
100% of end-end tests have passedPassed tests (1)Click to expandClass TestPublicChatBrowserOneDeviceMerged:
|
|
@ibrkhalil thank you! ISSUE 1 is fixed. Please take a look at new ISSUE 2 ISSUE 2 Switching between 3 different accounts while offline results in displaying second selected account on the side of connected dapp after coming back online instead of last selected accountPreconditions: User has 3 different accounts (for example Account 1, Account 2, Account 3) Steps:
Actual result: Account 3 is displayed as connected telegram-cloud-document-2-5244865271323172867.mp4Expected result: Account 1 is displayed as connected |
ibrkhalil
force-pushed
the
issue-13832
branch
from
47f0ac4
to
3e6563d
Compare
|
After Pairing with @J-Son89 and @flexsurfer .. that we need to check on when internet connection is working properly on iOS to dispatch the sync wallet connect issue |
After chatting @flexsurfer, We're going to check this event as the status-go endpoint is getting returned correctly but maybe is not used correctly |
ibrkhalil
force-pushed
the
issue-13832
branch
4 times, most recently
from
c367ce6
to
f1d91ff
Compare
99% of end-end tests have passedFailed tests (1)Click to expandClass TestEnsStickersMultipleDevicesMerged:
Passed tests (86)Click to expandClass TestSendTxDeviceMerged:
Class TestContactBlockMigrateKeycardMultipleSharedDevices:
Class TestOneToOneChatMultipleSharedDevices:
Class TestEnsStickersMultipleDevicesMerged:
Class TestPairingSyncMultipleDevicesMerged:
Class TestPublicChatBrowserOneDeviceMerged:
Class TestWalletManagementDeviceMerged:
Class TestGroupChatMultipleDeviceMerged:
Class TestCommandsMultipleDevicesMerged:
Class TestOnboardingOneDeviceMerged:
Class TestRestoreOneDeviceMerged:
Class TestKeycardTxOneDeviceMerged:
Class TestPublicChatMultipleDeviceMerged:
|
100% of end-end tests have passedPassed tests (1)Click to expandClass TestEnsStickersMultipleDevicesMerged:
|
|
@ibrkhalil Thank you for fixes. ISSUE 4 and ISSUE 5 are not reproducible any more on IOS. At the same time, I am still reproducing ISSUE 2 on IOS. |
Fixed, Kindly check when you have time Pavlo .. Thanks |
100% of end-end tests have passedPassed tests (87)Click to expandClass TestPublicChatMultipleDeviceMerged:
Class TestPublicChatBrowserOneDeviceMerged:
Class TestRestoreOneDeviceMerged:
Class TestOnboardingOneDeviceMerged:
Class TestWalletManagementDeviceMerged:
Class TestSendTxDeviceMerged:
Class TestPairingSyncMultipleDevicesMerged:
Class TestContactBlockMigrateKeycardMultipleSharedDevices:
Class TestGroupChatMultipleDeviceMerged:
Class TestCommandsMultipleDevicesMerged:
Class TestEnsStickersMultipleDevicesMerged:
Class TestKeycardTxOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevices:
|
|
@ibrkhalil Thank you for fixes. Currently, ISSUE 2 is not reproducible any more on IOS. But, ISSUE 4 and ISSUE 5 are again reproducible for BOTH Android and IOS after the last fix. telegram-cloud-document-2-5343576762385178704.mp4 |
|
hey @ibrkhalil still relevant ? |
Yes Andrey, It's a bug with the account switcher and it was required in the previous release .. Will pick it up again later |
|
stale, feel free to reopen later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #13832
Summary
Areas that maybe impacted
Wallet connect
Functional
Steps to test
status: ready