-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix can't remove node 0 error breaking react-devtools #14316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins Builds
|
flexsurfer
approved these changes
Nov 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
You can now use the layout inspector in [flipper](https://fbflipper.com/docs/features/plugins/inspector/) now
yqrashawn
force-pushed
the
fix/react-devtool
branch
from
November 10, 2022 08:13
6338a75
to
8f66066
Compare
67% of end-end tests have passed
Not executed tests (1)Failed tests (2)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Passed tests (4)Click to expandClass TestDeeplinkOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
Seems remote debugging is not possible due to react-native-reanimated v2.x facebook/metro#731 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can now use the layout inspector in flipper now
Note:
4.6.0
to4.26.1(^4.26.0)
, there're lots of changes.yarn why react-devtools-core
indicating it's required byreact-native
4.24.6
status: ready