Group details screen 3.2 #14631
Group details screen 3.2 #14631
Conversation
Jenkins BuildsClick to see older builds (8)
|
| @@ -1,27 +1,27 @@ | |||
| (ns status-im2.contexts.chat.messages.view | |||
There was a problem hiding this comment.
this namespace still reverted
There was a problem hiding this comment.
@flexsurfer reverted this file. As for the formatting, I keep running make lint-fix but I am not sure if it formatting the files correctly
There was a problem hiding this comment.
yeah i think it doesn't work, it didn't work for me as well you should run zprint for each file manually, what IDE do you use ?
There was a problem hiding this comment.
@flexsurfer I use IntelliJ
There was a problem hiding this comment.
develop...45231b1
This one is better, but still some, I guess, unrelated diff. Which one is last commit before trying to rebase against upstream, with that commit, I can get to the minimum diff
There was a problem hiding this comment.
@yqrashawn this is the last one before so many files got reformatted 68080de
But why is clojure-lsp clean-ns messing up the formatting. If it was already formatted correctly then it shouldn't change anything right?
Also currently when running make lint-fix is doesn't really fix all the formatting of the changed files as shown in this other PR: #14635
There was a problem hiding this comment.
clojure-lsp clean-ns and zprint currently conflict with each other when formatting ns form, so it's required to run zprint after clojure-lsp
I'll create a pr to tweak zprint's rule for ns forms
make lint-fix only applies to file staged (git add) in git git diff --diff-filter=d --cached --name-only
There was a problem hiding this comment.
make lint-fixonly applies to file staged (git add) in gitgit diff --diff-filter=d --cached --name-only
oh that's good to know
There was a problem hiding this comment.
Oh, I just found that this is not the old way. The old make lint-fix will fix everything in src. I'll fix this soon.
Reverting some files from that PR: #14494