feat: group details screen (3.3) #14654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmarBasem
changed the title
Jenkins BuildsClick to see older builds (20)
|
OmarBasem
force-pushed
the
group-details-screen-3.3
branch
from
13b5fcc
to
fb145f4
Compare
|
@flexsurfer I have created another PR. I think it's all fixed now. |
flexsurfer
reviewed
Dec 28, 2022
| :padding-vertical 12 | ||
| :padding-bottom 33 | ||
| :padding-bottom (+ 33 (if platform/ios? (:bottom safe-area) 0)) |
| safe-area (safe-area/use-safe-area) | ||
| selected-participants (rf/sub [:group-chat/selected-participants]) | ||
| deselected-members (rf/sub [:group-chat/deselected-members])] | ||
| [rn/view {:style {:height (- window-height (:top safe-area))}} |
There was a problem hiding this comment.
something wrong is here ,we shouldn't use height , and safe area is applied to all screens by default , so we shouldn't care about them in the screen itself
There was a problem hiding this comment.
That's a bottom sheet not a screen
| @@ -1,11 +1,9 @@ | |||
| (ns status-im.ui2.screens.chat.group-details.view | |||
There was a problem hiding this comment.
just wondering why we still make changes in ui2 namespace, can we move to status-im2 ?
There was a problem hiding this comment.
Moved to status-im2
OmarBasem
requested review from
flexsurfer
and removed request for
flexsurfer
|
@flexsurfer why keep the PR hanging? It keeps getting conflicts.. |
what do you mean by keep the PR hanging? |
flexsurfer
approved these changes
Dec 30, 2022
OmarBasem
force-pushed
the
group-details-screen-3.3
branch
from
5419212
to
d7a8d5e
Compare
I mean not allowing the PR to move forward when it is complete |
OmarBasem
force-pushed
the
group-details-screen-3.3
branch
from
61d6add
to
3691aef
Compare
mattgle
pushed a commit
to mattgle/status-mobile
that referenced
this pull request
Dec 30, 2022
* feat: group details screen (3)
mattgle
pushed a commit
to mattgle/status-mobile
that referenced
this pull request
Dec 30, 2022
* feat: group details screen (3)
mattgle
pushed a commit
to mattgle/status-mobile
that referenced
this pull request
Dec 31, 2022
* feat: group details screen (3)
mattgle
pushed a commit
to mattgle/status-mobile
that referenced
this pull request
Dec 31, 2022
* feat: group details screen (3)
mattgle
pushed a commit
to mattgle/status-mobile
that referenced
this pull request
Jan 2, 2023
* feat: group details screen (3)
mattgle
pushed a commit
to mattgle/status-mobile
that referenced
this pull request
Jan 2, 2023
* feat: group details screen (3)
mattgle
added a commit
to mattgle/status-mobile
that referenced
this pull request
Jan 2, 2023
Fix issue with preview text filed, now the text is white in the text-filed when the theme is dark Add necessary assets and edit icon.clj to accept 48x48 images Fix button issue, pressed background missing height Fix corrections, delete TODOs, use new assets run make lint-fix after updating branch Delete useless style Requested changes from PR: change colors, extract profile_card component, small css changes, added new option to remove emoji-hash New chat flow (status-im#14607) Delete useless icons, use i:/options instead of more Change keycard image, change user-avatar to make it work with resources images, improve styles, tested on android feat: group details screen (3.3) (status-im#14654) * feat: group details screen (3) Add show-emoji-hash to fix keys issues and better preview Add eof and delete useless file New chat flow (status-im#14607) fix conflict at rebasing New chat flow (status-im#14607) feat: group details screen (3.3) (status-im#14654) * feat: group details screen (3) Delete useless change, probably error while rebasing Delete ring implementation for 48px
mattgle
added a commit
to mattgle/status-mobile
that referenced
this pull request
Jan 2, 2023
Fix issue with preview text filed, now the text is white in the text-filed when the theme is dark Add necessary assets and edit icon.clj to accept 48x48 images Fix button issue, pressed background missing height Fix corrections, delete TODOs, use new assets run make lint-fix after updating branch Delete useless style Requested changes from PR: change colors, extract profile_card component, small css changes, added new option to remove emoji-hash New chat flow (status-im#14607) Delete useless icons, use i:/options instead of more Change keycard image, change user-avatar to make it work with resources images, improve styles, tested on android feat: group details screen (3.3) (status-im#14654) * feat: group details screen (3) Add show-emoji-hash to fix keys issues and better preview Add eof and delete useless file New chat flow (status-im#14607) fix conflict at rebasing New chat flow (status-im#14607) feat: group details screen (3.3) (status-im#14654) * feat: group details screen (3) Delete useless change, probably error while rebasing Delete ring implementation for 48px Change files location to the correct place delete empty space and change imports Fix building problem because of imports
mattgle
added a commit
to mattgle/status-mobile
that referenced
this pull request
Jan 2, 2023
Fix issue with preview text filed, now the text is white in the text-filed when the theme is dark Add necessary assets and edit icon.clj to accept 48x48 images Fix button issue, pressed background missing height Fix corrections, delete TODOs, use new assets run make lint-fix after updating branch Delete useless style Requested changes from PR: change colors, extract profile_card component, small css changes, added new option to remove emoji-hash New chat flow (status-im#14607) Delete useless icons, use i:/options instead of more Change keycard image, change user-avatar to make it work with resources images, improve styles, tested on android feat: group details screen (3.3) (status-im#14654) * feat: group details screen (3) Add show-emoji-hash to fix keys issues and better preview Add eof and delete useless file New chat flow (status-im#14607) fix conflict at rebasing New chat flow (status-im#14607) feat: group details screen (3.3) (status-im#14654) * feat: group details screen (3) Delete useless change, probably error while rebasing Delete ring implementation for 48px Change files location to the correct place delete empty space and change imports Fix building problem because of imports Removed a modified file from pull request
mattgle
added a commit
to mattgle/status-mobile
that referenced
this pull request
Jan 2, 2023
Fix issue with preview text filed, now the text is white in the text-filed when the theme is dark Add necessary assets and edit icon.clj to accept 48x48 images Fix button issue, pressed background missing height Fix corrections, delete TODOs, use new assets run make lint-fix after updating branch Delete useless style Requested changes from PR: change colors, extract profile_card component, small css changes, added new option to remove emoji-hash New chat flow (status-im#14607) Delete useless icons, use i:/options instead of more Change keycard image, change user-avatar to make it work with resources images, improve styles, tested on android feat: group details screen (3.3) (status-im#14654) * feat: group details screen (3) Add show-emoji-hash to fix keys issues and better preview Add eof and delete useless file New chat flow (status-im#14607) fix conflict at rebasing New chat flow (status-im#14607) feat: group details screen (3.3) (status-im#14654) * feat: group details screen (3) Delete useless change, probably error while rebasing Delete ring implementation for 48px Change files location to the correct place delete empty space and change imports Fix building problem because of imports Removed a modified file from pull request Reply showing unknown (status-im#14682)
mattgle
added a commit
to mattgle/status-mobile
that referenced
this pull request
Jan 2, 2023
Fix issue with preview text filed, now the text is white in the text-filed when the theme is dark Add necessary assets and edit icon.clj to accept 48x48 images Fix button issue, pressed background missing height Fix corrections, delete TODOs, use new assets run make lint-fix after updating branch Delete useless style Requested changes from PR: change colors, extract profile_card component, small css changes, added new option to remove emoji-hash New chat flow (status-im#14607) Delete useless icons, use i:/options instead of more Change keycard image, change user-avatar to make it work with resources images, improve styles, tested on android feat: group details screen (3.3) (status-im#14654) * feat: group details screen (3) Add show-emoji-hash to fix keys issues and better preview Add eof and delete useless file New chat flow (status-im#14607) fix conflict at rebasing New chat flow (status-im#14607) feat: group details screen (3.3) (status-im#14654) * feat: group details screen (3) Delete useless change, probably error while rebasing Delete ring implementation for 48px Change files location to the correct place delete empty space and change imports Fix building problem because of imports Removed a modified file from pull request Reply showing unknown (status-im#14682) Reply showing unknown (status-im#14682)
mattgle
added a commit
to mattgle/status-mobile
that referenced
this pull request
Jan 2, 2023
Fix issue with preview text filed, now the text is white in the text-filed when the theme is dark Add necessary assets and edit icon.clj to accept 48x48 images Fix button issue, pressed background missing height Fix corrections, delete TODOs, use new assets run make lint-fix after updating branch Delete useless style Requested changes from PR: change colors, extract profile_card component, small css changes, added new option to remove emoji-hash New chat flow (status-im#14607) Delete useless icons, use i:/options instead of more Change keycard image, change user-avatar to make it work with resources images, improve styles, tested on android feat: group details screen (3.3) (status-im#14654) * feat: group details screen (3) Add show-emoji-hash to fix keys issues and better preview Add eof and delete useless file New chat flow (status-im#14607) fix conflict at rebasing New chat flow (status-im#14607) feat: group details screen (3.3) (status-im#14654) * feat: group details screen (3) Delete useless change, probably error while rebasing Delete ring implementation for 48px Change files location to the correct place delete empty space and change imports Fix building problem because of imports Removed a modified file from pull request Reply showing unknown (status-im#14682) Reply showing unknown (status-im#14682)
mattgle
added a commit
to mattgle/status-mobile
that referenced
this pull request
Jan 3, 2023
Fix issue with preview text filed, now the text is white in the text-filed when the theme is dark Add necessary assets and edit icon.clj to accept 48x48 images Fix button issue, pressed background missing height Fix corrections, delete TODOs, use new assets run make lint-fix after updating branch Delete useless style Requested changes from PR: change colors, extract profile_card component, small css changes, added new option to remove emoji-hash New chat flow (status-im#14607) Delete useless icons, use i:/options instead of more Change keycard image, change user-avatar to make it work with resources images, improve styles, tested on android feat: group details screen (3.3) (status-im#14654) * feat: group details screen (3) Add show-emoji-hash to fix keys issues and better preview Add eof and delete useless file New chat flow (status-im#14607) fix conflict at rebasing New chat flow (status-im#14607) feat: group details screen (3.3) (status-im#14654) * feat: group details screen (3) Delete useless change, probably error while rebasing Delete ring implementation for 48px Change files location to the correct place delete empty space and change imports Fix building problem because of imports Removed a modified file from pull request Reply showing unknown (status-im#14682) Reply showing unknown (status-im#14682)
mattgle
added a commit
to mattgle/status-mobile
that referenced
this pull request
Jan 3, 2023
Fix issue with preview text filed, now the text is white in the text-filed when the theme is dark Add necessary assets and edit icon.clj to accept 48x48 images Fix button issue, pressed background missing height Fix corrections, delete TODOs, use new assets run make lint-fix after updating branch Delete useless style Requested changes from PR: change colors, extract profile_card component, small css changes, added new option to remove emoji-hash New chat flow (status-im#14607) Delete useless icons, use i:/options instead of more Change keycard image, change user-avatar to make it work with resources images, improve styles, tested on android feat: group details screen (3.3) (status-im#14654) * feat: group details screen (3) Add show-emoji-hash to fix keys issues and better preview Add eof and delete useless file New chat flow (status-im#14607) fix conflict at rebasing New chat flow (status-im#14607) feat: group details screen (3.3) (status-im#14654) * feat: group details screen (3) Delete useless change, probably error while rebasing Delete ring implementation for 48px Change files location to the correct place delete empty space and change imports Fix building problem because of imports Removed a modified file from pull request Reply showing unknown (status-im#14682) Reply showing unknown (status-im#14682) Replace icons for the ones in iconset, make profile_card color customizable, fix button background
mattgle
added a commit
to mattgle/status-mobile
that referenced
this pull request
Jan 3, 2023
Fix issue with preview text filed, now the text is white in the text-filed when the theme is dark Add necessary assets and edit icon.clj to accept 48x48 images Fix button issue, pressed background missing height Fix corrections, delete TODOs, use new assets run make lint-fix after updating branch Delete useless style Requested changes from PR: change colors, extract profile_card component, small css changes, added new option to remove emoji-hash New chat flow (status-im#14607) Delete useless icons, use i:/options instead of more Change keycard image, change user-avatar to make it work with resources images, improve styles, tested on android feat: group details screen (3.3) (status-im#14654) * feat: group details screen (3) Add show-emoji-hash to fix keys issues and better preview Add eof and delete useless file New chat flow (status-im#14607) fix conflict at rebasing New chat flow (status-im#14607) feat: group details screen (3.3) (status-im#14654) * feat: group details screen (3) Delete useless change, probably error while rebasing Delete ring implementation for 48px Change files location to the correct place delete empty space and change imports Fix building problem because of imports Removed a modified file from pull request Reply showing unknown (status-im#14682) Reply showing unknown (status-im#14682) Replace icons for the ones in iconset, make profile_card color customizable, fix button background run lint-fix
mattgle
added a commit
to mattgle/status-mobile
that referenced
this pull request
Jan 3, 2023
Fix issue with preview text filed, now the text is white in the text-filed when the theme is dark Add necessary assets and edit icon.clj to accept 48x48 images Fix button issue, pressed background missing height Fix corrections, delete TODOs, use new assets run make lint-fix after updating branch Delete useless style Requested changes from PR: change colors, extract profile_card component, small css changes, added new option to remove emoji-hash New chat flow (status-im#14607) Delete useless icons, use i:/options instead of more Change keycard image, change user-avatar to make it work with resources images, improve styles, tested on android feat: group details screen (3.3) (status-im#14654) * feat: group details screen (3) Add show-emoji-hash to fix keys issues and better preview Add eof and delete useless file New chat flow (status-im#14607) fix conflict at rebasing New chat flow (status-im#14607) feat: group details screen (3.3) (status-im#14654) * feat: group details screen (3) Delete useless change, probably error while rebasing Delete ring implementation for 48px Change files location to the correct place delete empty space and change imports Fix building problem because of imports Removed a modified file from pull request Reply showing unknown (status-im#14682) Reply showing unknown (status-im#14682) Replace icons for the ones in iconset, make profile_card color customizable, fix button background run lint-fix
mattgle
added a commit
to mattgle/status-mobile
that referenced
this pull request
Jan 3, 2023
Fix issue with preview text filed, now the text is white in the text-filed when the theme is dark Add necessary assets and edit icon.clj to accept 48x48 images Fix button issue, pressed background missing height Fix corrections, delete TODOs, use new assets run make lint-fix after updating branch Delete useless style Requested changes from PR: change colors, extract profile_card component, small css changes, added new option to remove emoji-hash New chat flow (status-im#14607) Delete useless icons, use i:/options instead of more Change keycard image, change user-avatar to make it work with resources images, improve styles, tested on android feat: group details screen (3.3) (status-im#14654) * feat: group details screen (3) Add show-emoji-hash to fix keys issues and better preview Add eof and delete useless file New chat flow (status-im#14607) fix conflict at rebasing New chat flow (status-im#14607) feat: group details screen (3.3) (status-im#14654) * feat: group details screen (3) Delete useless change, probably error while rebasing Delete ring implementation for 48px Change files location to the correct place delete empty space and change imports Fix building problem because of imports Removed a modified file from pull request Reply showing unknown (status-im#14682) Reply showing unknown (status-im#14682) Replace icons for the ones in iconset, make profile_card color customizable, fix button background run lint-fix Add sign button label
cammellos
reviewed
Jan 5, 2023
| @@ -93,21 +93,20 @@ | |||
| vals))) | |||
|
|
|||
| (re-frame/reg-sub | |||
| :contacts/sorted-and-grouped-by-first-letter | |||
There was a problem hiding this comment.
This is still used in some parts of the codebase in develop, and it's currently throwing an error, why has it been removed? is there a replacement to be used or is just a mistake?
There was a problem hiding this comment.
@flexsurfer I think you shared with me the implementation of this method? Did you rename it by mistake?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting some files from that PR: #14494