-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: group details screen (3.3) #14654
Conversation
Jenkins BuildsClick to see older builds (20)
|
13b5fcc
to
fb145f4
Compare
@flexsurfer I have created another PR. I think it's all fixed now. |
:padding-vertical 12 | ||
:padding-bottom 33 | ||
:padding-bottom (+ 33 (if platform/ios? (:bottom safe-area) 0)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why only ios ?
safe-area (safe-area/use-safe-area) | ||
selected-participants (rf/sub [:group-chat/selected-participants]) | ||
deselected-members (rf/sub [:group-chat/deselected-members])] | ||
[rn/view {:style {:height (- window-height (:top safe-area))}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
something wrong is here ,we shouldn't use height , and safe area is applied to all screens by default , so we shouldn't care about them in the screen itself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a bottom sheet not a screen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mhm
@@ -1,11 +1,9 @@ | |||
(ns status-im.ui2.screens.chat.group-details.view |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just wondering why we still make changes in ui2 namespace, can we move to status-im2 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved to status-im2
@flexsurfer why keep the PR hanging? It keeps getting conflicts.. |
what do you mean by keep the PR hanging? |
5419212
to
d7a8d5e
Compare
I mean not allowing the PR to move forward when it is complete |
61d6add
to
3691aef
Compare
* feat: group details screen (3)
* feat: group details screen (3)
* feat: group details screen (3)
* feat: group details screen (3)
* feat: group details screen (3)
* feat: group details screen (3)
Fix issue with preview text filed, now the text is white in the text-filed when the theme is dark Add necessary assets and edit icon.clj to accept 48x48 images Fix button issue, pressed background missing height Fix corrections, delete TODOs, use new assets run make lint-fix after updating branch Delete useless style Requested changes from PR: change colors, extract profile_card component, small css changes, added new option to remove emoji-hash New chat flow (status-im#14607) Delete useless icons, use i:/options instead of more Change keycard image, change user-avatar to make it work with resources images, improve styles, tested on android feat: group details screen (3.3) (status-im#14654) * feat: group details screen (3) Add show-emoji-hash to fix keys issues and better preview Add eof and delete useless file New chat flow (status-im#14607) fix conflict at rebasing New chat flow (status-im#14607) feat: group details screen (3.3) (status-im#14654) * feat: group details screen (3) Delete useless change, probably error while rebasing Delete ring implementation for 48px
Fix issue with preview text filed, now the text is white in the text-filed when the theme is dark Add necessary assets and edit icon.clj to accept 48x48 images Fix button issue, pressed background missing height Fix corrections, delete TODOs, use new assets run make lint-fix after updating branch Delete useless style Requested changes from PR: change colors, extract profile_card component, small css changes, added new option to remove emoji-hash New chat flow (status-im#14607) Delete useless icons, use i:/options instead of more Change keycard image, change user-avatar to make it work with resources images, improve styles, tested on android feat: group details screen (3.3) (status-im#14654) * feat: group details screen (3) Add show-emoji-hash to fix keys issues and better preview Add eof and delete useless file New chat flow (status-im#14607) fix conflict at rebasing New chat flow (status-im#14607) feat: group details screen (3.3) (status-im#14654) * feat: group details screen (3) Delete useless change, probably error while rebasing Delete ring implementation for 48px Change files location to the correct place delete empty space and change imports Fix building problem because of imports
Fix issue with preview text filed, now the text is white in the text-filed when the theme is dark Add necessary assets and edit icon.clj to accept 48x48 images Fix button issue, pressed background missing height Fix corrections, delete TODOs, use new assets run make lint-fix after updating branch Delete useless style Requested changes from PR: change colors, extract profile_card component, small css changes, added new option to remove emoji-hash New chat flow (status-im#14607) Delete useless icons, use i:/options instead of more Change keycard image, change user-avatar to make it work with resources images, improve styles, tested on android feat: group details screen (3.3) (status-im#14654) * feat: group details screen (3) Add show-emoji-hash to fix keys issues and better preview Add eof and delete useless file New chat flow (status-im#14607) fix conflict at rebasing New chat flow (status-im#14607) feat: group details screen (3.3) (status-im#14654) * feat: group details screen (3) Delete useless change, probably error while rebasing Delete ring implementation for 48px Change files location to the correct place delete empty space and change imports Fix building problem because of imports Removed a modified file from pull request
Fix issue with preview text filed, now the text is white in the text-filed when the theme is dark Add necessary assets and edit icon.clj to accept 48x48 images Fix button issue, pressed background missing height Fix corrections, delete TODOs, use new assets run make lint-fix after updating branch Delete useless style Requested changes from PR: change colors, extract profile_card component, small css changes, added new option to remove emoji-hash New chat flow (status-im#14607) Delete useless icons, use i:/options instead of more Change keycard image, change user-avatar to make it work with resources images, improve styles, tested on android feat: group details screen (3.3) (status-im#14654) * feat: group details screen (3) Add show-emoji-hash to fix keys issues and better preview Add eof and delete useless file New chat flow (status-im#14607) fix conflict at rebasing New chat flow (status-im#14607) feat: group details screen (3.3) (status-im#14654) * feat: group details screen (3) Delete useless change, probably error while rebasing Delete ring implementation for 48px Change files location to the correct place delete empty space and change imports Fix building problem because of imports Removed a modified file from pull request Reply showing unknown (status-im#14682)
Fix issue with preview text filed, now the text is white in the text-filed when the theme is dark Add necessary assets and edit icon.clj to accept 48x48 images Fix button issue, pressed background missing height Fix corrections, delete TODOs, use new assets run make lint-fix after updating branch Delete useless style Requested changes from PR: change colors, extract profile_card component, small css changes, added new option to remove emoji-hash New chat flow (status-im#14607) Delete useless icons, use i:/options instead of more Change keycard image, change user-avatar to make it work with resources images, improve styles, tested on android feat: group details screen (3.3) (status-im#14654) * feat: group details screen (3) Add show-emoji-hash to fix keys issues and better preview Add eof and delete useless file New chat flow (status-im#14607) fix conflict at rebasing New chat flow (status-im#14607) feat: group details screen (3.3) (status-im#14654) * feat: group details screen (3) Delete useless change, probably error while rebasing Delete ring implementation for 48px Change files location to the correct place delete empty space and change imports Fix building problem because of imports Removed a modified file from pull request Reply showing unknown (status-im#14682) Reply showing unknown (status-im#14682)
Fix issue with preview text filed, now the text is white in the text-filed when the theme is dark Add necessary assets and edit icon.clj to accept 48x48 images Fix button issue, pressed background missing height Fix corrections, delete TODOs, use new assets run make lint-fix after updating branch Delete useless style Requested changes from PR: change colors, extract profile_card component, small css changes, added new option to remove emoji-hash New chat flow (status-im#14607) Delete useless icons, use i:/options instead of more Change keycard image, change user-avatar to make it work with resources images, improve styles, tested on android feat: group details screen (3.3) (status-im#14654) * feat: group details screen (3) Add show-emoji-hash to fix keys issues and better preview Add eof and delete useless file New chat flow (status-im#14607) fix conflict at rebasing New chat flow (status-im#14607) feat: group details screen (3.3) (status-im#14654) * feat: group details screen (3) Delete useless change, probably error while rebasing Delete ring implementation for 48px Change files location to the correct place delete empty space and change imports Fix building problem because of imports Removed a modified file from pull request Reply showing unknown (status-im#14682) Reply showing unknown (status-im#14682)
Fix issue with preview text filed, now the text is white in the text-filed when the theme is dark Add necessary assets and edit icon.clj to accept 48x48 images Fix button issue, pressed background missing height Fix corrections, delete TODOs, use new assets run make lint-fix after updating branch Delete useless style Requested changes from PR: change colors, extract profile_card component, small css changes, added new option to remove emoji-hash New chat flow (status-im#14607) Delete useless icons, use i:/options instead of more Change keycard image, change user-avatar to make it work with resources images, improve styles, tested on android feat: group details screen (3.3) (status-im#14654) * feat: group details screen (3) Add show-emoji-hash to fix keys issues and better preview Add eof and delete useless file New chat flow (status-im#14607) fix conflict at rebasing New chat flow (status-im#14607) feat: group details screen (3.3) (status-im#14654) * feat: group details screen (3) Delete useless change, probably error while rebasing Delete ring implementation for 48px Change files location to the correct place delete empty space and change imports Fix building problem because of imports Removed a modified file from pull request Reply showing unknown (status-im#14682) Reply showing unknown (status-im#14682)
Fix issue with preview text filed, now the text is white in the text-filed when the theme is dark Add necessary assets and edit icon.clj to accept 48x48 images Fix button issue, pressed background missing height Fix corrections, delete TODOs, use new assets run make lint-fix after updating branch Delete useless style Requested changes from PR: change colors, extract profile_card component, small css changes, added new option to remove emoji-hash New chat flow (status-im#14607) Delete useless icons, use i:/options instead of more Change keycard image, change user-avatar to make it work with resources images, improve styles, tested on android feat: group details screen (3.3) (status-im#14654) * feat: group details screen (3) Add show-emoji-hash to fix keys issues and better preview Add eof and delete useless file New chat flow (status-im#14607) fix conflict at rebasing New chat flow (status-im#14607) feat: group details screen (3.3) (status-im#14654) * feat: group details screen (3) Delete useless change, probably error while rebasing Delete ring implementation for 48px Change files location to the correct place delete empty space and change imports Fix building problem because of imports Removed a modified file from pull request Reply showing unknown (status-im#14682) Reply showing unknown (status-im#14682) Replace icons for the ones in iconset, make profile_card color customizable, fix button background
Fix issue with preview text filed, now the text is white in the text-filed when the theme is dark Add necessary assets and edit icon.clj to accept 48x48 images Fix button issue, pressed background missing height Fix corrections, delete TODOs, use new assets run make lint-fix after updating branch Delete useless style Requested changes from PR: change colors, extract profile_card component, small css changes, added new option to remove emoji-hash New chat flow (status-im#14607) Delete useless icons, use i:/options instead of more Change keycard image, change user-avatar to make it work with resources images, improve styles, tested on android feat: group details screen (3.3) (status-im#14654) * feat: group details screen (3) Add show-emoji-hash to fix keys issues and better preview Add eof and delete useless file New chat flow (status-im#14607) fix conflict at rebasing New chat flow (status-im#14607) feat: group details screen (3.3) (status-im#14654) * feat: group details screen (3) Delete useless change, probably error while rebasing Delete ring implementation for 48px Change files location to the correct place delete empty space and change imports Fix building problem because of imports Removed a modified file from pull request Reply showing unknown (status-im#14682) Reply showing unknown (status-im#14682) Replace icons for the ones in iconset, make profile_card color customizable, fix button background run lint-fix
Fix issue with preview text filed, now the text is white in the text-filed when the theme is dark Add necessary assets and edit icon.clj to accept 48x48 images Fix button issue, pressed background missing height Fix corrections, delete TODOs, use new assets run make lint-fix after updating branch Delete useless style Requested changes from PR: change colors, extract profile_card component, small css changes, added new option to remove emoji-hash New chat flow (status-im#14607) Delete useless icons, use i:/options instead of more Change keycard image, change user-avatar to make it work with resources images, improve styles, tested on android feat: group details screen (3.3) (status-im#14654) * feat: group details screen (3) Add show-emoji-hash to fix keys issues and better preview Add eof and delete useless file New chat flow (status-im#14607) fix conflict at rebasing New chat flow (status-im#14607) feat: group details screen (3.3) (status-im#14654) * feat: group details screen (3) Delete useless change, probably error while rebasing Delete ring implementation for 48px Change files location to the correct place delete empty space and change imports Fix building problem because of imports Removed a modified file from pull request Reply showing unknown (status-im#14682) Reply showing unknown (status-im#14682) Replace icons for the ones in iconset, make profile_card color customizable, fix button background run lint-fix
Fix issue with preview text filed, now the text is white in the text-filed when the theme is dark Add necessary assets and edit icon.clj to accept 48x48 images Fix button issue, pressed background missing height Fix corrections, delete TODOs, use new assets run make lint-fix after updating branch Delete useless style Requested changes from PR: change colors, extract profile_card component, small css changes, added new option to remove emoji-hash New chat flow (status-im#14607) Delete useless icons, use i:/options instead of more Change keycard image, change user-avatar to make it work with resources images, improve styles, tested on android feat: group details screen (3.3) (status-im#14654) * feat: group details screen (3) Add show-emoji-hash to fix keys issues and better preview Add eof and delete useless file New chat flow (status-im#14607) fix conflict at rebasing New chat flow (status-im#14607) feat: group details screen (3.3) (status-im#14654) * feat: group details screen (3) Delete useless change, probably error while rebasing Delete ring implementation for 48px Change files location to the correct place delete empty space and change imports Fix building problem because of imports Removed a modified file from pull request Reply showing unknown (status-im#14682) Reply showing unknown (status-im#14682) Replace icons for the ones in iconset, make profile_card color customizable, fix button background run lint-fix Add sign button label
@@ -93,21 +93,20 @@ | |||
vals))) | |||
|
|||
(re-frame/reg-sub | |||
:contacts/sorted-and-grouped-by-first-letter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still used in some parts of the codebase in develop, and it's currently throwing an error, why has it been removed? is there a replacement to be used or is just a mistake?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@flexsurfer I think you shared with me the implementation of this method? Did you rename it by mistake?
Reverting some files from that PR: #14494