[WIP] React native upgrade from version 0.63.3 to 0.71.4 ? #15203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddarthkay
force-pushed
the
react-native-upgrade-68
branch
from
689e06d
to
c2b1ed1
Compare
Jenkins BuildsClick to see older builds (346)
|
siddarthkay
force-pushed
the
react-native-upgrade-68
branch
from
3c17390
to
9011487
Compare
|
known side effect on IOS Side : #15206 |
|
Looks like the JAR for AAPT2 now also includes a Which would cause the derivation to try to status-mobile/nix/pkgs/aapt2/default.nix Lines 73 to 76 in e016185 Easy fix. |
siddarthkay
force-pushed
the
react-native-upgrade-68
branch
from
d69277e
to
d4df4a5
Compare
jakubgs
force-pushed
the
react-native-upgrade-68
branch
from
8bc5bf6
to
6a45df5
Compare
|
Seems to me like this error: Means that Gradle is not looking for the plugin files in Nix store. Which can mean at least two of those things:
Which would mean that either:
Which means either we have to point it to the right path, or provide plugins in some alternative way. |
siddarthkay
force-pushed
the
react-native-upgrade-68
branch
2 times, most recently
from
9767fc5
to
41e8964
Compare
19 tasks
|
According to the docs:
https://docs.gradle.org/current/userguide/plugins.html#sec:binary_plugins |
|
The way we do it, and it is normally done, is using the
https://docs.gradle.org/current/userguide/plugins.html#sec:applying_plugins_buildscript |
|
If I But nothing else. |
|
I can't even find any attempt to read a file with the version we need in the filename: Which is worrying. |
|
I found one possible issue in the error: They key thing here is that this file is status-mobile/nix/deps/nodejs-patched/default.nix Lines 28 to 42 in 0642042 So that's one thing to fix, but it doesn't appear to make a difference. |
|
When I run Gradle with Specifically, it tries the URL: Which does exist, but is just a POM without any JAR. |
|
Here we can see where Gradle is looking for the plugin POMs(and JARs): The location for the POM is: We can put it there, but what the hell is |
|
Apparently:
So that's annoying, but doable. |
|
Aaaand there we have it:
And:
https://docs.gradle.org/7.5/userguide/declaring_repositories.html#sub:plugin-repos So yes, Gradle does ignore our Moronic. |
|
But we can try working around this with: pluginManagement {
repositories {
maven { url './maven-repo' }
gradlePluginPortal()
ivy { url './ivy-repo' }
}
}https://docs.gradle.org/7.5/userguide/plugins.html#sec:custom_plugin_repositories Maybe. |
|
And indeed |
|
Interestingly, we already use this for status-mobile/android/settings.gradle Lines 3 to 8 in 1f1ab30 And we use |
|
Progress! By applying It's looking in |
siddarthkay
force-pushed
the
react-native-upgrade-68
branch
from
e8f0e24
to
851c947
Compare
fix Podfile for `react-native-reanimated` update `AppDelegate.mm` reference in xcodeProject some more logs to `app-launched-listener` upgrade RNN & add more logs upgrade lib `react-native-reanimated` to get rid of iOS Warning: RCTBridge required dispatch_sync to load REAModule get rid of deprecated `bootstrapWithDelegate` update yarn.lock :)
bump `react-native-hole-view` use status-im org fork of `react-native-hole-view` use status-im org fork of `react-native-mail` use correct fork of `react-native-mail` nix: use new flags for gradle call Signed-off-by: Jakub Sokołowski <jakub@status.im> nix: fix aapt2 derivationt trying to patch a text file Signed-off-by: Jakub Sokołowski <jakub@status.im> nix: make AAPT2 installPhase optional for macos Signed-off-by: Jakub Sokołowski <jakub@status.im> nix: fix gradle dependencies Signed-off-by: Jakub Sokołowski <jakub@status.im> nix: add missing gradle deps (NOT A REAL FIX) Signed-off-by: Jakub Sokołowski <jakub@status.im> nix: drop setting JAVA_HOME, breaks apkanalyzer Signed-off-by: Jakub Sokołowski <jakub@status.im>
siddarthkay
force-pushed
the
react-native-upgrade-68
branch
from
851c947
to
1e5d968
Compare
show pods and revert the Podfile change show me what you got in Pods dir log contents & permissions of IOS PR Pods on fail patch glog in `patchReactNativePhase` update gems remove degenerate pods add comment todo to remove patch fix later maybe xcode needs to be cleaned up get rid of `react-native-codegen` add default flags to Podfile :deterministic_uuids => false ios: pods update, xcode config fix :deterministic_uuids => false breaks stuff locally try `make release-ios-pr` when ios build fails on failure try harder fix quotes install pods via makefile get rid of useless steps print rn environment info on CI check rn-info on failure as well make release-ios-pr bring back UseModernBuildSystem flag try if `make release-ios-pr` works on CI macos try building ios instead of archiving in Prebundle target ios fix make try building scheme StatusIm as well show CI xcode buildSettings add `verbose` flag to fastlane ios builds add verbose to xcargs use nix shell for rn-info use script block xcode-clean on prep stage can't xcode-select --reset without sudo dont print info in pre build stage try on a specific host no label update label `__apply_Xcode_12_5_M1_post_install_workaround` try and clean xcode better get rid of entire DerivedData folder get rid of header_search_path xcode something something upgrade nodejs to 18.x
enable new architecture don't patchBuildIdPhase & patchJavaPhase TEMP build without fabric
`ndkVersion`-> "23.1.7779620" android: fix missing gradle dependencies nix: moar android fixes add dependency for AsyncStorage
refactor to use latest react-native-config library add tsconfig & remove flowconfig upgrade `react-native-redash` to `18.1.0`
siddarthkay
force-pushed
the
react-native-upgrade-68
branch
from
1e5d968
to
3f61907
Compare
|
hey @siddarthkay could you pls give a short update on the latest status of this PR, i see you created a new PR with an older version, no luck with 0.71.4 ? :( |
no luck with any version after 0.67.5! The transition to enable new architecture and use newer navigation library and newer reanimated library was too much to handle all together. So I figured its best to merge what is stable (i.e 0.67) into develop and observe if it breaks any existing functionality and isolate each issue and work on it separately. |
|
Hi @siddarthkay, |
|
hey @siddarthkay should we close this or rename maybe, because we are not on 0.63.3 anymore ? |
|
hey @flexsurfer : I'll rename, this PR has some fixes for 0.71 which i'd like to keep as a reference, will also mark this PR as draft. |
flexsurfer
changed the title
|
feel free to reopen when work is ongoing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #14386
status: ready