Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quo2 Wallet: network bridge #16793

Merged
merged 9 commits into from
Aug 1, 2023
Merged

Quo2 Wallet: network bridge #16793

merged 9 commits into from
Aug 1, 2023

Conversation

OmarBasem
Copy link
Contributor

@OmarBasem OmarBasem commented Jul 27, 2023 •
edited
Loading

fixes: #16753

This PR implements Network Bridge component.

Designs.

Sceenshots:

IMG-3396
IMG-3397
IMG-3398
IMG-3399

@OmarBasem OmarBasem self-assigned this Jul 27, 2023
@OmarBasem OmarBasem force-pushed the quo2/network-bridge branch from 7b14158 to e6862e6 Compare July 27, 2023 08:21
@status-im-auto
Copy link
Member

status-im-auto commented Jul 27, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (16)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ e6862e6 #2 2023-07-27 08:28:41 ~7 min ios 📱ipa 📲
✔️ e6862e6 #2 2023-07-27 08:30:28 ~8 min android-e2e 🤖apk 📲
✔️ e6862e6 #2 2023-07-27 08:30:35 ~8 min android 🤖apk 📲
✔️ e6862e6 #2 2023-07-27 08:31:24 ~9 min tests 📄log
✔️ 3fc1acc #3 2023-07-28 05:54:51 ~6 min ios 📱ipa 📲
✔️ 3fc1acc #3 2023-07-28 05:57:39 ~9 min android 🤖apk 📲
✔️ 3fc1acc #3 2023-07-28 05:57:39 ~9 min android-e2e 🤖apk 📲
✔️ 3fc1acc #3 2023-07-28 05:58:11 ~9 min tests 📄log
✔️ d9b285f #4 2023-07-31 11:31:31 ~5 min android 🤖apk 📲
✔️ d9b285f #4 2023-07-31 11:31:55 ~5 min android-e2e 🤖apk 📲
✔️ d9b285f #4 2023-07-31 11:32:21 ~6 min ios 📱ipa 📲
❌ d9b285f #4 2023-07-31 11:34:47 ~8 min tests 📄log
✔️ 8ac9da2 #5 2023-07-31 11:54:44 ~6 min ios 📱ipa 📲
✔️ 8ac9da2 #5 2023-07-31 11:57:10 ~8 min android 🤖apk 📲
✔️ 8ac9da2 #5 2023-07-31 11:57:14 ~8 min android-e2e 🤖apk 📲
❌ 8ac9da2 #5 2023-07-31 11:58:23 ~9 min tests 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 1d0e36c #6 2023-08-01 10:14:18 ~2 min tests 📄log
✔️ 9cc0963 #8 2023-08-01 10:31:56 ~5 min android-e2e 🤖apk 📲
✔️ 9cc0963 #8 2023-08-01 10:41:29 ~15 min android 🤖apk 📲
✔️ 9cc0963 #8 2023-08-01 10:41:44 ~15 min tests 📄log

@J-Son89
Copy link
Contributor

J-Son89 commented Jul 27, 2023

a few screen shots of the preview screens would be great! :)

@OmarBasem OmarBasem force-pushed the quo2/network-bridge branch from e6862e6 to 3fc1acc Compare July 28, 2023 05:48
@OmarBasem OmarBasem requested a review from J-Son89 July 28, 2023 07:49
ilmotta
ilmotta approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@ilmotta ilmotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@OmarBasem OmarBasem requested a review from Francesca-G July 31, 2023 05:00
Francesca-G
Francesca-G reviewed Jul 31, 2023
View reviewed changes
Copy link

@Francesca-G Francesca-G left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the Figma frame with the design review :)

@OmarBasem OmarBasem force-pushed the quo2/network-bridge branch from 3fc1acc to d9b285f Compare July 31, 2023 11:25
@OmarBasem
Copy link
Contributor Author

Thanks for your review @Francesca-G :)

I have replied to your comments on Figma

@Francesca-G
Copy link

Thanks for your review @Francesca-G :)

I have replied to your comments on Figma

Thank you for fixing the highlighted issues!

About the size of the component, as you can see when I overlap the design with the implementation it doesn't match. Maybe it's a screen issue?

Screenshot 2023-07-31 alle 16 56 08

the correct size should be 136x44px as you said

@OmarBasem
Copy link
Contributor Author

@Francesca-G the scale would be different from device to device.

@OmarBasem OmarBasem force-pushed the quo2/network-bridge branch from 8ac9da2 to 1d0e36c Compare August 1, 2023 10:11
@OmarBasem OmarBasem force-pushed the quo2/network-bridge branch from ad69401 to 9cc0963 Compare August 1, 2023 10:25
@OmarBasem OmarBasem merged commit b8d01c8 into develop Aug 1, 2023
@OmarBasem OmarBasem deleted the quo2/network-bridge branch August 1, 2023 10:44
FFFra pushed a commit that referenced this pull request Aug 1, 2023
@OmarBasem @FFFra
Quo2 Wallet: network bridge (#16793)
3e78b2c 
* feat: quo2 network bridge
mmilad75 pushed a commit that referenced this pull request Aug 2, 2023
@OmarBasem @mmilad75
Quo2 Wallet: network bridge (#16793)
979a49d 
* feat: quo2 network bridge
mmilad75 pushed a commit that referenced this pull request Aug 2, 2023
@OmarBasem @mmilad75
Quo2 Wallet: network bridge (#16793)
32e93db 
* feat: quo2 network bridge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulisesmac ulisesmac ulisesmac left review comments

@smohamedjavid smohamedjavid smohamedjavid left review comments

@Francesca-G Francesca-G Francesca-G approved these changes

@vkjr vkjr vkjr approved these changes

@ilmotta ilmotta ilmotta approved these changes

@rahulpsingh rahulpsingh Awaiting requested review from rahulpsingh

@mmilad75 mmilad75 Awaiting requested review from mmilad75

@J-Son89 J-Son89 Awaiting requested review from J-Son89

Assignees

@OmarBasem OmarBasem

Labels
None yet
Projects
Pipeline for QA
Archived in project
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Quo2 Wallet: Network Bridge component
8 participants
@OmarBasem @status-im-auto @J-Son89 @Francesca-G @ilmotta @vkjr @smohamedjavid @ulisesmac