Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#17288] refactor: migrate previews to new api #17280

Merged
merged 6 commits into from
Sep 15, 2023
Merged

[#17288] refactor: migrate previews to new api #17280

merged 6 commits into from
Sep 15, 2023

Conversation

mohsen-ghafouri
Copy link
Contributor

@mohsen-ghafouri mohsen-ghafouri commented Sep 13, 2023 •
edited
Loading

to accomplish #17288

  • fixed some ns issues on refactored component
  • markdown
    • list
    • text
  • messages
    • author
    • gap
    • system_message

status: ready

@mohsen-ghafouri mohsen-ghafouri self-assigned this Sep 13, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Sep 13, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (8)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 03f625b #2 2023-09-13 14:11:25 ~6 min android 🤖apk 📲
✔️ 03f625b #2 2023-09-13 14:11:32 ~7 min android-e2e 🤖apk 📲
✔️ 03f625b #2 2023-09-13 14:13:19 ~8 min tests 📄log
✔️ 03f625b #2 2023-09-13 14:16:43 ~12 min ios 📱ipa 📲
❌ 239e848 #1 2023-09-15 08:38:57 ~2 min ios 📄log
✔️ 239e848 #1 2023-09-15 08:43:35 ~6 min android-e2e 🤖apk 📲
✔️ 239e848 #1 2023-09-15 08:43:43 ~6 min android 🤖apk 📲
✔️ 239e848 #1 2023-09-15 08:46:46 ~9 min tests 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ db1c1d8 #2 2023-09-15 12:00:03 ~1 min ios 📄log
✔️ db1c1d8 #2 2023-09-15 12:06:50 ~8 min android-e2e 🤖apk 📲
✔️ db1c1d8 #2 2023-09-15 12:07:05 ~8 min android 🤖apk 📲
✔️ db1c1d8 #2 2023-09-15 12:09:11 ~10 min tests 📄log
❌ ac62534 #3 2023-09-15 15:00:58 ~1 min ios 📄log
✔️ ac62534 #3 2023-09-15 15:05:36 ~6 min android-e2e 🤖apk 📲
✔️ ac62534 #3 2023-09-15 15:05:47 ~6 min android 🤖apk 📲
✔️ ac62534 #3 2023-09-15 15:07:53 ~8 min tests 📄log

@mohsen-ghafouri mohsen-ghafouri added the no-ci-builds Stops Jenkins from running builds label Sep 13, 2023
@mohsen-ghafouri mohsen-ghafouri force-pushed the mohsen/migrate-previews branch 3 times, most recently from 1347317 to 24759d9 Compare September 14, 2023 11:34
@mohsen-ghafouri mohsen-ghafouri changed the title [WIP] refactor: migrate markdown preview to new api [WIP] refactor: migrate previews to new api Sep 14, 2023
@mohsen-ghafouri mohsen-ghafouri changed the title [WIP] refactor: migrate previews to new api [WIP][#17288] refactor: migrate previews to new api Sep 14, 2023
@mohsen-ghafouri mohsen-ghafouri mentioned this pull request Sep 14, 2023
Closed
@mohsen-ghafouri mohsen-ghafouri removed the no-ci-builds Stops Jenkins from running builds label Sep 15, 2023
@mohsen-ghafouri mohsen-ghafouri changed the title [WIP][#17288] refactor: migrate previews to new api [#17288] refactor: migrate previews to new api Sep 15, 2023
@mohsen-ghafouri mohsen-ghafouri marked this pull request as ready for review September 15, 2023 08:37
J-Son89
J-Son89 approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@J-Son89 J-Son89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff @mohsen-ghafouri!

@status-im-auto
Copy link
Member

67% of end-end tests have passed

Total executed tests: 43
Failed tests: 14
Passed tests: 29

IDs of failed tests: 702809,702784,702732,703133,703086,702948,702894,702745,702783,703503,703202,702786,702731,702808

Failed tests (14)

Click to expand
  • Rerun failed tests

    • Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 
    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    2. test_group_chat_reactions, id: 703202

    Device 1: Wait for text element EmojisNumber to be equal to 1
    Device 1: Find EmojisNumber by xpath: //*[starts-with(@text,'This is a test message to check some reactions.')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//*[@content-desc='emoji-reaction-4']/android.widget.TextView 

    critical/chats/test_group_chat.py:254: in test_group_chat_reactions
    message_element.emojis_below_message(emoji="laugh").wait_for_element_text(1)
../views/base_element.py:172: in wait_for_element_text
    element_text = self.find_element().text.strip()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: EmojisNumber by xpath: `//*[starts-with(@text,'This is a test message to check some reactions.')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//*[@content-desc='emoji-reaction-4']/android.widget.TextView` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    3. test_group_chat_offline_pn, id: 702808

    Device 3: Looking for a message by text: message from old member
    Device 3: Looking for a message by text: message from new member 

    critical/chats/test_group_chat.py:442: in test_group_chat_offline_pn
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Messages PN was not fetched from offline
E    message from old member if not shown for device 0
E    message from new member if not shown for device 0



    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

    # STEP: Check that can remove user from logged out state
    Device 1: Find Button by accessibility id: show-profiles 

    critical/test_public_chat_browsing.py:519: in test_restore_multiaccount_with_waku_backup_remove_switch
    self.sign_in.show_profiles_button.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: Button by accessibility id: `show-profiles` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    2. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] https://github.com//issues/17175]]

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_mark_all_messages_as_read, id: 703086

    Device 1: Tap on found: Button
    Device 1: Click until Text by accessibility id: community-description-text will be presented 

    critical/test_public_chat_browsing.py:1028: in test_community_mark_all_messages_as_read
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 New messages counter is not shown in home > Community element
E    New messages counter is not shown in community channel element



    Device sessions

    2. test_community_contact_block_unblock_offline, id: 702894

    Device 1: Click until ChatMessageInput by accessibility id: chat-message-input will be presented
    Device 1: Looking for a message by text: Hurray! unblocked 

    critical/test_public_chat_browsing.py:967: in test_community_contact_block_unblock_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Hurray! unblocked was not received in public chat after user unblock!

    [[Message can be missed after unblock: https://github.com//issues/16873]]

    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

    Device 2: Find MemberPhoto by xpath: //*[starts-with(@text,'profile_photo')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='user-avatar']
    Device 2: Image differs from template to 7.107053270526961 percents 

    critical/chats/test_1_1_public_chats.py:1128: in test_1_1_chat_non_latin_messages_stack_update_profile_photo
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Image of user in 1-1 chat is too different from template!



    Device sessions

    2. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809

    # STEP: Checking that "bold text in asterics" is applied (**) in community channel
    Device 2: Sending message 'bold text in asterics' 

    critical/test_public_chat_browsing.py:1172: in test_community_markdown_support
    self.channel_2.send_message(message_to_send)
../views/chat_view.py:995: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:121: in wait_for_element
    raise TimeoutException(
 Device `2`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element



    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948

    # STEP: Device 1 sends a message with hashtag in the dogs channel
    Device 1: Sending message '#cats' 

    critical/test_public_chat_browsing.py:1259: in test_community_hashtag_links_to_community_channels
    self.channel_1.send_message(message_with_hashtag)
../views/chat_view.py:995: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:121: in wait_for_element
    raise TimeoutException(
 Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element; 
 RemoteDisconnected



    Device sessions

    3. test_community_mentions_push_notification, id: 702786

    # STEP: Invited member sends a message with a mention
    Device 2: Sending message 'hi' 

    critical/test_public_chat_browsing.py:1081: in test_community_mentions_push_notification
    self.channel_2.send_message("hi")
../views/chat_view.py:995: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:121: in wait_for_element
    raise TimeoutException(
 Device `2`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element

    [[Issue with username in PN, issue #6 in 15500]]

    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784

    ## Sign in (password:qwerty1234, keycard:False)
    Device 2: Find EditBox by accessibility id: password-input 

    critical/chats/test_1_1_public_chats.py:1468: in test_1_1_chat_delete_via_long_press_relogin
    self.home_2.reopen_app()
../views/base_view.py:651: in reopen_app
    sign_in_view.sign_in(password)
../views/sign_in_view.py:296: in sign_in
    self.password_input.send_keys(password)
../views/base_element.py:367: in send_keys
    self.find_element().send_keys(value)
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: EditBox by accessibility id: `password-input` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

    Device 2: Find Text by xpath: //*[starts-with(@text,'test message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
    Device 2: Text is Sent 

    critical/chats/test_1_1_public_chats.py:1416: in test_1_1_chat_is_shown_message_sent_delivered_from_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message status was not changed to Delivered, it's Sent after back up online!



    Device sessions

    Passed tests (29)

    Click to expand

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    2. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_undo_delete_message, id: 702869
    Device sessions

    3. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    4. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_message_delete, id: 702839
    Device sessions

    5. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    6. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    7. test_community_message_edit, id: 702843
    Device sessions

    8. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_edit_message, id: 702855
    Device sessions

    5. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    6. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_leave, id: 702845
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    @mohsen-ghafouri mohsen-ghafouri merged commit b73ea57 into develop Sep 15, 2023
    2 checks passed
    @mohsen-ghafouri mohsen-ghafouri deleted the mohsen/migrate-previews branch September 15, 2023 16:53
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @J-Son89 J-Son89 J-Son89 approved these changes

    @ilmotta ilmotta ilmotta approved these changes

    @FFFra FFFra Awaiting requested review from FFFra

    Assignees

    @mohsen-ghafouri mohsen-ghafouri

    Labels
    None yet
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    4 participants
    @mohsen-ghafouri @status-im-auto @ilmotta @J-Son89