[#17309] fix: wrong cursor position in a pre-filled composer

[mohsen-ghafouri]

fixes #17309

The cursor should be displayed at the end of the pre-filled message in the composer when the chat is reopened.

Result

Simulator.Screen.Recording.-.iPhone.11.Pro.-.2023-09-19.at.09.18.41.mp4

Steps to test

1. Open a chat.
2. Type a message in the composer but do not send it.
3. Close the chat.
4. Reopen the same chat.

status: ready

[status-im-auto]

Jenkins Builds

Click to see older builds (4)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	369adc8	#1	2023-09-19 06:28:44	~6 min	android-e2e	🤖apk 📲
✔️	369adc8	#1	2023-09-19 06:28:46	~6 min	android	🤖apk 📲
✔️	369adc8	#1	2023-09-19 06:28:47	~6 min	ios	📱ipa 📲
✔️	369adc8	#1	2023-09-19 06:31:07	~8 min	tests	📄log

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	8181331	#2	2023-09-19 17:54:20	~10 min	android-e2e	🤖apk 📲
✔️	8181331	#2	2023-09-19 17:54:27	~10 min	android	🤖apk 📲
✔️	8181331	#2	2023-09-19 17:54:34	~10 min	tests	📄log
✔️	8181331	#2	2023-09-19 17:57:14	~12 min	ios	📱ipa 📲
✔️	6edba04	#3	2023-09-20 12:55:58	~5 min	android	🤖apk 📲
✔️	6edba04	#3	2023-09-20 12:56:32	~6 min	android-e2e	🤖apk 📲
✔️	6edba04	#3	2023-09-20 12:57:06	~6 min	ios	📱ipa 📲
✔️	6edba04	#3	2023-09-20 12:59:22	~8 min	tests	📄log

[ajayesivan]

LGTM!

[status-im-auto]

81% of end-end tests have passed

Total executed tests: 43
Failed tests: 8
Passed tests: 35

IDs of failed tests: 702732,703086,702894,702783,703503,702786,702731,702808 

Failed tests (8)

Click to expand

Rerun failed tests

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_mentions_push_notification, id: 702786

# STEP: Invited member gets push notification with the mention and tap it Device 2: Getting PN by 'user_2' critical/test_public_chat_browsing.py:1149: in test_community_mentions_push_notification self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Push notification with the mention was not received by admin E Can not edit a message with a mention E Push notification with the mention was not received by the invited member [[Issue with username in PN, issue #6 in 15500]] Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestCommunityOneDeviceMerged:

1. test_community_discovery, id: 703503

Test is not run, e2e blocker [[reason: [NOTRUN] https://github.com//issues/17175]]

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732

Test is not run, e2e blocker [[reason: [NOTRUN] Pin feature is in development]]

2. test_group_chat_offline_pn, id: 702808

Device 3: Looking for a message by text: message from old member Device 3: Looking for a message by text: message from new member critical/chats/test_group_chat.py:442: in test_group_chat_offline_pn self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Messages PN was not fetched from offline Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_pin_messages, id: 702731

Test is not run, e2e blocker [[reason: [NOTRUN] Pin feature is in development]]

Class TestCommunityMultipleDeviceMerged:

1. test_community_mark_all_messages_as_read, id: 703086

Device 1: Tap on found: Button Device 1: Click until Text by accessibility id: community-description-text will be presented critical/test_public_chat_browsing.py:1028: in test_community_mark_all_messages_as_read self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) New messages counter is not shown in home > Community element E New messages counter is not shown in community channel element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

2. test_community_contact_block_unblock_offline, id: 702894

Device 1: Click until ChatMessageInput by accessibility id: chat-message-input will be presented Device 1: Looking for a message by text: Hurray! unblocked critical/test_public_chat_browsing.py:967: in test_community_contact_block_unblock_offline self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Hurray! unblocked was not received in public chat after user unblock! [[Message can be missed after unblock: https://github.com//issues/16873]] Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

Device 2: Find Text by xpath: //*[starts-with(@text,'test message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView Device 2: Text is Delivered critical/chats/test_1_1_public_chats.py:1416: in test_1_1_chat_is_shown_message_sent_delivered_from_offline self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Message was not delivered after resending from offline Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Passed tests (35)

Click to expand

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_markdown_support, id: 702809

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

2. test_community_hashtag_links_to_community_channels, id: 702948

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

3. test_community_leave, id: 702845

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

2. test_activity_center_contact_request_decline, id: 702850

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

Device sessions Device 1: Steps, video, logs

2. test_community_copy_and_paste_message_in_chat_input, id: 702742

Device sessions Device 1: Steps, video, logs

3. test_community_undo_delete_message, id: 702869

Device sessions Device 1: Steps, video, logs

4. test_community_navigate_to_channel_when_relaunch, id: 702846

Device sessions Device 1: Steps, video, logs

5. test_community_mute_community_and_channel, id: 703382

Device sessions Device 1: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_navigation_jump_to, id: 702936

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

2. test_1_1_chat_text_message_delete_push_disappear, id: 702733

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

3. test_1_1_chat_push_emoji, id: 702813

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

5. test_1_1_chat_edit_message, id: 702855

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

6. test_1_1_chat_send_image_save_and_share, id: 703391

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

7. test_1_1_chat_message_reaction, id: 702730

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_mute_chat, id: 703495

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

2. test_group_chat_send_image_save_and_share, id: 703297

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

3. test_group_chat_reactions, id: 703202

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

4. test_group_chat_join_send_text_messages_push, id: 702807

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_several_images_send_reply, id: 703194

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

2. test_community_one_image_send_reply, id: 702859

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

3. test_community_emoji_send_copy_paste_reply, id: 702840

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

4. test_community_message_delete, id: 702839

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

5. test_community_message_send_check_timestamps_sender_username, id: 702838

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

6. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

7. test_community_message_edit, id: 702843

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

8. test_community_unread_messages_badge, id: 702841

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_delete_via_long_press_relogin, id: 702784

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

2. test_1_1_chat_mute_chat, id: 703496

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_mentions, id: 702957

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

2. test_activity_center_admin_notification_accept_swipe, id: 702958

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

[VolodLytvynenko]

Hi @mohsen-ghafouri, thank you for the fix. However, this issue still exists in other case:

ISSUE 1: The cursor is displayed at the random place of the composer when a chat is reopened with a pre-filled composer during message editing

Steps to Reproduce:

1. Open a chat.
2. Send the text message at least 2-3 lines
3. Tap 'edit' button (but do not send the current message)
4. Close the chat.
5. Reopen the same chat.

Actual Result:

The cursor is shown at a random place of the composer if a pre-filled composer is opened

composer_pr.mp4

Expected Result:

The cursor should be displayed at the end of the pre-filled message in the composer when the chat is reopened.

Devices:

• IOS, Android

[mohsen-ghafouri]

thanks @VolodLytvynenko i will check edit scenario as well

[mohsen-ghafouri]

Simulator.Screen.Recording.-.iPhone.11.Pro.-.2023-09-19.at.20.46.08.mp4

please check again @VolodLytvynenko

[briansztamfater]

LGTM!

[status-im-auto]

81% of end-end tests have passed

Total executed tests: 43
Failed tests: 8
Passed tests: 35

IDs of failed tests: 702732,703086,702894,702783,703503,702786,702731,702808 

Failed tests (8)

Click to expand

Rerun failed tests

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732

Test is not run, e2e blocker [[reason: [NOTRUN] Pin feature is in development]]

2. test_group_chat_offline_pn, id: 702808

Device 3: Looking for a message by text: message from old member Device 3: Looking for a message by text: message from new member critical/chats/test_group_chat.py:442: in test_group_chat_offline_pn self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Messages PN was not fetched from offline Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_pin_messages, id: 702731

Test is not run, e2e blocker [[reason: [NOTRUN] Pin feature is in development]]

Class TestCommunityOneDeviceMerged:

1. test_community_discovery, id: 703503

Test is not run, e2e blocker [[reason: [NOTRUN] https://github.com//issues/17175]]

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_mentions_push_notification, id: 702786

# STEP: Invited member gets push notification with the mention and tap it Device 2: Getting PN by 'user_2' critical/test_public_chat_browsing.py:1149: in test_community_mentions_push_notification self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Push notification with the mention was not received by admin E Can not edit a message with a mention E Push notification with the mention was not received by the invited member [[Issue with username in PN, issue #6 in 15500]] Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestCommunityMultipleDeviceMerged:

1. test_community_mark_all_messages_as_read, id: 703086

Device 1: Tap on found: Button Device 1: Click until Text by accessibility id: community-description-text will be presented critical/test_public_chat_browsing.py:1028: in test_community_mark_all_messages_as_read self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) New messages counter is not shown in home > Community element E New messages counter is not shown in community channel element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

2. test_community_contact_block_unblock_offline, id: 702894

Device 1: Click until ChatMessageInput by accessibility id: chat-message-input will be presented Device 1: Looking for a message by text: Hurray! unblocked critical/test_public_chat_browsing.py:967: in test_community_contact_block_unblock_offline self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Hurray! unblocked was not received in public chat after user unblock! [[Message can be missed after unblock: https://github.com//issues/16873]] Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

Device 2: Find Text by xpath: //*[starts-with(@text,'test message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView Device 2: Text is Sent critical/chats/test_1_1_public_chats.py:1416: in test_1_1_chat_is_shown_message_sent_delivered_from_offline self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Message status was not changed to Delivered, it's Sent after back up online! Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Passed tests (35)

Click to expand

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

2. test_1_1_chat_text_message_delete_push_disappear, id: 702733

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

3. test_1_1_chat_push_emoji, id: 702813

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

5. test_1_1_chat_edit_message, id: 702855

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

6. test_1_1_chat_send_image_save_and_share, id: 703391

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

7. test_1_1_chat_message_reaction, id: 702730

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_mute_chat, id: 703495

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

2. test_group_chat_send_image_save_and_share, id: 703297

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

3. test_group_chat_reactions, id: 703202

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

4. test_group_chat_join_send_text_messages_push, id: 702807

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_navigation_jump_to, id: 702936

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

Device sessions Device 1: Steps, video, logs

2. test_community_copy_and_paste_message_in_chat_input, id: 702742

Device sessions Device 1: Steps, video, logs

3. test_community_undo_delete_message, id: 702869

Device sessions Device 1: Steps, video, logs

4. test_community_navigate_to_channel_when_relaunch, id: 702846

Device sessions Device 1: Steps, video, logs

5. test_community_mute_community_and_channel, id: 703382

Device sessions Device 1: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

2. test_activity_center_contact_request_decline, id: 702850

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_markdown_support, id: 702809

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

2. test_community_hashtag_links_to_community_channels, id: 702948

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

3. test_community_leave, id: 702845

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_delete_via_long_press_relogin, id: 702784

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

2. test_1_1_chat_mute_chat, id: 703496

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_mentions, id: 702957

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

2. test_activity_center_admin_notification_accept_swipe, id: 702958

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_several_images_send_reply, id: 703194

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

2. test_community_one_image_send_reply, id: 702859

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

3. test_community_emoji_send_copy_paste_reply, id: 702840

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

4. test_community_message_delete, id: 702839

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

5. test_community_message_send_check_timestamps_sender_username, id: 702838

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

6. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

7. test_community_message_edit, id: 702843

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

8. test_community_unread_messages_badge, id: 702841

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

[VolodLytvynenko]

Hi @mohsen-ghafouri thank you for your work. Sorry for testing delay. PR is ready to be merged