[17377-17378] Fix reply view in activity center showing only one phot… #17388

ibrkhalil · 2023-09-22T10:07:30Z

iOS	Android

Fixes an issue that happened when a user replied to another user in community channel, The activity logs component only rendered a single image (If they were multiple in the reply, Only one would show) and didn't show the text in the reply if it was with an image

Presumably, Might need a design review since it's an extension of the previoulsy implemented component
status: ready

status-im-auto · 2023-09-22T10:14:12Z

Jenkins Builds

Click to see older builds (38)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`88da59b`	#1	2023-09-22 10:14:11	~6 min	`ios`	📱`ipa` 📲
✔️	`88da59b`	#1	2023-09-22 10:17:54	~10 min	`android`	🤖`apk` 📲
✔️	`88da59b`	#1	2023-09-22 10:18:01	~10 min	`android-e2e`	🤖`apk` 📲
✔️	`88da59b`	#1	2023-09-22 10:18:28	~10 min	`tests`	📄`log`

✔️	`ab63478`	#2	2023-09-22 10:56:46	~6 min	`ios`	📱`ipa` 📲
✔️	`ab63478`	#2	2023-09-22 10:57:08	~6 min	`android`	🤖`apk` 📲
✔️	`ab63478`	#2	2023-09-22 10:58:35	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`ab63478`	#2	2023-09-22 11:00:15	~9 min	`tests`	📄`log`

✔️	`5974f07`	#3	2023-09-22 14:48:27	~6 min	`ios`	📱`ipa` 📲
✔️	`5974f07`	#3	2023-09-22 14:51:22	~9 min	`android-e2e`	🤖`apk` 📲
✔️	`5974f07`	#3	2023-09-22 14:51:37	~9 min	`android`	🤖`apk` 📲
✔️	`5974f07`	#3	2023-09-22 14:52:17	~10 min	`tests`	📄`log`

✔️	`ae650b3`	#4	2023-09-22 18:36:21	~6 min	`ios`	📱`ipa` 📲
✔️	`ae650b3`	#4	2023-09-22 18:39:43	~9 min	`android-e2e`	🤖`apk` 📲
✔️	`ae650b3`	#4	2023-09-22 18:39:58	~9 min	`android`	🤖`apk` 📲
✔️	`ae650b3`	#4	2023-09-22 18:40:42	~10 min	`tests`	📄`log`

✔️	`e069be4`	#6	2023-09-23 13:30:42	~5 min	`android`	🤖`apk` 📲
✔️	`e069be4`	#6	2023-09-23 13:30:48	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`e069be4`	#6	2023-09-23 13:31:35	~6 min	`ios`	📱`ipa` 📲
✔️	`e069be4`	#6	2023-09-23 13:33:52	~8 min	`tests`	📄`log`

❌	`b66eefd`	#7	2023-09-25 07:24:15	~2 min	`ios`	📄`log`
✔️	`b66eefd`	#7	2023-09-25 07:31:36	~9 min	`android`	🤖`apk` 📲
✔️	`b66eefd`	#7	2023-09-25 07:31:49	~9 min	`android-e2e`	🤖`apk` 📲
✔️	`b66eefd`	#7	2023-09-25 07:32:34	~10 min	`tests`	📄`log`

✔️	`d98f26c`	#8	2023-09-25 10:31:24	~5 min	`android`	🤖`apk` 📲
✔️	`d98f26c`	#8	2023-09-25 10:33:08	~7 min	`ios`	📱`ipa` 📲

✔️	`03873c5`	#10	2023-09-25 10:41:10	~6 min	`android`	🤖`apk` 📲
✔️	`03873c5`	#10	2023-09-25 10:41:10	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`03873c5`	#10	2023-09-25 10:41:55	~6 min	`ios`	📱`ipa` 📲
✔️	`03873c5`	#10	2023-09-25 10:43:31	~8 min	`tests`	📄`log`

✔️	`ee56347`	#11	2023-09-25 14:21:58	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`ee56347`	#11	2023-09-25 14:21:59	~6 min	`android`	🤖`apk` 📲
✔️	`ee56347`	#11	2023-09-25 14:22:44	~7 min	`ios`	📱`ipa` 📲
✔️	`ee56347`	#11	2023-09-25 14:25:09	~9 min	`tests`	📄`log`

❌	`33ad98e`	#12	2023-09-25 14:57:36	~2 min	`tests`	📄`log`
✔️	`33ad98e`	#12	2023-09-25 15:01:29	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`33ad98e`	#12	2023-09-25 15:01:34	~6 min	`android`	🤖`apk` 📲
✔️	`33ad98e`	#12	2023-09-25 15:05:45	~10 min	`ios`	📱`ipa` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`9503eba`	#14	2023-09-26 06:59:12	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`9503eba`	#14	2023-09-26 06:59:49	~6 min	`ios`	📱`ipa` 📲
✔️	`9503eba`	#14	2023-09-26 07:01:31	~7 min	`android`	🤖`apk` 📲
✔️	`9503eba`	#14	2023-09-26 07:03:05	~9 min	`tests`	📄`log`

✔️	`c69ffa6`	#15	2023-09-26 12:48:11	~5 min	`android`	🤖`apk` 📲
✔️	`c69ffa6`	#15	2023-09-26 12:49:01	~6 min	`ios`	📱`ipa` 📲
✔️	`c69ffa6`	#15	2023-09-26 12:51:10	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`c69ffa6`	#15	2023-09-26 12:53:52	~11 min	`tests`	📄`log`

src/quo2/components/notifications/activity_logs_photos/view.cljs

src/status_im2/contexts/shell/activity_center/notification/reply/view.cljs

status-im-auto · 2023-09-22T13:54:35Z

84% of end-end tests have passed

Total executed tests: 43
Failed tests: 7
Passed tests: 36

IDs of failed tests: 702784,702732,702783,703503,702786,702731,702808

Failed tests (7)

Click to expand

Rerun failed tests

Class TestCommunityOneDeviceMerged:

1. test_community_discovery, id: 703503
`Test is not run, e2e blocker` [[reason: [NOTRUN] https://github.com//issues/17175]]

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_mentions_push_notification, id: 702786

# STEP: Invited member gets push notification with the mention and tap it
Device 2: Getting PN by 'user_2'

critical/test_public_chat_browsing.py:1149: in test_community_mentions_push_notification
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Push notification with the mention was not received by admin
E    Can not edit a message with a mention
E    Push notification with the mention was not received by the invited member

[[Issue with username in PN, issue #6 in 15500]]

Device sessions

Device 1:

Device 2:

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
`Test is not run, e2e blocker` [[reason: [NOTRUN] Pin feature is in development]]
2. test_group_chat_offline_pn, id: 702808
Device 3: Looking for a message by text: message from old member Device 3: Looking for a message by text: message from new member `critical/chats/test_group_chat.py:442: in test_group_chat_offline_pn self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Messages PN was not fetched from offline` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
## Sign in (password:qwerty1234, keycard:False) Device 2: Find `EditBox` by `accessibility id`: `password-input` critical/chats/test_1_1_public_chats.py:1468: in test_1_1_chat_delete_via_long_press_relogin self.home_2.reopen_app() ../views/base_view.py:651: in reopen_app sign_in_view.sign_in(password) ../views/sign_in_view.py:296: in sign_in self.password_input.send_keys(password) ../views/base_element.py:367: in send_keys self.find_element().send_keys(value) ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: EditBox by accessibility id: `password-input` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device 2: Find `Text` by `xpath`: `//[starts-with(@text,'test message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//[@content-desc='message-status']/android.widget.TextView` Device 2: `Text` is `Delivered` `critical/chats/test_1_1_public_chats.py:1416: in test_1_1_chat_is_shown_message_sent_delivered_from_offline self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Message was not delivered after resending from offline` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_pin_messages, id: 702731
`Test is not run, e2e blocker` [[reason: [NOTRUN] Pin feature is in development]]

Passed tests (36)

Click to expand

Class TestActivityMultipleDevicePR:

1. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs
2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
3. test_community_undo_delete_message, id: 702869
Device sessions Device 1: Steps, video, logs
4. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
5. test_community_mute_community_and_channel, id: 703382
Device sessions Device 1: Steps, video, logs

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_markdown_support, id: 702809
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_hashtag_links_to_community_channels, id: 702948
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_mute_chat, id: 703495
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_send_image_save_and_share, id: 703297
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_reactions, id: 703202
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
4. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_mute_chat, id: 703496
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_contact_block_unblock_offline, id: 702894
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_message_send_check_timestamps_sender_username, id: 702838
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_send_image_save_and_share, id: 703391
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

src/status_im2/contexts/shell/activity_center/notification/reply/view.cljs

src/quo2/components/notifications/activity_logs_photos/view.cljs

src/quo2/components/notifications/activity_log/view.cljs

ibrkhalil · 2023-09-23T13:22:42Z

@ilmotta @smohamedjavid
Thank you so much for taking the time to do a review.
I did the comments, Kindly take another look.

smohamedjavid

LGTM 🚀

Nice Work!

P.S. I believe this file needs to be removed.

…o and text not showing when sent on reply

src/status_im2/contexts/shell/activity_center/notification/reply/view.cljs

churik · 2023-09-25T13:23:32Z

@ibrkhalil
please, move it to testing when all review commits are resolved, thanks!

ilmotta

Code LGTM 🚀

status-im-auto · 2023-09-26T09:25:35Z

47% of end-end tests have passed

Total executed tests: 43
Failed tests: 23
Passed tests: 20

IDs of failed tests: 702782,702784,702732,702957,702851,703495,702894,702745,702783,703297,703503,703496,702936,702855,703202,702786,702947,702807,702731,702808,702730,702958,702841

Failed tests (23)

Click to expand

Rerun failed tests

Class TestActivityMultipleDevicePR:

1. test_navigation_jump_to, id: 702936
Device 2: Find `Button` by `xpath`: `//[contains(@text, 'user1')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` Device 2: Find `Button` by `accessibility id`: `close-activity-center` Test setup failed: medium/test_activity_center.py:151: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:377: in handle_contact_request self.close_activity_centre.wait_for_rendering_ended_and_click() ../views/base_element.py:155: in wait_for_rendering_ended_and_click self.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `close-activity-center` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Test setup failed: medium/test_activity_center.py:151: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:377: in handle_contact_request self.close_activity_centre.wait_for_rendering_ended_and_click() ../views/base_element.py:155: in wait_for_rendering_ended_and_click self.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `close-activity-center` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Class TestCommunityMultipleDeviceMerged:

1. test_community_contact_block_unblock_offline, id: 702894
Device 1: Click until `ChatMessageInput` by `accessibility id`: `chat-message-input` will be presented Device 1: Looking for a message by text: Hurray! unblocked `critical/test_public_chat_browsing.py:967: in test_community_contact_block_unblock_offline self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Hurray! unblocked was not received in public chat after user unblock!` [[Message can be missed after unblock: https://github.com//issues/16873]] Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_community_unread_messages_badge, id: 702841
# STEP: Check new messages badge is shown for community Device 1: Click until `ChatMessageInput` by `accessibility id`: `chat-message-input` will be presented `critical/test_public_chat_browsing.py:891: in test_community_unread_messages_badge self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) New message community badge is not shown E New messages channel badge is not shown on channel` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestCommunityOneDeviceMerged:

1. test_community_discovery, id: 703503
`Test is not run, e2e blocker` [[reason: [NOTRUN] https://github.com//issues/17175]]

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851

Device 1: Find ChatsTab by accessibility id: chats-stack-tab
Device 1: Tap on found: ChatsTab

medium/test_activity_center.py:102: in test_activity_center_contact_request_accept_swipe_mark_all_as_read
    self.home_1.notifications_unread_badge.wait_for_visibility_of_element(30)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 1: BaseElement by accessibility id:`activity-center-unread-count` is not found on the screen after wait_for_visibility_of_element

Device sessions

Device 1:

Device 2:

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_mentions_push_notification, id: 702786

# STEP: Invited member gets push notification with the mention and tap it
Device 2: Getting PN by 'user_2'

critical/test_public_chat_browsing.py:1149: in test_community_mentions_push_notification
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Push notification with the mention was not received by admin
E    Can not edit a message with a mention
E    Push notification with the mention was not received by the invited member

[[Issue with username in PN, issue #6 in 15500]]

Device sessions

Device 1:

Device 2:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device 1: Wait for text element `EmojisNumber` to be equal to `1` Device 1: Find `EmojisNumber` by `xpath`: `//[starts-with(@text,'Test with link: https://status.im/ here should be nothing unusual.')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//[@content-desc='emoji-reaction-2']/android.widget.TextView` critical/chats/test_1_1_public_chats.py:973: in test_1_1_chat_emoji_send_reply_and_open_link self.chat_1.chat_element_by_text(url_message).emojis_below_message().wait_for_element_text(1) ../views/base_element.py:172: in wait_for_element_text element_text = self.find_element().text.strip() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: EmojisNumber by xpath: `//[starts-with(@text,'Test with link: https://status.im/ here should be nothing unusual.')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//[@content-desc='emoji-reaction-2']/android.widget.TextView` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device 2: Find `MemberPhoto` by `xpath`: `//[starts-with(@text,'profile_photo')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//[@content-desc='user-avatar']` Device 2: Image differs from template to 4.934512867647059 percents `critical/chats/test_1_1_public_chats.py:1128: in test_1_1_chat_non_latin_messages_stack_update_profile_photo self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Message with text 'hello' was not received E Message with text '¿Cómo estás tu año?' was not received E Message with text 'ё, доброго вечерочка' was not received` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
3. test_1_1_chat_edit_message, id: 702855
Device 2: Find `Text` by `xpath`: `//[starts-with(@text,'Message before edit 1-1')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//[@content-desc='message-status']/android.widget.TextView` Device 2: `Text` is `Sent` `critical/chats/test_1_1_public_chats.py:1192: in test_1_1_chat_edit_message self.chat_2.chat_element_by_text(message_before_edit_1_1).wait_for_status_to_be("Delivered") ../views/chat_view.py:235: in wait_for_status_to_be raise TimeoutException("Message status was not changed to %s, it's %s" % (expected_status, current_status)) Message status was not changed to Delivered, it's Sent` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
4. test_1_1_chat_pin_messages, id: 702731
`Test is not run, e2e blocker` [[reason: [NOTRUN] Pin feature is in development]]
5. test_1_1_chat_message_reaction, id: 702730
Device 1: Find `EmojisNumber` by `xpath`: `//[starts-with(@text,'Message sender')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//[@content-desc='emoji-reaction-2']/android.widget.TextView` Device 1: Find `EmojisNumber` by `xpath`: `//[starts-with(@text,'Message sender')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//[@content-desc='emoji-reaction-2']/android.widget.TextView` critical/chats/test_1_1_public_chats.py:881: in test_1_1_chat_message_reaction message_sender.emojis_below_message(emoji="thumbs-up").wait_for_element_text(2, 90) ../views/base_element.py:181: in wait_for_element_text self.driver.fail(message if message else "`%s` is not equal to expected `%s` in %s sec" % ( base_test_case.py:179: in fail pytest.fail('Device %s: %s' % (self.number, text)) Device 1: `1` is not equal to expected `2` in 90 sec Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Test setup failed: critical/chats/test_1_1_public_chats.py:1361: in prepare_devices self.chat_1.send_message('hey') ../views/chat_view.py:995: in send_message self.chat_message_input.wait_for_element(wait_chat_input_sec) ../views/base_element.py:121: in wait_for_element raise TimeoutException( Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element
2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device 1: ChatMessageInput element not found Device 1: Sending message 'hey' Test setup failed: critical/chats/test_1_1_public_chats.py:1361: in prepare_devices self.chat_1.send_message('hey') ../views/chat_view.py:995: in send_message self.chat_message_input.wait_for_element(wait_chat_input_sec) ../views/base_element.py:121: in wait_for_element raise TimeoutException( Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
3. test_1_1_chat_mute_chat, id: 703496
Test setup failed: critical/chats/test_1_1_public_chats.py:1361: in prepare_devices self.chat_1.send_message('hey') ../views/chat_view.py:995: in send_message self.chat_message_input.wait_for_element(wait_chat_input_sec) ../views/base_element.py:121: in wait_for_element raise TimeoutException( Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_mentions, id: 702957
Device 2: Find `Button` by `xpath`: `//[contains(@text, 'user1')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` Device 2: Find `Button` by `accessibility id`: `close-activity-center` Test setup failed: medium/test_activity_center.py:307: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:377: in handle_contact_request self.close_activity_centre.wait_for_rendering_ended_and_click() ../views/base_element.py:155: in wait_for_rendering_ended_and_click self.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `close-activity-center` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_activity_center_admin_notification_accept_swipe, id: 702958
Test setup failed: medium/test_activity_center.py:307: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:377: in handle_contact_request self.close_activity_centre.wait_for_rendering_ended_and_click() ../views/base_element.py:155: in wait_for_rendering_ended_and_click self.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `close-activity-center` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
`Test is not run, e2e blocker` [[reason: [NOTRUN] Pin feature is in development]]
2. test_group_chat_mute_chat, id: 703495
Test setup failed: critical/chats/test_group_chat.py:188: in prepare_devices self.loop.run_until_complete( /usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete return future.result() __init__.py:44: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, *self.kwargs) ../views/home_view.py:377: in handle_contact_request self.close_activity_centre.wait_for_rendering_ended_and_click() ../views/base_element.py:155: in wait_for_rendering_ended_and_click self.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `close-activity-center` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
3. test_group_chat_send_image_save_and_share, id: 703297
Test setup failed: critical/chats/test_group_chat.py:188: in prepare_devices self.loop.run_until_complete( /usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete return future.result() __init__.py:44: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, *self.kwargs) ../views/home_view.py:377: in handle_contact_request self.close_activity_centre.wait_for_rendering_ended_and_click() ../views/base_element.py:155: in wait_for_rendering_ended_and_click self.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `close-activity-center` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
4. test_group_chat_reactions, id: 703202
Test setup failed: critical/chats/test_group_chat.py:188: in prepare_devices self.loop.run_until_complete( /usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete return future.result() __init__.py:44: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, *self.kwargs) ../views/home_view.py:377: in handle_contact_request self.close_activity_centre.wait_for_rendering_ended_and_click() ../views/base_element.py:155: in wait_for_rendering_ended_and_click self.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `close-activity-center` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
5. test_group_chat_join_send_text_messages_push, id: 702807
Device 3: Find `Button` by `accessibility id`: `close-activity-center` Device 2: Find `Button` by `accessibility id`: `close-activity-center` Test setup failed: critical/chats/test_group_chat.py:188: in prepare_devices self.loop.run_until_complete( /usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete return future.result() __init__.py:44: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, *self.kwargs) ../views/home_view.py:377: in handle_contact_request self.close_activity_centre.wait_for_rendering_ended_and_click() ../views/base_element.py:155: in wait_for_rendering_ended_and_click self.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `close-activity-center` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot
6. test_group_chat_offline_pn, id: 702808
Test setup failed: critical/chats/test_group_chat.py:188: in prepare_devices self.loop.run_until_complete( /usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete return future.result() __init__.py:44: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, *self.kwargs) ../views/home_view.py:377: in handle_contact_request self.close_activity_centre.wait_for_rendering_ended_and_click() ../views/base_element.py:155: in wait_for_rendering_ended_and_click self.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `close-activity-center` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Passed tests (20)

Click to expand

Class TestCommunityMultipleDeviceMerged:

1. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_message_send_check_timestamps_sender_username, id: 702838
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs
2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
3. test_community_undo_delete_message, id: 702869
Device sessions Device 1: Steps, video, logs
4. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
5. test_community_mute_community_and_channel, id: 703382
Device sessions Device 1: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_markdown_support, id: 702809
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_hashtag_links_to_community_channels, id: 702948
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_send_image_save_and_share, id: 703391
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

VolodLytvynenko · 2023-09-26T10:37:01Z

hi @ibrkhalil, thank you for PR. No issues from my side. PR is ready to be merged

#17388)

ibrkhalil added the request-manual-qa label Sep 22, 2023

ibrkhalil requested review from ilmotta, flexsurfer, Parveshdhull and smohamedjavid September 22, 2023 10:07

ibrkhalil self-assigned this Sep 22, 2023

ibrkhalil removed the request-manual-qa label Sep 22, 2023

smohamedjavid reviewed Sep 22, 2023

View reviewed changes

ilmotta reviewed Sep 22, 2023

View reviewed changes

smohamedjavid approved these changes Sep 25, 2023

View reviewed changes

ibrkhalil added 6 commits September 25, 2023 13:33

[17377-17378] Fix reply view in activity center showing only one phot…

cc8696d

…o and text not showing when sent on reply

Typo

79390b2

Comments

06d1689

Comments

615327d

Comments

54f6b0d

Delete GPG file

03873c5

ibrkhalil force-pushed the 17377-17378 branch from f566e0e to 03873c5 Compare September 25, 2023 10:34

ibrkhalil added the request-manual-qa label Sep 25, 2023

ilmotta reviewed Sep 25, 2023

View reviewed changes

src/status_im2/contexts/shell/activity_center/notification/reply/view.cljs Outdated Show resolved Hide resolved

flexsurfer reviewed Sep 25, 2023

View reviewed changes

src/status_im2/contexts/shell/activity_center/notification/reply/view.cljs Outdated Show resolved Hide resolved

ibrkhalil added 2 commits September 25, 2023 17:15

Merge branch 'develop' into 17377-17378

ee56347

Comments

33ad98e

ilmotta approved these changes Sep 25, 2023

View reviewed changes

ibrkhalil added 2 commits September 26, 2023 09:50

Merge branch 'develop' into 17377-17378

dc83475

Formatting

9503eba

VolodLytvynenko self-assigned this Sep 26, 2023

VolodLytvynenko added the Tested - OK label Sep 26, 2023

Merge branch 'develop' into 17377-17378

c69ffa6

ibrkhalil merged commit da5086a into develop Sep 26, 2023
2 checks passed

ibrkhalil deleted the 17377-17378 branch September 26, 2023 12:59

ibrkhalil added a commit that referenced this pull request Oct 1, 2023

[17377-17378] Fix reply view in activity center showing only one phot… (

5a82e13

#17388)

[17377-17378] Fix reply view in activity center showing only one phot… #17388

[17377-17378] Fix reply view in activity center showing only one phot… #17388

Conversation

ibrkhalil commented Sep 22, 2023

status-im-auto commented Sep 22, 2023 • edited Loading

Jenkins Builds

status-im-auto commented Sep 22, 2023

84% of end-end tests have passed

Failed tests (7)

Class TestCommunityOneDeviceMerged:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Passed tests (36)

Class TestActivityMultipleDevicePR:

Class TestActivityMultipleDevicePRTwo:

Class TestCommunityOneDeviceMerged:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestCommunityMultipleDeviceMerged:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

ibrkhalil commented Sep 23, 2023

smohamedjavid left a comment

Choose a reason for hiding this comment

churik commented Sep 25, 2023

ilmotta left a comment

Choose a reason for hiding this comment

status-im-auto commented Sep 26, 2023

47% of end-end tests have passed

Failed tests (23)

Class TestActivityMultipleDevicePR:

Class TestCommunityMultipleDeviceMerged:

Class TestCommunityOneDeviceMerged:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestActivityMultipleDevicePRTwo:

Class TestGroupChatMultipleDeviceMergedNewUI:

Passed tests (20)

Class TestCommunityMultipleDeviceMerged:

Class TestCommunityOneDeviceMerged:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

VolodLytvynenko commented Sep 26, 2023 • edited Loading

status-im-auto commented Sep 22, 2023 •

edited

Loading

VolodLytvynenko commented Sep 26, 2023 •

edited

Loading