Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Retro ideas] Adjust PR template to add before/after screenshots #17402

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

ibrkhalil
Copy link
Contributor

fixes #17401

Summary

Based on our last retro, Here are the required adjustments to the PR template to include before/after screenshots

status: ready

@ibrkhalil ibrkhalil requested a review from jakubgs as a code owner September 24, 2023 15:31
@ibrkhalil ibrkhalil self-assigned this Sep 24, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Sep 24, 2023

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 8bb80c3 #1 2023-09-24 15:39:22 ~7 min ios 📱ipa 📲
✔️ 8bb80c3 #1 2023-09-24 15:41:47 ~9 min android-e2e 🤖apk 📲
✔️ 8bb80c3 #1 2023-09-24 15:42:01 ~9 min android 🤖apk 📲
✔️ 8bb80c3 #1 2023-09-24 15:42:47 ~10 min tests 📄log
✔️ 878a412 #2 2023-09-25 10:29:53 ~7 min android-e2e 🤖apk 📲
✔️ 878a412 #2 2023-09-25 10:29:56 ~7 min android 🤖apk 📲
✔️ 878a412 #2 2023-09-25 10:31:15 ~8 min ios 📱ipa 📲
✔️ 878a412 #2 2023-09-25 10:33:01 ~10 min tests 📄log

@ibrkhalil ibrkhalil changed the title Adjust PR template to add before/after [Retro ideas] Adjust PR template to add before/after screenshots Sep 25, 2023
@jakubgs
Copy link
Member

jakubgs commented Sep 25, 2023

I recommend using git rebase rather than git merge:

image

Doesn't create pointless merge commits.

@ibrkhalil ibrkhalil merged commit 53f40b5 into develop Sep 25, 2023
2 checks passed
@ibrkhalil ibrkhalil deleted the 17401 branch September 25, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

Adjust PR template to include boilerplate of adding screenshots/videos of features
3 participants