Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#17288] refactor: migrate previews to new api #17470

Merged
merged 1 commit into from
Oct 2, 2023
Merged

[#17288] refactor: migrate previews to new api #17470

merged 1 commit into from
Oct 2, 2023

Conversation

mohsen-ghafouri
Copy link
Contributor

@mohsen-ghafouri mohsen-ghafouri commented Oct 2, 2023 •
edited
Loading

to accomplish #17288

None of the basic components were touched

migrated preview screens:

  • profile
  • reactions
  • record_audio
  • selectors

status: ready

@mohsen-ghafouri mohsen-ghafouri self-assigned this Oct 2, 2023
@mohsen-ghafouri mohsen-ghafouri mentioned this pull request Oct 2, 2023
Closed
@status-im-auto
Copy link
Member

status-im-auto commented Oct 2, 2023 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ eb487a1 #1 2023-10-02 06:08:39 ~6 min android-e2e 🤖apk 📲
✔️ eb487a1 #1 2023-10-02 06:09:03 ~6 min android 🤖apk 📲
✔️ eb487a1 #1 2023-10-02 06:11:04 ~8 min tests 📄log
✔️ eb487a1 #1 2023-10-02 06:13:09 ~10 min ios 📱ipa 📲
✔️ efd343a #2 2023-10-02 07:09:01 ~6 min android 🤖apk 📲
✔️ efd343a #2 2023-10-02 07:09:29 ~6 min ios 📱ipa 📲
✔️ efd343a #2 2023-10-02 07:11:31 ~8 min android-e2e 🤖apk 📲
✔️ efd343a #2 2023-10-02 07:12:06 ~9 min tests 📄log

@mohsen-ghafouri mohsen-ghafouri force-pushed the migrate/previews-part-four branch from eb487a1 to efd343a Compare October 2, 2023 07:02
J-Son89
J-Son89 reviewed Oct 2, 2023
View reviewed changes
Copy link
Contributor

@J-Son89 J-Son89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work @mohsen-ghafouri! 🚀

J-Son89
J-Son89 approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@J-Son89 J-Son89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work @mohsen-ghafouri 🚀

@mohsen-ghafouri
Copy link
Contributor Author

@status-im/mobile-qa the same as previous PR , these changes didn't effect any screens/design system component. if it's okay i will move it to design review

@status-im-auto
Copy link
Member

49% of end-end tests have passed

Total executed tests: 43
Failed tests: 22
Passed tests: 21

IDs of failed tests: 702782,703194,702859,702732,702840,703495,703086,702894,702783,703503,703496,702936,702786,702839,702947,702838,702844,702843,702731,702808,702730,702841

Failed tests (22)

Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194 
    Test setup failed: critical/test_public_chat_browsing.py:596: in prepare_devices
    self.chat_2.chat_element_by_text(self.community_name).view_community_button.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: BaseElement by xpath: `//*[starts-with(@text,'open community')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@text='View']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    2. test_community_one_image_send_reply, id: 702859 

    Test setup failed: critical/test_public_chat_browsing.py:596: in prepare_devices
    self.chat_2.chat_element_by_text(self.community_name).view_community_button.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: BaseElement by xpath: `//*[starts-with(@text,'open community')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@text='View']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    3. test_community_emoji_send_copy_paste_reply, id: 702840 

    Test setup failed: critical/test_public_chat_browsing.py:596: in prepare_devices
    self.chat_2.chat_element_by_text(self.community_name).view_community_button.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: BaseElement by xpath: `//*[starts-with(@text,'open community')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@text='View']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    4. test_community_mark_all_messages_as_read, id: 703086 

    Test setup failed: critical/test_public_chat_browsing.py:596: in prepare_devices
    self.chat_2.chat_element_by_text(self.community_name).view_community_button.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: BaseElement by xpath: `//*[starts-with(@text,'open community')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@text='View']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    5. test_community_contact_block_unblock_offline, id: 702894 

    Test setup failed: critical/test_public_chat_browsing.py:596: in prepare_devices
    self.chat_2.chat_element_by_text(self.community_name).view_community_button.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: BaseElement by xpath: `//*[starts-with(@text,'open community')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@text='View']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

    [[Message can be missed after unblock: https://github.com//issues/16873]]

    6. test_community_message_delete, id: 702839 

    Test setup failed: critical/test_public_chat_browsing.py:596: in prepare_devices
    self.chat_2.chat_element_by_text(self.community_name).view_community_button.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: BaseElement by xpath: `//*[starts-with(@text,'open community')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@text='View']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    7. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Looking for a message by text: open community
    Device 2: Find BaseElement by xpath: //*[starts-with(@text,'open community')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@text='View'] 

    Test setup failed: critical/test_public_chat_browsing.py:596: in prepare_devices
    self.chat_2.chat_element_by_text(self.community_name).view_community_button.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: BaseElement by xpath: `//*[starts-with(@text,'open community')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@text='View']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    8. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844 

    Test setup failed: critical/test_public_chat_browsing.py:596: in prepare_devices
    self.chat_2.chat_element_by_text(self.community_name).view_community_button.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: BaseElement by xpath: `//*[starts-with(@text,'open community')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@text='View']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    9. test_community_message_edit, id: 702843 

    Test setup failed: critical/test_public_chat_browsing.py:596: in prepare_devices
    self.chat_2.chat_element_by_text(self.community_name).view_community_button.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: BaseElement by xpath: `//*[starts-with(@text,'open community')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@text='View']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    10. test_community_unread_messages_badge, id: 702841 

    Test setup failed: critical/test_public_chat_browsing.py:596: in prepare_devices
    self.chat_2.chat_element_by_text(self.community_name).view_community_button.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: BaseElement by xpath: `//*[starts-with(@text,'open community')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@text='View']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782

    Device 1: Tap on found: SendMessageButton
    Device 2: Looking for a message by text: Test with link: https://status.im/ here should be nothing unusual. 

    critical/chats/test_1_1_public_chats.py:963: in test_1_1_chat_emoji_send_reply_and_open_link
    self.chat_2.chat_element_by_text(url_message).wait_for_element(20)
../views/base_element.py:121: in wait_for_element
    raise TimeoutException(
 Device `2`: `ChatElementByText` by` xpath`: `//*[starts-with(@text,'Test with link: https://status.im/ here should be nothing unusual.')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_element



    Device sessions

    2. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    3. test_1_1_chat_message_reaction, id: 702730

    Device 2: Wait for text element EmojisNumber to be equal to 1
    Device 2: Find EmojisNumber by xpath: //*[starts-with(@text,'Message sender')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//*[@content-desc='emoji-reaction-2']/android.widget.TextView 

    critical/chats/test_1_1_public_chats.py:878: in test_1_1_chat_message_reaction
    message_receiver.emojis_below_message(emoji="thumbs-up").wait_for_element_text(1, 90)
../views/base_element.py:172: in wait_for_element_text
    element_text = self.find_element().text.strip()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: EmojisNumber by xpath: `//*[starts-with(@text,'Message sender')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//*[@content-desc='emoji-reaction-2']/android.widget.TextView` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503

    Device 1: Tap on found: Button
    Device 1: Swiping up 

    critical/test_public_chat_browsing.py:359: in test_community_discovery
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Element show-request-to-join-screen-button is different from expected template discovery_join_button.png!

    [[Request to Join Community button color issue: https://github.com//issues/17295]]

    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936

    Device 2: Looking for a message by text: open community
    Device 2: Find BaseElement by xpath: //*[starts-with(@text,'open community')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@text='View'] 

    Test setup failed: medium/test_activity_center.py:174: in prepare_devices
    self.chat_2.chat_element_by_text(self.community_name).view_community_button.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: BaseElement by xpath: `//*[starts-with(@text,'open community')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@text='View']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947 

    Test setup failed: medium/test_activity_center.py:174: in prepare_devices
    self.chat_2.chat_element_by_text(self.community_name).view_community_button.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: BaseElement by xpath: `//*[starts-with(@text,'open community')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@text='View']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_mentions_push_notification, id: 702786

    # STEP: Invited member gets push notification with the mention and tap it
    Device 2: Getting PN by 'user_2' 

    critical/test_public_chat_browsing.py:1166: in test_community_mentions_push_notification
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Push notification with the mention was not received by admin
E    Can not edit a message with a mention
E    Push notification with the mention was not received by the invited member

    [[Issue with username in PN, https://github.com//issues/17396]]

    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

    Device 2: Find Text by xpath: //*[starts-with(@text,'test message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
    Device 2: Text is Sent 

    critical/chats/test_1_1_public_chats.py:1417: in test_1_1_chat_is_shown_message_sent_delivered_from_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message was not delivered after resending from offline
E    Message status was not changed to Delivered, it's Sent after back up online!

    [[Data delivery issue]]

    Device sessions

    2. test_1_1_chat_mute_chat, id: 703496

    Device 1: Click until ChatMessageInput by accessibility id: chat-message-input will be presented
    Device 1: Looking for a message by text: after unmute 

    critical/chats/test_1_1_public_chats.py:1458: in test_1_1_chat_mute_chat
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message text 'should be muted' is not shown in chat preview after mute
E    Message 'should be muted' is not shown in chat for receiver after mute



    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    2. test_group_chat_mute_chat, id: 703495

    Device 2: Click until ChatMessageInput by accessibility id: chat-message-input will be presented
    Device 2: Looking for a message by text: Chat is unmuted now 

    critical/chats/test_group_chat.py:607: in test_group_chat_mute_chat
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 New messages counter near chats tab button is 1 after unmute, but should be 2



    Device sessions

    3. test_group_chat_offline_pn, id: 702808

    Device 3: Looking for a message by text: message from old member
    Device 3: Looking for a message by text: message from new member 

    critical/chats/test_group_chat.py:443: in test_group_chat_offline_pn
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Messages PN was not fetched from offline

    [[Data delivery issue]]

    Device sessions

    Passed tests (21)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    2. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_edit_message, id: 702855
    Device sessions

    5. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    2. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_leave, id: 702845
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    2. test_group_chat_reactions, id: 703202
    Device sessions

    3. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    @mohsen-ghafouri
    Copy link
    Contributor Author

    @Francesca-G please check if it requires design review. just preview screens has been updated.

    Francesca-G
    Francesca-G approved these changes Oct 2, 2023
    View reviewed changes
    Copy link

    @Francesca-G Francesca-G left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Looks good,
    the reaction component should be updated with the OS emojis (iOS in my case) as we agreed on not using tweemojis for now.

    @mohsen-ghafouri mohsen-ghafouri merged commit ee85d6d into develop Oct 2, 2023
    @mohsen-ghafouri mohsen-ghafouri deleted the migrate/previews-part-four branch October 2, 2023 13:28
    clauxx pushed a commit that referenced this pull request Oct 3, 2023
    @mohsen-ghafouri @clauxx
    [#17288] refactor: migrate previews to new api (#17470)
    7197a2f
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @Francesca-G Francesca-G Francesca-G approved these changes

    @J-Son89 J-Son89 J-Son89 approved these changes

    @ilmotta ilmotta Awaiting requested review from ilmotta

    @ulisesmac ulisesmac Awaiting requested review from ulisesmac

    Assignees

    @mohsen-ghafouri mohsen-ghafouri

    Labels
    followup-required
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    4 participants
    @mohsen-ghafouri @status-im-auto @J-Son89 @Francesca-G