Fix: Updates for unread messages indicator

[alwx]

Intented to fix both issues here: #16696 (comment)
The actual fix is on go side: status-im/status-go#4085

Platforms

• Android
• iOS

Areas that maybe impacted

Functional

• 1-1 chats
• public chats
• group chats

status: ready

[alwx]

The Go part (status-im/status-go#4085) was approved already so I'm moving it to E2E
cc @churik @pavloburykh

[status-im-auto]

Jenkins Builds

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	7376ae1	#1	2023-10-02 15:40:59	~7 min	android	🤖apk 📲
✔️	7376ae1	#1	2023-10-02 15:42:54	~9 min	ios	📱ipa 📲
✔️	7376ae1	#1	2023-10-02 15:42:58	~9 min	android-e2e	🤖apk 📲
✔️	7376ae1	#1	2023-10-02 15:45:39	~12 min	tests	📄log

[status-im-auto]

74% of end-end tests have passed

Total executed tests: 43
Failed tests: 11
Passed tests: 32

IDs of failed tests: 702958,702786,702731,703202,702808,702957,702783,702782,702732,703503,703495 

Failed tests (11)

Click to expand

Rerun failed tests

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_admin_notification_accept_swipe, id: 702958

Test setup failed: medium/test_activity_center.py:323: in prepare_devices self.community_2.join_community() ../views/chat_view.py:424: in join_community self.community_status_joined.wait_for_visibility_of_element(60) ../views/base_element.py:139: in wait_for_visibility_of_element raise TimeoutException( Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element

2. test_activity_center_mentions, id: 702957

Device 2: Find Button by xpath: //*[@content-desc='password-input']/../following-sibling::*//*[@text='Join Community'] Device 2: Tap on found: Button Test setup failed: medium/test_activity_center.py:323: in prepare_devices self.community_2.join_community() ../views/chat_view.py:424: in join_community self.community_status_joined.wait_for_visibility_of_element(60) ../views/base_element.py:139: in wait_for_visibility_of_element raise TimeoutException( Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestCommunityOneDeviceMerged:

1. test_community_discovery, id: 703503

Device 1: Tap on found: Button Device 1: Swiping up critical/test_public_chat_browsing.py:359: in test_community_discovery self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Element show-request-to-join-screen-button is different from expected template discovery_join_button.png! [[Request to Join Community button color issue: https://github.com//issues/17295]] Device sessions Device 1: Steps, video, logs Failure screenshot

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_pin_messages, id: 702731

Test is not run, e2e blocker [[reason: [NOTRUN] Pin feature is in development]]

2. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782

Device 1: Tap on found: SendMessageButton Device 2: Looking for a message by text: Test with link: https://status.im/ here should be nothing unusual. critical/chats/test_1_1_public_chats.py:963: in test_1_1_chat_emoji_send_reply_and_open_link self.chat_2.chat_element_by_text(url_message).wait_for_element(20) ../views/base_element.py:121: in wait_for_element raise TimeoutException( Device `2`: `ChatElementByText` by` xpath`: `//*[starts-with(@text,'Test with link: https://status.im/ here should be nothing unusual.')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_reactions, id: 703202

Device 3: Adding one more 'thumbs-up' reaction or removing an added one Device 3: Find Button by accessibility id: emoji-reaction-2 critical/chats/test_group_chat.py:246: in test_group_chat_reactions self.chats[2].add_remove_same_reaction(message=message, emoji="thumbs-up") ../views/chat_view.py:1076: in add_remove_same_reaction element.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 3: Button by accessibility id: `emoji-reaction-2` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot

2. test_group_chat_offline_pn, id: 702808

Device 3: Looking for a message by text: message from old member Device 3: Looking for a message by text: message from new member critical/chats/test_group_chat.py:443: in test_group_chat_offline_pn self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Messages PN was not fetched from offline [[Data delivery issue]] Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot

3. test_group_chat_pin_messages, id: 702732

Test is not run, e2e blocker [[reason: [NOTRUN] Pin feature is in development]]

4. test_group_chat_mute_chat, id: 703495

Device 2: Click until ChatMessageInput by accessibility id: chat-message-input will be presented Device 2: Looking for a message by text: Chat is unmuted now critical/chats/test_group_chat.py:607: in test_group_chat_mute_chat self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) New messages counter near chats tab button is 1 after unmute, but should be 2 Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

Device 2: Find Text by xpath: //*[starts-with(@text,'test message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView Device 2: Text is Delivered critical/chats/test_1_1_public_chats.py:1417: in test_1_1_chat_is_shown_message_sent_delivered_from_offline self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Message was not delivered after resending from offline [[Data delivery issue]] Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_mentions_push_notification, id: 702786

Device 1: Mention user user_2 in the chat Device 1: Find ChatMessageInput by accessibility id: chat-message-input critical/test_public_chat_browsing.py:1151: in test_community_mentions_push_notification self.channel_1.mention_user(self.username_2) ../views/chat_view.py:1208: in mention_user self.chat_message_input.click_inside() ../views/chat_view.py:737: in click_inside location = self.find_element().location /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webelement.py:286: in location old_loc = self._execute(Command.GET_ELEMENT_RECT)["value"] /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webelement.py:395: in _execute return self._parent.execute(command, params) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:345: in execute self.error_handler.check_response(response) /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:122: in check_response raise exception_class(msg=message, stacktrace=format_stacktrace(stacktrace)) The element 'By.accessibilityId: chat-message-input' is not linked to the same object in DOM anymore; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#stale-element-reference-exception E Stacktrace: E io.appium.uiautomator2.common.exceptions.StaleElementReferenceException: The element 'By.accessibilityId: chat-message-input' is not linked to the same object in DOM anymore E at io.appium.uiautomator2.model.ElementsCache.restore(ElementsCache.java:122) E at io.appium.uiautomator2.model.ElementsCache.get(ElementsCache.java:153) E at io.appium.uiautomator2.handler.GetRect.safeHandle(GetRect.java:40) E at io.appium.uiautomator2.handler.request.SafeRequestHandler.handle(SafeRequestHandler.java:59) E at io.appium.uiautomator2.server.AppiumServlet.handleRequest(AppiumServlet.java:277) E at io.appium.uiautomator2.server.AppiumServlet.handleHttpRequest(AppiumServlet.java:271) E at io.appium.uiautomator2.http.ServerHandler.channelRead(ServerHandler.java:68) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352) E at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345) E at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:102) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352) E at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345) E at io.netty.channel.CombinedChannelDuplexHandler$DelegatingChannelHandlerContext.fireChannelRead(CombinedChannelDuplexHandler.java:435) E at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:293) E at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:267) E at io.netty.channel.CombinedChannelDuplexHandler.channelRead(CombinedChannelDuplexHandler.java:250) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352) E at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345) E at io.netty.handler.timeout.IdleStateHandler.channelRead(IdleStateHandler.java:266) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352) E at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345) E at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1294) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352) E at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:911) E at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:131) E at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:611) E at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:552) E at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:466) E at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:438) E at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:140) E at io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:144) E at java.lang.Thread.run(Thread.java:919) [[Issue with username in PN, https://github.com//issues/17396]] Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Passed tests (32)

Click to expand

Class TestActivityMultipleDevicePR:

1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

2. test_navigation_jump_to, id: 702936

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

2. test_activity_center_contact_request_decline, id: 702850

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_emoji_send_copy_paste_reply, id: 702840

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

2. test_community_contact_block_unblock_offline, id: 702894

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

3. test_community_mark_all_messages_as_read, id: 703086

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

4. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

5. test_community_unread_messages_badge, id: 702841

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

6. test_community_message_delete, id: 702839

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

7. test_community_message_send_check_timestamps_sender_username, id: 702838

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

8. test_community_one_image_send_reply, id: 702859

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

9. test_community_message_edit, id: 702843

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

10. test_community_several_images_send_reply, id: 703194

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742

Device sessions Device 1: Steps, video, logs

2. test_community_navigate_to_channel_when_relaunch, id: 702846

Device sessions Device 1: Steps, video, logs

3. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

Device sessions Device 1: Steps, video, logs

4. test_community_undo_delete_message, id: 702869

Device sessions Device 1: Steps, video, logs

5. test_community_mute_community_and_channel, id: 703382

Device sessions Device 1: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_edit_message, id: 702855

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

2. test_1_1_chat_message_reaction, id: 702730

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

4. test_1_1_chat_text_message_delete_push_disappear, id: 702733

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

5. test_1_1_chat_push_emoji, id: 702813

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

6. test_1_1_chat_send_image_save_and_share, id: 703391

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_join_send_text_messages_push, id: 702807

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

2. test_group_chat_send_image_save_and_share, id: 703297

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_mute_chat, id: 703496

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

2. test_1_1_chat_delete_via_long_press_relogin, id: 702784

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_leave, id: 702845

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

2. test_community_markdown_support, id: 702809

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

3. test_community_hashtag_links_to_community_channels, id: 702948

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

[churik]

waiting for @John-44 confirm in chat

[churik]

So it was discussed with @John-44 that eventually we need to show counters like they were in 1-1 chat, sorry for the confusion.
I'm closing original issue #16696 and waiting for the logic how it was working before in this PR (or in new one, as a follow-up)

Thanks!

[pavloburykh]

I'm closing original issue #16696 and waiting for the logic how it was working before in this PR (or in new one, as a follow-up)

@alwx hello! Is there a followup PR that reverts counter logic?