Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: onboarding #17519

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Fix: onboarding #17519

merged 1 commit into from
Oct 5, 2023

Conversation

OmarBasem
Copy link
Contributor

fixes: #17511, #17512

This PR fixes 2 UI bugs in onboarding that were introduced by a recent commit

@OmarBasem OmarBasem self-assigned this Oct 4, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Oct 4, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (4)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ bdafbec #1 2023-10-04 12:54:05 ~5 min android-e2e 🤖apk 📲
✔️ bdafbec #1 2023-10-04 12:54:13 ~5 min android 🤖apk 📲
✔️ bdafbec #1 2023-10-04 12:54:50 ~6 min ios 📱ipa 📲
✔️ bdafbec #1 2023-10-04 12:57:56 ~9 min tests 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 59ec5f7 #2 2023-10-04 16:08:18 ~5 min android-e2e 🤖apk 📲
✔️ 59ec5f7 #2 2023-10-04 16:08:37 ~6 min ios 📱ipa 📲
✔️ 59ec5f7 #2 2023-10-04 16:08:39 ~6 min android 🤖apk 📲
✔️ 59ec5f7 #2 2023-10-04 16:11:13 ~8 min tests 📄log
✔️ 36e56b6 #3 2023-10-05 04:08:21 ~5 min android 🤖apk 📲
✔️ 36e56b6 #3 2023-10-05 04:08:42 ~6 min ios 📱ipa 📲
✔️ 36e56b6 #3 2023-10-05 04:09:55 ~7 min android-e2e 🤖apk 📲
✔️ 36e56b6 #3 2023-10-05 04:12:07 ~9 min tests 📄log

@pavloburykh pavloburykh self-assigned this Oct 4, 2023
@status-im-auto
Copy link
Member

81% of end-end tests have passed

Total executed tests: 43
Failed tests: 8
Passed tests: 35

IDs of failed tests: 702732,702957,703495,703503,702786,702731,702808,702958

Failed tests (8)

Click to expand
  • Rerun failed tests

    • Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731 
    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    2. test_group_chat_mute_chat, id: 703495

    Device 2: Click until ChatMessageInput by accessibility id: chat-message-input will be presented
    Device 2: Looking for a message by text: Chat is unmuted now 

    critical/chats/test_group_chat.py:607: in test_group_chat_mute_chat
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 New messages counter near chats tab button is 1 after unmute, but should be 2



    Device sessions

    3. test_group_chat_offline_pn, id: 702808

    Device 3: Looking for a message by text: message from old member
    Device 3: Looking for a message by text: message from new member 

    critical/chats/test_group_chat.py:443: in test_group_chat_offline_pn
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Messages PN was not fetched from offline

    [[Data delivery issue]]

    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503

    Device 1: Tap on found: Button
    Device 1: Find Button by xpath: //*[@text="Contributors' test community"] 

    critical/test_public_chat_browsing.py:338: in test_community_discovery
    self.home.element_by_text(contributors_test_community_attributes[0]).click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: Button by xpath: `//*[@text="Contributors' test community"]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

    [[Request to Join Community button color issue:17295]]

    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957 

    Test setup failed: base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'

During handling of the above exception, another exception occurred:
medium/test_activity_center.py:293: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:322: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].error += str(e)
E   TypeError: unsupported operand type(s) for +=: 'NoneType' and 'str'



    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958 

    Test setup failed: base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'

During handling of the above exception, another exception occurred:
medium/test_activity_center.py:293: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:322: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].error += str(e)
E   TypeError: unsupported operand type(s) for +=: 'NoneType' and 'str'



    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_mentions_push_notification, id: 702786

    # STEP: Invited member gets push notification with the mention and tap it
    Device 2: Getting PN by 'user_2' 

    critical/test_public_chat_browsing.py:1167: in test_community_mentions_push_notification
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Can not edit a message with a mention
E    Push notification with the mention was not received by the invited member

    [[Issue with username in PN 17396]]

    Device sessions

    Passed tests (35)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    2. test_group_chat_reactions, id: 703202
    Device sessions

    3. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_message_delete, id: 702839
    Device sessions

    7. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    8. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    9. test_community_message_edit, id: 702843
    Device sessions

    10. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    2. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_leave, id: 702845
    Device sessions

    @pavloburykh
    Copy link
    Contributor

    @OmarBasem thanx for fix. Ready for merge.

    @OmarBasem OmarBasem merged commit 1812cfb into develop Oct 5, 2023
    2 checks passed
    @OmarBasem OmarBasem deleted the fix/onboarding branch October 5, 2023 04:26
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @ibrkhalil ibrkhalil ibrkhalil approved these changes

    @Parveshdhull Parveshdhull Parveshdhull approved these changes

    @yqrashawn yqrashawn yqrashawn approved these changes

    Assignees

    @OmarBasem OmarBasem

    @pavloburykh pavloburykh

    Labels
    request-manual-qa Tested - OK
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Broken layout of Create password screen
    6 participants
    @OmarBasem @status-im-auto @pavloburykh @yqrashawn @Parveshdhull @ibrkhalil