-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom linter for i18n/label translation keywords #17610
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
84922a0
Implement custom linter for i18n/label
ilmotta 5465300
Update Nix dependencies for Clojure
ilmotta b541943
Fix all lint errors
ilmotta c75710a
Add babashka clj-kondo config
ilmotta 3ed5545
Use more precise wording
ilmotta 9db641f
Simplify and speed up implementation
ilmotta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{:lint-as {babashka.fs/with-temp-dir clojure.core/let}} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{:hooks {:macroexpand {sci.core/copy-ns sci.core/copy-ns}}} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
(ns sci.core) | ||
|
||
(defmacro copy-ns | ||
([ns-sym sci-ns] | ||
`(copy-ns ~ns-sym ~sci-ns nil)) | ||
([ns-sym sci-ns opts] | ||
`[(quote ~ns-sym) | ||
~sci-ns | ||
(quote ~opts)])) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
{:hooks {:analyze-call {utils.i18n/label hooks.core/i18n-label}} | ||
:linters {:status-im.linter/invalid-translation-keyword {:level :error}}} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
(ns hooks.core | ||
(:require [clj-kondo.hooks-api :as api])) | ||
|
||
(defn i18n-label | ||
"Verify call to `i18n/label` pass the translation keyword qualified with `t`." | ||
[{:keys [node]}] | ||
(let [[_ translation-key-node & _] (:children node)] | ||
(when (and (api/keyword-node? translation-key-node) | ||
(not= "t" (-> translation-key-node api/sexpr namespace))) | ||
(api/reg-finding! (assoc (meta translation-key-node) | ||
:message "Translation keyword should be qualified with \"t\"" | ||
:type :status-im.linter/invalid-translation-keyword))))) | ||
|
||
(comment | ||
;; Valid | ||
(i18n-label {:node (api/parse-string "(i18n/label :t/foo)")}) | ||
|
||
;; Invalid | ||
(i18n-label {:node (api/parse-string "(i18n/label :foo)")})) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: this is the namespace that matters for this PR.