Prevent changing deps outside nix shell #17662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (4)
|
ilmotta
reviewed
Oct 17, 2023
siddarthkay
commented
Oct 17, 2023
jakubgs
approved these changes
Oct 17, 2023
vkjr
approved these changes
Oct 17, 2023
jakubgs
reviewed
Oct 17, 2023
jakubgs
reviewed
Oct 17, 2023
jakubgs
reviewed
Oct 17, 2023
siddarthkay
force-pushed
the
prevent-changing-deps-outside-nix-shell
branch
2 times, most recently
from
f370132 to
7513f2d
Compare
We've often seen cases of devs attempting to change dependencies outside a nix-shell and run into weird side effects This commit stops them from : - updating pods outside a nix shell - updating node deps outside a nix shell This commit also cleanup unused scripts in package.json and adds a fake comment script.
siddarthkay
force-pushed
the
prevent-changing-deps-outside-nix-shell
branch
from
7513f2d to
b91e628
Compare
|
@status-im/mobile-qa : we don't need QA for this PR since its a build change and we don't need to run E2E since these changes won't affect android builds. |
|
This reference was missed: Fixed: 495aee58 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've often seen cases of devs attempting to change dependencies outside a nix-shell and run into weird side effects
I've been guilt of doing this in the past myself.
This PR stops them from :
This PR also cleanup unused scripts in
package.jsonstatus: ready