Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#17288] refactor: migrate previews to new api #17695

Merged
merged 1 commit into from
Oct 23, 2023
Merged

[#17288] refactor: migrate previews to new api #17695

merged 1 commit into from
Oct 23, 2023

Conversation

mohsen-ghafouri
Copy link
Contributor

to accomplish #17288

None of the basic components were touched

migrated preview screens:

  • switcher
  • tabs
  • text-combinations

status: ready

@mohsen-ghafouri mohsen-ghafouri self-assigned this Oct 20, 2023
@mohsen-ghafouri mohsen-ghafouri mentioned this pull request Oct 20, 2023
Closed
@status-im-auto
Copy link
Member

status-im-auto commented Oct 20, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (4)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 54f9fda #1 2023-10-20 08:00:26 ~6 min android 🤖apk 📲
✔️ 54f9fda #1 2023-10-20 08:02:21 ~7 min android-e2e 🤖apk 📲
✔️ 54f9fda #1 2023-10-20 08:03:57 ~9 min tests 📄log
✔️ 54f9fda #1 2023-10-20 08:06:48 ~12 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 1ea3067 #2 2023-10-20 16:14:26 ~5 min android-e2e 🤖apk 📲
✔️ 1ea3067 #2 2023-10-20 16:16:29 ~7 min android 🤖apk 📲
✔️ 1ea3067 #2 2023-10-20 16:18:43 ~9 min tests 📄log
✔️ 1ea3067 #2 2023-10-20 16:19:48 ~11 min ios 📱ipa 📲
✔️ c100e1f #3 2023-10-23 17:18:36 ~5 min android 🤖apk 📲
❌ c100e1f #3 2023-10-23 17:18:37 ~5 min tests 📄log
✔️ c100e1f #3 2023-10-23 17:18:42 ~5 min android-e2e 🤖apk 📲
✔️ c100e1f #3 2023-10-23 17:18:42 ~5 min ios 📱ipa 📲
✔️ c100e1f #4 2023-10-23 17:35:35 ~8 min tests 📄log

ilmotta
ilmotta approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@ilmotta ilmotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

src/status_im2/contexts/quo_preview/tabs/tabs.cljs Outdated Show resolved Hide resolved
src/status_im2/contexts/quo_preview/tabs/segmented_tab.cljs Outdated Show resolved Hide resolved
@mohsen-ghafouri mohsen-ghafouri force-pushed the migrate/previews-part-six branch from 54f9fda to 1ea3067 Compare October 20, 2023 16:08
@mohsen-ghafouri
Copy link
Contributor Author

@status-im/mobile-qa the changes are just related to quo2 preview screens. just some code improvement

@status-im-auto
Copy link
Member

91% of end-end tests have passed

Total executed tests: 45
Failed tests: 0
Expected to fail tests: 4
Passed tests: 41

IDs of expected to fail tests: 702732,702783,702731,702808

Expected to fail tests (4)

Click to expand

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

Device 2: Find `Text` by `xpath`: `//*[starts-with(@text,'test message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView`
Device 2: `Text` is `Sent` 

critical/chats/test_1_1_public_chats.py:601: in test_1_1_chat_is_shown_message_sent_delivered_from_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message status was not changed to Delivered, it's Sent after back up online!

[[Data delivery issue]]

Device sessions

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_pin_messages, id: 702731 

Test is not run, e2e blocker

[[reason: [NOTRUN] Pin feature is in development]]

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732 

Test is not run, e2e blocker

[[reason: [NOTRUN] Pin feature is in development]]

2. test_group_chat_offline_pn, id: 702808

Device 3: Looking for a message by text: message from old member
Device 3: Looking for a message by text: message from new member 

critical/chats/test_group_chat.py:309: in test_group_chat_offline_pn
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Messages PN was not fetched from offline

[[Data delivery issue]]

Device sessions

Passed tests (41)

Click to expand

Class TestActivityMultipleDevicePR:

1. test_navigation_jump_to, id: 702936
Device sessions

2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions

Class TestCommunityMultipleDeviceMerged:

1. test_community_several_images_send_reply, id: 703194
Device sessions

2. test_community_one_image_send_reply, id: 702859
Device sessions

3. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions

4. test_community_mark_all_messages_as_read, id: 703086
Device sessions

5. test_community_contact_block_unblock_offline, id: 702894
Device sessions

6. test_community_message_delete, id: 702839
Device sessions

7. test_community_message_send_check_timestamps_sender_username, id: 702838
Device sessions

8. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions

9. test_community_message_edit, id: 702843
Device sessions

10. test_community_unread_messages_badge, id: 702841
Device sessions

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_mentions, id: 702957
Device sessions

2. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions

2. test_1_1_chat_mute_chat, id: 703496
Device sessions

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions

2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions

3. test_community_discovery, id: 703503
Device sessions

4. test_community_undo_delete_message, id: 702869
Device sessions

5. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions

6. test_community_mute_community_and_channel, id: 703382
Device sessions

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_add_contact_field_validation, id: 702777
Device sessions

2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions

3. test_activity_center_contact_request_decline, id: 702850
Device sessions

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions

2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions

3. test_1_1_chat_push_emoji, id: 702813
Device sessions

4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions

5. test_1_1_chat_edit_message, id: 702855
Device sessions

6. test_1_1_chat_send_image_save_and_share, id: 703391
Device sessions

7. test_1_1_chat_message_reaction, id: 702730
Device sessions

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_mute_chat, id: 703495
Device sessions

2. test_group_chat_send_image_save_and_share, id: 703297
Device sessions

3. test_group_chat_reactions, id: 703202
Device sessions

4. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_markdown_support, id: 702809
Device sessions

2. test_community_hashtag_links_to_community_channels, id: 702948
Device sessions

3. test_community_mentions_push_notification, id: 702786
Device sessions

4. test_community_leave, id: 702845
Device sessions

5. test_community_join_when_node_owner_offline, id: 703629
Device sessions

@mohsen-ghafouri mohsen-ghafouri force-pushed the migrate/previews-part-six branch from 1ea3067 to c100e1f Compare October 23, 2023 17:12
@mohsen-ghafouri
Copy link
Contributor Author

The same as other part of refactoring preview screens that didn't require any manual QA i will skip this step.

@mohsen-ghafouri mohsen-ghafouri merged commit c42fc51 into develop Oct 23, 2023
2 checks passed
@mohsen-ghafouri mohsen-ghafouri deleted the migrate/previews-part-six branch October 23, 2023 17:40
yevh-berdnyk pushed a commit that referenced this pull request Dec 8, 2023
@mohsen-ghafouri @yevh-berdnyk
[#17288] refactor: migrate previews to new api (#17695)
1e7296d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilmotta ilmotta ilmotta approved these changes

@alwx alwx Awaiting requested review from alwx

@FFFra FFFra Awaiting requested review from FFFra

Assignees

@mohsen-ghafouri mohsen-ghafouri

Labels
None yet
Projects
Pipeline for QA
Archived in project
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mohsen-ghafouri @status-im-auto @ilmotta