-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use timesource(synced) to generate/validate server cert time #17771
Conversation
Jenkins BuildsClick to see older builds (16)
|
80% of end-end tests have passed
Failed tests (6)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Expected to fail tests (3)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Passed tests (36)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePRTwo:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much!
I think that'll fix the issue that I assigned to myself that's related to syncing
Hi @qfrank could you please rebase this status go https://github.com/status-im/status-go/tree/chore/use-timesource-to-generate-cert PR? |
23b3309
to
bf10622
Compare
done @VolodLytvynenko |
Hi @qfrank thank you for PR. Unfortunatly the issue is still reproduced for me. ISSUE 1: Failed sync after changing date on deviceSteps to Reproduce:
Actual Result:The sync process fails Expected Result:The sync should be successful even after changing the date Logs:Device:
|
Hi @VolodLytvynenko , can you provide both device logs so that i can check the time? thank you. Also this PR should only be tested on mobile devices, and each mobile device should use the same version with this PR, no desktop! |
@qfrank Here are the logs: Case 1:IOS device logs. This device generates the QR (this device set +1 hour) Android device logs. This device scans the QR (This device has automaticall set up for date) Case 2:Android device logs. This device generates the QR (This device has -1 hour) IOS device logs. This device scans the QR (This device has automaticall set up for date) |
84% of end-end tests have passed
Failed tests (4)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Expected to fail tests (3)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Passed tests (38)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
|
bf10622
to
a2410c0
Compare
should be fixed now 🙂 @VolodLytvynenko |
84% of end-end tests have passed
Failed tests (4)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Expected to fail tests (3)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Passed tests (38)Click to expandClass TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
Hi @qfrank unfortunately the issue is still reproduced: CASE 1:
Android logs: IOS logs: CASE 2:
Android logs: IOS logs: CASE 3:
IOS logs: Android logs: |
Were you changing system time while keep status app opened? |
@qfrank Just checked it one more time.
Actual result:
IOS logs: Android logs: Additional info:I thought it might be a network issue, and after setting date as automatically, the sync was successful |
a2410c0
to
bd25cf6
Compare
@qfrank @VolodLytvynenko |
bd25cf6
to
3f23728
Compare
73% of end-end tests have passed
Failed tests (9)Click to expandClass TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Expected to fail tests (3)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (33)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePR:
|
78% of end-end tests have passed
Failed tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Expected to fail tests (1)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (7)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
|
@qfrank Thank you for your work and for your patience. The PR is ready to be merged |
3f23728
to
cdd5bcd
Compare
fixes issue
Platforms
Areas that maybe impacted
local pair
Steps to test
status: ready