Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#17288] refactor: migrate previews to new api #17776

Merged
merged 1 commit into from
Nov 1, 2023
Merged

[#17288] refactor: migrate previews to new api #17776

merged 1 commit into from
Nov 1, 2023

Conversation

mohsen-ghafouri
Copy link
Contributor

@mohsen-ghafouri mohsen-ghafouri commented Oct 31, 2023 •
edited
Loading

fixes #17288

Last part of refactoring, None of the basic components were touched

migrated preview screens:

  • wallet
  • some components renaming

status: ready

@mohsen-ghafouri mohsen-ghafouri self-assigned this Oct 31, 2023
@mohsen-ghafouri mohsen-ghafouri force-pushed the migrate/previews-part-final branch from 8b766ee to d2e3b91 Compare October 31, 2023 11:49
@mohsen-ghafouri mohsen-ghafouri mentioned this pull request Oct 31, 2023
Closed
@status-im-auto
Copy link
Member

status-im-auto commented Oct 31, 2023 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ d2e3b91 #2 2023-10-31 11:55:12 ~5 min android 🤖apk 📲
✔️ d2e3b91 #2 2023-10-31 11:57:18 ~7 min android-e2e 🤖apk 📲
✔️ d2e3b91 #2 2023-10-31 11:59:17 ~9 min tests 📄log
✔️ d2e3b91 #2 2023-10-31 12:04:44 ~15 min ios 📱ipa 📲
✔️ 2735263 #3 2023-11-01 04:47:49 ~5 min android 🤖apk 📲
✔️ 2735263 #3 2023-11-01 04:48:10 ~5 min android-e2e 🤖apk 📲
✔️ 2735263 #3 2023-11-01 04:52:11 ~9 min tests 📄log
✔️ 2735263 #3 2023-11-01 04:54:49 ~12 min ios 📱ipa 📲

@J-Son89
Copy link
Contributor

J-Son89 commented Oct 31, 2023

Nice work @mohsen-ghafouri!! 🙌

ilmotta
ilmotta approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@ilmotta ilmotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah the power of discipline to refactor in steps! Thanks @mohsen-ghafouri

@mohsen-ghafouri mohsen-ghafouri force-pushed the migrate/previews-part-final branch from d2e3b91 to 2735263 Compare November 1, 2023 04:42
@mohsen-ghafouri
Copy link
Contributor Author

@status-im/mobile-qa The same as other part of refactoring preview screens that didn't require any manual QA i will skip this step. this is the last part of refactoring for preview screens 🤞🏻

@status-im-auto
Copy link
Member

64% of end-end tests have passed

Total executed tests: 45
Failed tests: 14
Expected to fail tests: 2
Passed tests: 29

IDs of failed tests: 702733,702813,703133,703495,702742,703297,702869,703202,703391,702786,702846,702807,702808,703629 

IDs of expected to fail tests: 702732,702731

Failed tests (14)

Click to expand
  • Rerun failed tests

    • Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

    # STEP: Check that can login with different user
    Device 1: Find `Button` by `accessibility id`: `show-profiles` 

    critical/chats/test_public_chat_browsing.py:251: in test_restore_multiaccount_with_waku_backup_remove_switch
    self.sign_in.show_profiles_button.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: Button by accessibility id: `show-profiles` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742

    Device 1: ChatMessageInput element not found
    Device 1: Sending message 'mmmeowesage_text' 

    critical/chats/test_public_chat_browsing.py:91: in test_community_copy_and_paste_message_in_chat_input
    self.channel.send_message(message)
../views/chat_view.py:1001: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:121: in wait_for_element
    raise TimeoutException(
 Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element



    Device sessions

    3. test_community_undo_delete_message, id: 702869

    Device 1: ChatMessageInput element not found
    Device 1: Sending message 'message to delete and undo' 

    critical/chats/test_public_chat_browsing.py:106: in test_community_undo_delete_message
    self.channel.send_message(message_to_delete)
../views/chat_view.py:1001: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:121: in wait_for_element
    raise TimeoutException(
 Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element



    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846

    Device 1: ChatMessageInput element not found
    Device 1: Sending message 'some_text' 

    critical/chats/test_public_chat_browsing.py:77: in test_community_navigate_to_channel_when_relaunch
    self.channel.send_message(text_message)
../views/chat_view.py:1001: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:121: in wait_for_element
    raise TimeoutException(
 Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element



    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495 

    Test setup failed: critical/chats/test_group_chat.py:73: in prepare_devices
    self.chats[0].send_message(self.message_before_adding)
../views/chat_view.py:1001: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:121: in wait_for_element
    raise TimeoutException(
 Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element



    2. test_group_chat_send_image_save_and_share, id: 703297 

    Test setup failed: critical/chats/test_group_chat.py:73: in prepare_devices
    self.chats[0].send_message(self.message_before_adding)
../views/chat_view.py:1001: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:121: in wait_for_element
    raise TimeoutException(
 Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element



    3. test_group_chat_reactions, id: 703202 

    Test setup failed: critical/chats/test_group_chat.py:73: in prepare_devices
    self.chats[0].send_message(self.message_before_adding)
../views/chat_view.py:1001: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:121: in wait_for_element
    raise TimeoutException(
 Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element



    4. test_group_chat_join_send_text_messages_push, id: 702807

    ## Group chat nizywxy is created successfully!
    Device 1: Sending message 'message before adding new user' 

    Test setup failed: critical/chats/test_group_chat.py:73: in prepare_devices
    self.chats[0].send_message(self.message_before_adding)
../views/chat_view.py:1001: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:121: in wait_for_element
    raise TimeoutException(
 Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element



    Device sessions

    5. test_group_chat_offline_pn, id: 702808 

    Test setup failed: critical/chats/test_group_chat.py:73: in prepare_devices
    self.chats[0].send_message(self.message_before_adding)
../views/chat_view.py:1001: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:121: in wait_for_element
    raise TimeoutException(
 Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element

    [[Data delivery issue]]

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733

    Device 1: Find Button by accessibility id: jump-to 

    critical/chats/test_1_1_public_chats.py:458: in test_1_1_chat_text_message_delete_push_disappear
    self.chat_1.jump_to_card_by_text(self.username_2)
../views/base_view.py:647: in jump_to_card_by_text
    self.click_on_floating_jump_to()
../views/base_view.py:636: in click_on_floating_jump_to
    self.jump_to_button.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: Button by accessibility id: `jump-to` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    2. test_1_1_chat_push_emoji, id: 702813

    Device 1: App to background
    Device 2: Sending message 'emoji' 

    critical/chats/test_1_1_public_chats.py:345: in test_1_1_chat_push_emoji
    chat_2.send_message(emoji.emojize(emoji_message))
../views/chat_view.py:1001: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:121: in wait_for_element
    raise TimeoutException(
 Device `2`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element



    Device sessions

    3. test_1_1_chat_send_image_save_and_share, id: 703391

    Device 1: Tap on found: Button
    Device 1: Find BaseElement by accessibility id: toast-content 

    critical/chats/test_1_1_public_chats.py:433: in test_1_1_chat_send_image_save_and_share
    toast_element_text = toast_element.text
../views/base_element.py:228: in text
    return self.find_element().text
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: BaseElement by accessibility id: `toast-content` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_mentions_push_notification, id: 702786

    Device 2: Getting PN by 'user_2'
    Device 2: Looking for a message by text: user_2 

    critical/chats/test_public_chat_browsing.py:897: in test_community_mentions_push_notification
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Channel did not open by clicking on a notification with the mention for admin
E    Edited message is not shown correctly for the sender
E    Edited message is not shown correctly for the (receiver) admin
E    Channel did not open by clicking on a notification with the mention for the invited member



    Device sessions

    2. test_community_join_when_node_owner_offline, id: 703629

    Device 2: Tap on found: Button
    Device 2: Looking for community: 'open community' 

    critical/chats/test_public_chat_browsing.py:1105: in test_community_join_when_node_owner_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Joined status is not displayed
E    open community is not listed inside Joined communities tab



    Device sessions

    Expected to fail tests (2)

    Click to expand

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Passed tests (29)

    Click to expand

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_message_delete, id: 702839
    Device sessions

    7. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    8. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    9. test_community_message_edit, id: 702843
    Device sessions

    10. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    3. test_1_1_chat_edit_message, id: 702855
    Device sessions

    4. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_leave, id: 702845
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503
    Device sessions

    2. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    @mohsen-ghafouri mohsen-ghafouri merged commit 233d1b3 into develop Nov 1, 2023
    6 of 7 checks passed
    @mohsen-ghafouri mohsen-ghafouri deleted the migrate/previews-part-final branch November 1, 2023 08:31
    yevh-berdnyk pushed a commit that referenced this pull request Dec 8, 2023
    @mohsen-ghafouri @yevh-berdnyk
    [#17288] refactor: migrate previews to new api (#17776)
    c94df4d
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @OmarBasem OmarBasem OmarBasem approved these changes

    @J-Son89 J-Son89 J-Son89 approved these changes

    @ilmotta ilmotta ilmotta approved these changes

    @ibrkhalil ibrkhalil Awaiting requested review from ibrkhalil

    Assignees

    @mohsen-ghafouri mohsen-ghafouri

    Labels
    None yet
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    migrated preview screens to use the new api
    5 participants
    @mohsen-ghafouri @status-im-auto @J-Son89 @ilmotta @OmarBasem