Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: ignore auto generated lint-fix files #17783

Merged
merged 1 commit into from
Nov 10, 2023
Merged

chore: ignore auto generated lint-fix files #17783

merged 1 commit into from
Nov 10, 2023

Conversation

siddarthkay
Copy link
Contributor

@siddarthkay siddarthkay commented Nov 1, 2023 •
edited
Loading

We get these 2 files auto generated locally as part of make lint-fix

  • .clj-kondo/taoensso/encore/config.edn
  • .clj-kondo/taoensso/encore/taoensso/encore.clj

These ideally don't belong inside the repository.

This PR gitIgnores them for good.

Testing notes

Doesn't require testing, this PR adds dot files related to linting

status: ready

@siddarthkay siddarthkay self-assigned this Nov 1, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Nov 1, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (16)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 56bf96e #1 2023-11-01 03:20:51 ~2 min tests 📄log
✔️ 56bf96e #1 2023-11-01 03:23:57 ~5 min android 🤖apk 📲
✔️ 56bf96e #1 2023-11-01 03:24:01 ~5 min android-e2e 🤖apk 📲
✔️ 56bf96e #1 2023-11-01 03:24:12 ~6 min ios 📱ipa 📲
✔️ bd888c2 #2 2023-11-01 03:50:08 ~5 min android 🤖apk 📲
✔️ bd888c2 #2 2023-11-01 03:50:15 ~5 min ios 📱ipa 📲
✔️ bd888c2 #2 2023-11-01 03:51:54 ~7 min android-e2e 🤖apk 📲
✔️ bd888c2 #2 2023-11-01 03:54:31 ~9 min tests 📄log
✔️ 37b139f #3 2023-11-06 18:09:29 ~5 min ios 📱ipa 📲
✔️ 37b139f #3 2023-11-06 18:09:45 ~5 min android 🤖apk 📲
✔️ 37b139f #3 2023-11-06 18:10:09 ~6 min android-e2e 🤖apk 📲
✔️ 37b139f #3 2023-11-06 18:13:33 ~9 min tests 📄log
✔️ 93197a8 #4 2023-11-10 09:49:32 ~7 min ios 📱ipa 📲
✔️ 93197a8 #4 2023-11-10 09:52:20 ~10 min android-e2e 🤖apk 📲
✔️ 93197a8 #4 2023-11-10 09:52:23 ~10 min tests 📄log
✔️ 93197a8 #4 2023-11-10 09:52:36 ~10 min android 🤖apk 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 7753742 #5 2023-11-10 10:04:06 ~2 min tests 📄log
✔️ 7753742 #5 2023-11-10 10:08:12 ~6 min android-e2e 🤖apk 📲
✔️ 7753742 #5 2023-11-10 10:08:20 ~6 min ios 📱ipa 📲
✔️ 7753742 #5 2023-11-10 10:08:24 ~6 min android 🤖apk 📲
✔️ d35f78b #7 2023-11-10 12:29:57 ~5 min android 🤖apk 📲
✔️ d35f78b #7 2023-11-10 12:32:43 ~8 min android-e2e 🤖apk 📲
✔️ d35f78b #7 2023-11-10 12:33:49 ~9 min tests 📄log
✔️ d35f78b #7 2023-11-10 12:39:13 ~15 min ios 📱ipa 📲

@siddarthkay
Copy link
Contributor Author

lol, tests fail with :D

Formatting required in file .clj-kondo/taoensso/encore/taoensso/encore.clj

@siddarthkay siddarthkay closed this Nov 1, 2023
@siddarthkay siddarthkay reopened this Nov 1, 2023
@siddarthkay
Copy link
Contributor Author

I'll wait for @ilmotta's go ahead before merging this PR.

@status-im-auto
Copy link
Member

84% of end-end tests have passed

Total executed tests: 45
Failed tests: 3
Expected to fail tests: 4
Passed tests: 38

IDs of failed tests: 702813,702786,702807 

IDs of expected to fail tests: 702732,702783,702731,702808

Failed tests (3)

Click to expand
  • Rerun failed tests

    • Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_push_emoji, id: 702813

    Device 1: App to background
    Device 2: Sending message 'emoji' 

    critical/chats/test_1_1_public_chats.py:345: in test_1_1_chat_push_emoji
    chat_2.send_message(emoji.emojize(emoji_message))
../views/chat_view.py:1001: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:121: in wait_for_element
    raise TimeoutException(
 Device `2`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element



    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_mentions_push_notification, id: 702786

    Device 2: Getting PN by 'user_2'
    Device 2: Looking for a message by text: user_2 

    critical/chats/test_public_chat_browsing.py:897: in test_community_mentions_push_notification
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Channel did not open by clicking on a notification with the mention for admin
E    Edited message is not shown correctly for the sender
E    Edited message is not shown correctly for the (receiver) admin
E    Channel did not open by clicking on a notification with the mention for the invited member



    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807

    Device 2: Text is Delivered
    Device 1: Looking for a message by text: Hey, admin! 

    critical/chats/test_group_chat.py:97: in test_group_chat_join_send_text_messages_push
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message Hey, admin! was not received by admin



    Device sessions

    Expected to fail tests (4)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

    Device 2: Find Text by xpath: //*[starts-with(@text,'test message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
    Device 2: Text is Sent 

    critical/chats/test_1_1_public_chats.py:617: in test_1_1_chat_is_shown_message_sent_delivered_from_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message status was not changed to Delivered, it's Sent after back up online!

    [[Data delivery issue]]

    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    2. test_group_chat_offline_pn, id: 702808

    Device 3: Looking for a message by text: message from old member
    Device 3: Looking for a message by text: message from new member 

    critical/chats/test_group_chat.py:323: in test_group_chat_offline_pn
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Messages PN was not fetched from offline

    [[Data delivery issue]]

    Device sessions

    Passed tests (38)

    Click to expand

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_leave, id: 702845
    Device sessions

    4. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_message_delete, id: 702839
    Device sessions

    7. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    8. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    9. test_community_message_edit, id: 702843
    Device sessions

    10. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_discovery, id: 703503
    Device sessions

    4. test_community_undo_delete_message, id: 702869
    Device sessions

    5. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    6. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_edit_message, id: 702855
    Device sessions

    5. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    6. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    @ilmotta
    Copy link
    Contributor

    ilmotta commented Nov 1, 2023

    @siddarthkay, I noticed this formatting problem happening a few times in the past with certain libraries. Our zprint rules disagree with the clj-kondo files added to the repo automatically.

    I think we should just tell zprint to ignore whatever is inside .clj-kondo/, except the .clj-kondo/config.edn file and the directory .cljs-kondo/status-im/, all the rest are code outside our control.

    @siddarthkay siddarthkay force-pushed the add-missing-lint-files branch from bd888c2 to 37b139f Compare November 6, 2023 18:03
    @siddarthkay
    Copy link
    Contributor Author

    siddarthkay commented Nov 10, 2023 •
    edited
    Loading

    I think we should just tell zprint to ignore whatever is inside .clj-kondo/, except the .clj-kondo/config.edn file and the directory .cljs-kondo/status-im/

    True!
    It would be ideal if these files are ignored.

    • .clj-kondo/taoensso/encore/config.edn
    • .clj-kondo/taoensso/encore/taoensso/encore.clj

    For now I think its fine to just check in these files.
    I tried locally deleting these files and every time we run make lint-fix they're auto generated if they do not exist.

    We'll rarely touch these files and they may only get modified if and when we upgrade these dependencies, so it seems fair enough to check them in now, while we find a more robust solution for this later :)

    Thanks @ilmotta

    @siddarthkay siddarthkay force-pushed the add-missing-lint-files branch 2 times, most recently from 93197a8 to 7753742 Compare November 10, 2023 10:01
    @siddarthkay
    Copy link
    Contributor Author

    Hmmm I am not fully convinced that checking in these is a good idea just yet.
    I tried running make lint-fix on my linux and the formatting for that is different on this file specifically
    .clj-kondo/taoensso/encore/taoensso/encore.clj
    so this file will always be different when someone runs make lint-fix from linux vs macOS.
    Also our CI runs this command on linux so I need to investigate further on what that is :)

    @siddarthkay siddarthkay marked this pull request as draft November 10, 2023 10:19
    @vkjr
    Copy link
    Contributor

    vkjr commented Nov 10, 2023

    @siddarthkay, sorry if I missed the conversation and that was already discussed, but can't we just put these 2 files to .gitignore?

    @siddarthkay
    Copy link
    Contributor Author

    but can't we just put these 2 files to .gitignore

    I was indeed considering this as a solution.

    @siddarthkay
    Copy link
    Contributor Author

    Seems to be simpler to just .gitignore the following paths :

    • .clj-kondo/taoensso/
    • .clj-kondo/babashka/

    What say @ilmotta ?

    @siddarthkay siddarthkay force-pushed the add-missing-lint-files branch from 7753742 to 51821d8 Compare November 10, 2023 12:22
    @siddarthkay
    chore: add missing lint-fix files
    d35f78b 
    We get these 2 files auto generated locally as part of make lint-fix

`.clj-kondo/taoensso/encore/config.edn`
`.clj-kondo/taoensso/encore/taoensso/encore.clj`

We don't need them checked in its fine if they're ignored.
    @siddarthkay siddarthkay force-pushed the add-missing-lint-files branch from 51821d8 to d35f78b Compare November 10, 2023 12:23
    @siddarthkay siddarthkay changed the title chore: add missing lint-fix files chore: ignore auto generated lint-fix files Nov 10, 2023
    @siddarthkay siddarthkay marked this pull request as ready for review November 10, 2023 12:33
    @siddarthkay siddarthkay merged commit 3c297bf into develop Nov 10, 2023
    6 checks passed
    @siddarthkay siddarthkay deleted the add-missing-lint-files branch November 10, 2023 12:42
    @ilmotta
    Copy link
    Contributor

    ilmotta commented Nov 13, 2023

    @siddarthkay, @vkjr, ignoring them is not the most correct approach. Ideally we should just not format them, but still version control them.

    From clj-kondo's author:

    "I think it’s good to have them, just not in the version control as they get created automatically and don’t need versioning."

    clj-kondo's author reply: This isn't true. They are only copied from the dependencies because lsp does this. If you want to have the same linting in CI, it's good to version those things into version control.

    The recommended way is to include them into version control, so everyone who uses clj-kondo with this repo gets exactly the same linting, whether you use lsp or not

    -- https://clojurians-log.clojureverse.org/clj-kondo/2022-03-18

    @siddarthkay
    Copy link
    Contributor Author

    siddarthkay commented Nov 20, 2023 •
    edited
    Loading

    Thanks for the input and references @ilmotta !
    I have created an issue to track this! thanks for the references :)

    @siddarthkay siddarthkay mentioned this pull request Nov 20, 2023
    Closed
    yevh-berdnyk pushed a commit that referenced this pull request Dec 8, 2023
    @siddarthkay @yevh-berdnyk
    chore: ignore auto generated lint-fix files (#17783)
    08b5644 
    We get these 2 files auto generated locally as part of make lint-fix

`.clj-kondo/taoensso/encore/config.edn`
`.clj-kondo/taoensso/encore/taoensso/encore.clj`

We don't need them checked in its fine if they're ignored.
This commit adds these folders to `.gitIgnore`

- `.clj-kondo/taoensso/`
- `.clj-kondo/babashka/`
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @OmarBasem OmarBasem OmarBasem approved these changes

    @J-Son89 J-Son89 J-Son89 approved these changes

    @vkjr vkjr vkjr approved these changes

    @ilmotta ilmotta Awaiting requested review from ilmotta

    @flexsurfer flexsurfer Awaiting requested review from flexsurfer

    Assignees

    @siddarthkay siddarthkay

    Labels
    None yet
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    6 participants
    @siddarthkay @status-im-auto @ilmotta @vkjr @J-Son89 @OmarBasem