Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#17897] Add channel-name component #17903

Merged
merged 1 commit into from
Nov 22, 2023
Merged

[#17897] Add channel-name component #17903

merged 1 commit into from
Nov 22, 2023

Conversation

ulisesmac
Copy link
Contributor

fixes #17897

Summary

Add the channel name component and its tests.

image

figma

Platforms

  • Android
  • iOS

Steps to test

  • Open Status
  • Navigate to Quo2 preview -> text combinations -> channel-name

status: ready

@ulisesmac ulisesmac self-assigned this Nov 14, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Nov 14, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (4)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 63c88d6 #1 2023-11-14 22:35:11 ~6 min android-e2e 🤖apk 📲
✔️ 63c88d6 #1 2023-11-14 22:38:22 ~9 min android 🤖apk 📲
✔️ 63c88d6 #1 2023-11-14 22:38:30 ~9 min tests 📄log
✔️ 63c88d6 #1 2023-11-14 22:48:53 ~20 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 75bbd10 #2 2023-11-22 19:43:53 ~6 min ios 📱ipa 📲
✔️ 75bbd10 #2 2023-11-22 19:47:43 ~10 min android 🤖apk 📲
✔️ 75bbd10 #2 2023-11-22 19:48:08 ~10 min android-e2e 🤖apk 📲
✔️ 75bbd10 #2 2023-11-22 19:48:55 ~11 min tests 📄log
✔️ d2682b6 #3 2023-11-22 20:04:20 ~5 min android-e2e 🤖apk 📲
✔️ d2682b6 #3 2023-11-22 20:06:49 ~8 min android 🤖apk 📲
✔️ d2682b6 #3 2023-11-22 20:10:16 ~11 min ios 📱ipa 📲
✔️ d2682b6 #4 2023-11-22 21:42:32 ~10 min tests 📄log

@ulisesmac
Copy link
Contributor Author

Notes for QA

This component doesn't need to be tested since it's a new one, still not used in the app. I think you should only check the result of E2E test

@status-im-auto
Copy link
Member

80% of end-end tests have passed

Total executed tests: 45
Failed tests: 6
Expected to fail tests: 3
Passed tests: 36

IDs of failed tests: 702733,703133,702948,702745,703503,702855 

IDs of expected to fail tests: 702732,702731,702808

Failed tests (6)

Click to expand
  • Rerun failed tests

    • Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733

    Device 2: Find `Text` by `xpath`: `//*[starts-with(@text,'smth I should edit')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']`
    Device 2: Tap on found: Text 

    critical/chats/test_1_1_public_chats.py:468: in test_1_1_chat_text_message_delete_push_disappear
    self.chat_2.chat_element_by_text(message_after_edit_1_1).wait_for_status_to_be("Delivered")
../views/chat_view.py:240: in wait_for_status_to_be
    raise TimeoutException("Message status was not changed to %s, it's %s" % (expected_status, current_status))
 Message status was not changed to Delivered, it's; 
 RemoteDisconnected



    Device sessions

    2. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

    Device 2: Looking for a message by text: hello
    Device 2: Find TimeStampText by xpath: //*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-timestamp'] 

    critical/chats/test_1_1_public_chats.py:296: in test_1_1_chat_non_latin_messages_stack_update_profile_photo
    'Timestamp on message %s does not correspond expected [%s]' % (timestamp, *sent_time_variants))
 not all arguments converted during string formatting



    Device sessions

    3. test_1_1_chat_edit_message, id: 702855

    Device 2: Find Text by xpath: //*[starts-with(@text,'Message before edit 1-1')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']
    Device 2: Tap on found: Text 

    critical/chats/test_1_1_public_chats.py:380: in test_1_1_chat_edit_message
    self.chat_2.chat_element_by_text(message_before_edit_1_1).wait_for_status_to_be("Delivered")
../views/chat_view.py:240: in wait_for_status_to_be
    raise TimeoutException("Message status was not changed to %s, it's %s" % (expected_status, current_status))
 Message status was not changed to Delivered, it's; 
 RemoteDisconnected



    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

    # STEP: Check that can remove user from logged out state
    Device 1: Find Button by accessibility id: show-profiles 

    critical/chats/test_public_chat_browsing.py:260: in test_restore_multiaccount_with_waku_backup_remove_switch
    self.sign_in.show_profiles_button.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: Button by accessibility id: `show-profiles` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    2. test_community_discovery, id: 703503

    Device 1: Find Button by accessibility id: communities-home-discover-card
    Device 1: Tap on found: Button 

    critical/chats/test_public_chat_browsing.py:40: in test_community_discovery
    self.home.community_card_item.wait_for_visibility_of_element(30)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 1: BaseElement by accessibility id:`community-card-item` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_hashtag_links_to_community_channels, id: 702948

    Device 1: ChatMessageInput element not found
    Device 1: Sending message 'Where is a cat?' 

    critical/chats/test_public_chat_browsing.py:1005: in test_community_hashtag_links_to_community_channels
    self.channel_1.send_message(cats_message)
../views/chat_view.py:1003: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:121: in wait_for_element
    raise TimeoutException(
 Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element; 
 RemoteDisconnected



    Device sessions

    Expected to fail tests (3)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    2. test_group_chat_offline_pn, id: 702808

    Device 3: Looking for a message by text: message from old member
    Device 3: Looking for a message by text: message from new member 

    critical/chats/test_group_chat.py:323: in test_group_chat_offline_pn
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Messages PN was not fetched from offline

    [[Data delivery issue]]

    Device sessions

    Passed tests (36)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    3. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    4. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_message_delete, id: 702839
    Device sessions

    7. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    8. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    9. test_community_message_edit, id: 702843
    Device sessions

    10. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_mentions_push_notification, id: 702786
    Device sessions

    3. test_community_leave, id: 702845
    Device sessions

    4. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    4. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_undo_delete_message, id: 702869
    Device sessions

    3. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    4. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    briansztamfater
    briansztamfater reviewed Nov 16, 2023
    View reviewed changes
    src/quo/components/text_combinations/channel_name/view.cljs
    [text/text
    {:size :heading-1
    :weight :semi-bold}
    (str "# " channel-name)]
    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Wondering if we should put the hashtag symbol at the end for RTL languages. We should revisit this in the future when we start adding new languages to the app.

    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Yes, interesting.

    All the channel names should change if so 🤔 I'm wondering the same.

    Francesca-G
    Francesca-G approved these changes Nov 16, 2023
    View reviewed changes
    Copy link

    @Francesca-G Francesca-G left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Looks good ✨

    @pavloburykh
    Copy link
    Contributor

    @ulisesmac thanx for the PR! Failed e2e are not PR related. Ready for merge.

    @ulisesmac ulisesmac force-pushed the 17897-text-combinations-channel-name branch from 63c88d6 to 75bbd10 Compare November 22, 2023 19:36
    @ulisesmac ulisesmac force-pushed the 17897-text-combinations-channel-name branch from 75bbd10 to d2682b6 Compare November 22, 2023 19:58
    @ulisesmac ulisesmac merged commit 279993b into develop Nov 22, 2023
    6 checks passed
    @ulisesmac ulisesmac deleted the 17897-text-combinations-channel-name branch November 22, 2023 21:54
    yevh-berdnyk pushed a commit that referenced this pull request Dec 8, 2023
    @ulisesmac @yevh-berdnyk
    Add channel-name component (#17903)
    4409424
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @Francesca-G Francesca-G Francesca-G approved these changes

    @OmarBasem OmarBasem OmarBasem approved these changes

    @J-Son89 J-Son89 J-Son89 approved these changes

    @ajayesivan ajayesivan ajayesivan approved these changes

    @briansztamfater briansztamfater briansztamfater approved these changes

    @smohamedjavid smohamedjavid Awaiting requested review from smohamedjavid

    Assignees

    @ulisesmac ulisesmac

    Labels
    None yet
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Text combinations - Channel name component
    8 participants
    @ulisesmac @status-im-auto @pavloburykh @briansztamfater @ajayesivan @J-Son89 @OmarBasem @Francesca-G