Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#17854] [IOS] The tutorial video animation keeps playing after openi… #17915

Merged
merged 2 commits into from
Nov 15, 2023
Merged

[#17854] [IOS] The tutorial video animation keeps playing after openi… #17915

merged 2 commits into from
Nov 15, 2023

Conversation

flexsurfer
Copy link
Member

@flexsurfer flexsurfer commented Nov 15, 2023 •
edited
Loading

fixes: #17854

@flexsurfer flexsurfer self-assigned this Nov 15, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Nov 15, 2023 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ ca3500e #1 2023-11-15 13:24:17 ~10 min android 🤖apk 📲
✔️ ca3500e #1 2023-11-15 13:24:25 ~10 min tests 📄log
✔️ 7c6aa0b #2 2023-11-15 13:32:47 ~7 min ios 📱ipa 📲
✔️ 7c6aa0b #2 2023-11-15 13:33:57 ~8 min tests 📄log
✔️ 7c6aa0b #2 2023-11-15 13:35:27 ~10 min android-e2e 🤖apk 📲
✔️ 7c6aa0b #2 2023-11-15 13:35:37 ~10 min android 🤖apk 📲

@VolodLytvynenko VolodLytvynenko self-assigned this Nov 15, 2023
@status-im-auto
Copy link
Member

78% of end-end tests have passed

Total executed tests: 45
Failed tests: 7
Expected to fail tests: 3
Passed tests: 35

IDs of failed tests: 702733,702745,702742,703503,702869,702855,702846 

IDs of expected to fail tests: 702732,702731,702808

Failed tests (7)

Click to expand
  • Rerun failed tests

    • Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742

    Device 1: ChatMessageInput element not found
    Device 1: Sending message 'mmmeowesage_text' 

    critical/chats/test_public_chat_browsing.py:91: in test_community_copy_and_paste_message_in_chat_input
    self.channel.send_message(message)
../views/chat_view.py:1003: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:121: in wait_for_element
    raise TimeoutException(
 Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element



    Device sessions

    2. test_community_discovery, id: 703503

    Device 1: Find Button by accessibility id: communities-home-discover-card
    Device 1: Tap on found: Button 

    critical/chats/test_public_chat_browsing.py:40: in test_community_discovery
    self.home.community_card_item.wait_for_visibility_of_element(30)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 1: BaseElement by accessibility id:`community-card-item` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    3. test_community_undo_delete_message, id: 702869

    Device 1: ChatMessageInput element not found
    Device 1: Sending message 'message to delete and undo' 

    critical/chats/test_public_chat_browsing.py:106: in test_community_undo_delete_message
    self.channel.send_message(message_to_delete)
../views/chat_view.py:1003: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:121: in wait_for_element
    raise TimeoutException(
 Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element



    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846

    Device 1: ChatMessageInput element not found
    Device 1: Sending message 'some_text' 

    critical/chats/test_public_chat_browsing.py:77: in test_community_navigate_to_channel_when_relaunch
    self.channel.send_message(text_message)
../views/chat_view.py:1003: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:121: in wait_for_element
    raise TimeoutException(
 Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element



    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733

    Device 2: Find Text by xpath: //*[starts-with(@text,'smth I should edit')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']
    Device 2: Tap on found: Text 

    critical/chats/test_1_1_public_chats.py:468: in test_1_1_chat_text_message_delete_push_disappear
    self.chat_2.chat_element_by_text(message_after_edit_1_1).wait_for_status_to_be("Delivered")
../views/chat_view.py:240: in wait_for_status_to_be
    raise TimeoutException("Message status was not changed to %s, it's %s" % (expected_status, current_status))
 Message status was not changed to Delivered, it's; 
 RemoteDisconnected



    Device sessions

    2. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

    Device 2: Looking for a message by text: hello
    Device 2: Find TimeStampText by xpath: //*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-timestamp'] 

    critical/chats/test_1_1_public_chats.py:296: in test_1_1_chat_non_latin_messages_stack_update_profile_photo
    'Timestamp on message %s does not correspond expected [%s]' % (timestamp, *sent_time_variants))
 not all arguments converted during string formatting



    Device sessions

    3. test_1_1_chat_edit_message, id: 702855

    Device 2: Find Text by xpath: //*[starts-with(@text,'Message before edit 1-1')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']
    Device 2: Tap on found: Text 

    critical/chats/test_1_1_public_chats.py:380: in test_1_1_chat_edit_message
    self.chat_2.chat_element_by_text(message_before_edit_1_1).wait_for_status_to_be("Delivered")
../views/chat_view.py:240: in wait_for_status_to_be
    raise TimeoutException("Message status was not changed to %s, it's %s" % (expected_status, current_status))
 Message status was not changed to Delivered, it's; 
 RemoteDisconnected



    Device sessions

    Expected to fail tests (3)

    Click to expand

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    2. test_group_chat_offline_pn, id: 702808

    Device 3: Looking for a message by text: message from old member
    Device 3: Looking for a message by text: message from new member 

    critical/chats/test_group_chat.py:323: in test_group_chat_offline_pn
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Messages PN was not fetched from offline

    [[Data delivery issue]]

    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Passed tests (35)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_message_delete, id: 702839
    Device sessions

    7. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    8. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    9. test_community_message_edit, id: 702843
    Device sessions

    10. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    4. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    5. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    3. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    4. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    @VolodLytvynenko
    Copy link
    Contributor

    HI @flexsurfer Thank you for the fix. PR is tested and ready to be merged

    alwx
    alwx approved these changes Nov 15, 2023
    View reviewed changes
    Copy link
    Contributor

    @alwx alwx left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    thanks for handling that!

    @flexsurfer flexsurfer merged commit 7153e4d into develop Nov 15, 2023
    6 checks passed
    @flexsurfer flexsurfer deleted the bug/_IOS]_The_tutorial_video_animation_keeps_playing_after_opening_a_Status_link branch November 15, 2023 15:24
    flexsurfer added a commit that referenced this pull request Nov 16, 2023
    @flexsurfer
    [#17854] [IOS] The tutorial video animation keeps playing after openi… (
    22005f9 
    #17915)

(cherry picked from commit 7153e4d)
    yevh-berdnyk pushed a commit that referenced this pull request Dec 8, 2023
    @flexsurfer @yevh-berdnyk
    [#17854] [IOS] The tutorial video animation keeps playing after openi… (
    cf3ed37 
    #17915)
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @clauxx clauxx clauxx approved these changes

    @briansztamfater briansztamfater briansztamfater approved these changes

    @alwx alwx alwx approved these changes

    @Parveshdhull Parveshdhull Awaiting requested review from Parveshdhull

    Assignees

    @flexsurfer flexsurfer

    @VolodLytvynenko VolodLytvynenko

    Labels
    request-manual-qa Tested - OK
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    [IOS] The tutorial video animation keeps playing after opening a Status link
    6 participants
    @flexsurfer @status-im-auto @VolodLytvynenko @alwx @briansztamfater @clauxx