Wallet: generate new keypair UI #18045

OmarBasem · 2023-12-01T13:01:20Z

This PR implements generating new keypair flow UI (until showing the secret phrase to the user). This PR has no re-frame or status-go integration.

Designs

Demo:

Screen_Recording_20231201_164017_Status.Debug.mp4

status-im-auto · 2023-12-01T13:04:54Z

Jenkins Builds

Click to see older builds (8)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	`06ea84d`	#1	2023-12-01 13:04:53	~3 min	`tests`	📄`log`
✔️	`06ea84d`	#1	2023-12-01 13:08:57	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`06ea84d`	#1	2023-12-01 13:09:01	~7 min	`android`	🤖`apk` 📲
✔️	`06ea84d`	#1	2023-12-01 13:14:02	~12 min	`ios`	📱`ipa` 📲

❌	`435e098`	#2	2023-12-01 13:24:22	~2 min	`tests`	📄`log`
✔️	`435e098`	#2	2023-12-01 13:27:59	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`435e098`	#2	2023-12-01 13:28:08	~6 min	`android`	🤖`apk` 📲
✔️	`435e098`	#2	2023-12-01 13:35:44	~14 min	`ios`	📱`ipa` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	`b2709cf`	#3	2023-12-05 06:07:29	~2 min	`tests`	📄`log`
✔️	`b2709cf`	#3	2023-12-05 06:10:55	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`b2709cf`	#3	2023-12-05 06:11:08	~6 min	`ios`	📱`ipa` 📲
✔️	`b2709cf`	#3	2023-12-05 06:11:12	~6 min	`android`	🤖`apk` 📲

✔️	`0cd59c4`	#4	2023-12-07 04:21:39	~6 min	`android`	🤖`apk` 📲
✔️	`0cd59c4`	#4	2023-12-07 04:23:59	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`0cd59c4`	#4	2023-12-07 04:26:04	~10 min	`tests`	📄`log`
✔️	`0cd59c4`	#4	2023-12-07 04:28:06	~12 min	`ios`	📱`ipa` 📲

J-Son89 · 2023-12-01T13:18:52Z

src/status_im2/contexts/wallet/create_account/backup_recovery_phrase/view.cljs

+    [utils.i18n :as i18n]
+    [utils.re-frame :as rf]))
+
+;; Temporary words


can we put this in the temp file as it makes it easier to know what we have to clean later? 🙏

J-Son89 · 2023-12-01T13:21:09Z

src/status_im2/contexts/wallet/create_account/backup_recovery_phrase/view.cljs

+   [quo/text {:style {:margin-left 4}} item]])
+
+(defn words-column
+  [words first?]


first? is a bit misleading here. I think you want first-half? or perhaps I misunderstood :)

can we mark these helper components as private too?

J-Son89 · 2023-12-01T13:21:37Z

src/status_im2/contexts/wallet/create_account/backup_recovery_phrase/view.cljs

+    :render-data    (if first? 1 7)
+    :scroll-enabled false}])
+
+(defn step-item


should step item be private?

J-Son89 · 2023-12-01T13:22:36Z

src/status_im2/contexts/wallet/create_account/backup_recovery_phrase/view.cljs

+  [{:keys [theme]}]
+  (let [steps     [:t/backup-step-1 :t/backup-step-2 :t/backup-step-3
+                   :t/backup-step-4]
+        checked   (reagent/atom {:0 false :1 false :2 false :3 false})


imo it's easier to read if you align the map keys

(reagent/atom {:0 false :1 false :2 false :3 false})

J-Son89 · 2023-12-01T13:23:51Z

src/status_im2/contexts/wallet/create_account/backup_recovery_phrase/view.cljs

+    :scroll-enabled false}])
+
+(defn step-item
+  [item index _ checked]


maybe we should add "?", i.e checked?

item is just a label in this case? maybe it's a clearer name?

step-item in every step component (checkbox + text) under "How to backup your recovery phrase"

I meant the first argument here btw, "item", since the use of it is just a label it might be clearer of the use if you change it to that. (defn step-item [label index _ checked]

J-Son89 · 2023-12-01T13:25:31Z

src/status_im2/contexts/wallet/create_account/backup_recovery_phrase/view.cljs

+
+(defn- view-internal
+  [{:keys [theme]}]
+  (let [steps     [:t/backup-step-1 :t/backup-step-2 :t/backup-step-3


perhaps step-labels is clearer?

J-Son89 · 2023-12-01T13:27:47Z

src/status_im2/contexts/wallet/create_account/select_keypair/view.cljs

@@ -8,6 +8,24 @@
    [utils.i18n :as i18n]
    [utils.re-frame :as rf]))

+(defn keypair-options


maybe we should put this in a separate options file?
e.g src/status_im2/contexts/wallet/create_account/select_keypair/options.cljs

select_keypair/options.cljs

@J-Son89 I don't think we should be rendering views in files named other than view.

Also, I think this is a small component to put in a separate namespace, and is not reused in other screens.

OmarBasem · 2023-12-06T06:43:08Z

@J-Son89 please rereview 🙏

J-Son89 · 2023-12-06T09:12:09Z

.clj-kondo/rewrite-clj/rewrite-clj/config.edn

@@ -0,0 +1,5 @@
+{:lint-as


Francesca-G

Here's the design review :)

* feat: new keypair flow ui

OmarBasem added the E:Mobile Wallet MVP label Dec 1, 2023

OmarBasem self-assigned this Dec 1, 2023

OmarBasem requested review from vkjr, tumanov-alex, briansztamfater, J-Son89 and mmilad75 December 1, 2023 13:02

J-Son89 reviewed Dec 1, 2023

View reviewed changes

OmarBasem force-pushed the wallet/new-keypair-ui branch from 435e098 to b2709cf Compare December 5, 2023 06:04

OmarBasem requested review from J-Son89, smohamedjavid and vkjr and removed request for vkjr December 5, 2023 06:57

J-Son89 reviewed Dec 6, 2023

View reviewed changes

.clj-kondo/rewrite-clj/rewrite-clj/config.edn Outdated

@@ -0,0 +1,5 @@

{:lint-as

Copy link

Contributor

J-Son89 Dec 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert

OmarBasem reacted with thumbs up emoji

J-Son89 approved these changes Dec 6, 2023

View reviewed changes

Francesca-G approved these changes Dec 6, 2023

View reviewed changes

Francesca-G added the followup-required label Dec 6, 2023

OmarBasem added 2 commits December 7, 2023 08:01

u

68e66bf

feat: new keypair flow ui

07830d9

OmarBasem added 6 commits December 7, 2023 08:01

lint

8218252

review

b6cf9e0

review

85b5991

lint

9fb979c

lint

a1953f1

lint

0cd59c4

OmarBasem force-pushed the wallet/new-keypair-ui branch from b2709cf to 0cd59c4 Compare December 7, 2023 04:15

OmarBasem merged commit dc587e4 into develop Dec 7, 2023
6 checks passed

OmarBasem deleted the wallet/new-keypair-ui branch December 7, 2023 05:43

yevh-berdnyk pushed a commit that referenced this pull request Dec 8, 2023

Wallet: generate new keypair UI (#18045)

8b41c66

* feat: new keypair flow ui

OmarBasem mentioned this pull request Mar 19, 2024

Wallet: Keypair feature flag #19333

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Wallet: generate new keypair UI #18045

Wallet: generate new keypair UI #18045

OmarBasem commented Dec 1, 2023

status-im-auto commented Dec 1, 2023 •

edited

Loading

J-Son89 Dec 1, 2023

J-Son89 Dec 1, 2023

J-Son89 Dec 1, 2023

J-Son89 Dec 1, 2023

J-Son89 Dec 1, 2023 •

edited

Loading

J-Son89 Dec 1, 2023

J-Son89 Dec 1, 2023

OmarBasem Dec 5, 2023

J-Son89 Dec 6, 2023

J-Son89 Dec 1, 2023

J-Son89 Dec 1, 2023

OmarBasem Dec 5, 2023 •

edited

Loading

OmarBasem commented Dec 6, 2023

J-Son89 Dec 6, 2023

Francesca-G left a comment

Wallet: generate new keypair UI #18045

Wallet: generate new keypair UI #18045

Conversation

OmarBasem commented Dec 1, 2023

status-im-auto commented Dec 1, 2023 • edited Loading

Jenkins Builds

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

J-Son89 Dec 1, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OmarBasem Dec 5, 2023 • edited Loading

Choose a reason for hiding this comment

OmarBasem commented Dec 6, 2023

Choose a reason for hiding this comment

Francesca-G left a comment

Choose a reason for hiding this comment

status-im-auto commented Dec 1, 2023 •

edited

Loading

J-Son89 Dec 1, 2023 •

edited

Loading

OmarBasem Dec 5, 2023 •

edited

Loading