Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use custom color for confirm select #18068

Merged
merged 2 commits into from
Dec 6, 2023
Merged

fix: use custom color for confirm select #18068

merged 2 commits into from
Dec 6, 2023

Conversation

BalogunofAfrica
Copy link
Contributor

Fixes #17564

Summary

The confirm selection button in the image picker didn't use the customization color of the user's profile. This fixes it.

Platforms

  • Android
  • iOS

status: ready

@BalogunofAfrica BalogunofAfrica self-assigned this Dec 5, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Dec 5, 2023 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 6ad52f0 #1 2023-12-05 05:59:28 ~7 min android-e2e 🤖apk 📲
✔️ 6ad52f0 #1 2023-12-05 05:59:32 ~7 min android 🤖apk 📲
✔️ 6ad52f0 #1 2023-12-05 06:00:09 ~7 min ios 📱ipa 📲
✔️ 6ad52f0 #1 2023-12-05 06:02:24 ~10 min tests 📄log
✔️ d5a074b #2 2023-12-06 04:02:35 ~6 min android-e2e 🤖apk 📲
✔️ d5a074b #2 2023-12-06 04:02:55 ~6 min ios 📱ipa 📲
✔️ d5a074b #2 2023-12-06 04:08:06 ~11 min android 🤖apk 📲
✔️ d5a074b #2 2023-12-06 04:08:33 ~12 min tests 📄log

@status-im-auto
Copy link
Member

81% of end-end tests have passed

Total executed tests: 48
Failed tests: 5
Expected to fail tests: 4
Passed tests: 39

IDs of failed tests: 703133,702745,702844,702846,703629 

IDs of expected to fail tests: 702732,703503,702731,702808

Failed tests (5)

Click to expand
  • Rerun failed tests

    • Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

    Device 1: Find `Button` by `accessibility id`: `show-profiles`
    Device 1: Tap on found: Button 

    critical/chats/test_public_chat_browsing.py:273: in test_restore_multiaccount_with_waku_backup_remove_switch
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Incorrect contacts number restored: 3 instead of 2



    Device sessions

    2. test_community_navigate_to_channel_when_relaunch, id: 702846

    ## Signed in successfully!
    Device 1: Looking for a message by text: some_text 

    critical/chats/test_public_chat_browsing.py:83: in test_community_navigate_to_channel_when_relaunch
    self.drivers[0].fail("Not navigated to channel view after reopening app")
base_test_case.py:179: in fail
    pytest.fail('Device %s: %s' % (self.number, text))
 Device 1: Not navigated to channel view after reopening app



    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844

    Device 2: Find EmojisNumber by xpath: //*[starts-with(@text,'https://m.youtube.com/watch?v=Je7yErjEVt4')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//*[@content-desc='emoji-reaction-4']/android.widget.TextView
    Device 2: Element EmojisNumber text is equal to 1 

    critical/chats/test_public_chat_browsing.py:608: in test_community_links_with_previews_github_youtube_twitter_gif_send_enable
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 No preview image is shown for https://github.com/status-im/status-mobile/pull/11707



    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

    Device 2: Find MemberPhoto by xpath: //*[starts-with(@text,'profile_photo')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='user-avatar']
    Device 2: Image differs from template to 7.0295266544117645 percents 

    critical/chats/test_1_1_public_chats.py:312: in test_1_1_chat_non_latin_messages_stack_update_profile_photo
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Image of user in 1-1 chat is too different from template!



    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_join_when_node_owner_offline, id: 703629

    Device 2: Tap on found: Button
    Device 2: Looking for community: 'open community' 

    critical/chats/test_public_chat_browsing.py:1112: in test_community_join_when_node_owner_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Text "You joined “closed community”" in shown toast element doesn't match expected "You joined “open community”"
E    Joined status is not displayed
E    open community is not listed inside Joined communities tab



    Device sessions

    Expected to fail tests (4)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    2. test_group_chat_offline_pn, id: 702808

    Device 3: Looking for a message by text: message from old member
    Device 3: Looking for a message by text: message from new member 

    critical/chats/test_group_chat.py:323: in test_group_chat_offline_pn
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Messages PN was not fetched from offline

    [[Data delivery issue]]

    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Passed tests (39)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_undo_delete_message, id: 702869
    Device sessions

    3. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    4. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_message_delete, id: 702839
    Device sessions

    7. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    8. test_community_message_edit, id: 702843
    Device sessions

    9. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_edit_message, id: 702855
    Device sessions

    5. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    6. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_open_universal_links_from_other_apps, id: 704614
    Device sessions

    3. test_links_deep_links, id: 702775
    Device sessions

    J-Son89
    J-Son89 approved these changes Dec 5, 2023
    View reviewed changes
    src/status_im2/contexts/chat/photo_selector/view.cljs Outdated
    @@ -35,15 +35,16 @@
    (close))

    (defn confirm-button
    [selected-images sending-image close]
    [selected-images sending-image close customization-color]
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Can you make this list of args a map?

    @VolodLytvynenko VolodLytvynenko self-assigned this Dec 5, 2023
    @status-im-auto
    Copy link
    Member

    0% of end-end tests have passed

    Total executed tests: 1
Failed tests: 1
Expected to fail tests: 0
Passed tests: 0

    IDs of failed tests: 703629

    Failed tests (1)

    Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_join_when_node_owner_offline, id: 703629 
    Test setup failed: critical/chats/test_public_chat_browsing.py:777: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:309: in create_shared_drivers
    drivers = loop.run_until_complete(start_threads(test_suite_data.current_test.name,
/usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
    return future.result()
__init__.py:26: in start_threads
    returns[k] = await returns[k]
/usr/lib/python3.10/concurrent/futures/thread.py:58: in run
    result = self.fn(*self.args, **self.kwargs)
/home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/webdriver.py:257: in __init__
    super().__init__(
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:206: in __init__
    self.start_session(capabilities)
/home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/webdriver.py:346: in start_session
    response = self.execute(RemoteCommand.NEW_SESSION, w3c_caps)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:345: in execute
    self.error_handler.check_response(response)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/errorhandler.py:193: in check_response
    raise exception_class(value)
 <html><body><h1>502 Bad Gateway</h1>
E   The server returned an invalid or incomplete response.
E   </body></html>



    @status-im-auto
    Copy link
    Member

    100% of end-end tests have passed

    Total executed tests: 1
Failed tests: 0
Expected to fail tests: 0
Passed tests: 1

    Passed tests (1)

    Click to expand

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    @VolodLytvynenko
    Copy link
    Contributor

    @BalogunofAfrica thank you for PR. Ready to be merged

    @BalogunofAfrica BalogunofAfrica merged commit 7e14846 into develop Dec 6, 2023
    6 checks passed
    @BalogunofAfrica BalogunofAfrica deleted the fix/confirm-selection branch December 6, 2023 04:10
    yevh-berdnyk pushed a commit that referenced this pull request Dec 8, 2023
    @BalogunofAfrica @yevh-berdnyk
    fix: use custom color for confirm select (#18068)
    eb54258
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @OmarBasem OmarBasem OmarBasem approved these changes

    @J-Son89 J-Son89 J-Son89 approved these changes

    @flexsurfer flexsurfer flexsurfer approved these changes

    Assignees

    @BalogunofAfrica BalogunofAfrica

    @VolodLytvynenko VolodLytvynenko

    Labels
    Tested - OK
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Design review: Posts & Attachments - confirm selection button background color
    6 participants
    @BalogunofAfrica @status-im-auto @VolodLytvynenko @flexsurfer @J-Son89 @OmarBasem