Communities - Show modal title and community context tag #18077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (11)
|
ilmotta
force-pushed
the
feat/show-community-name
branch
from
2b1d5f2 to
2d3b523
Compare
ajayesivan
reviewed
Dec 6, 2023
FFFra
reviewed
Dec 6, 2023
| @@ -185,7 +185,7 @@ | |||
| [quo/button | |||
| {:on-press | |||
| (if config/community-accounts-selection-enabled? | |||
| #(rf/dispatch [:open-modal :community-account-selection community]) | |||
| #(rf/dispatch [:open-modal :community-account-selection {:community-id id}]) | |||
| #(rf/dispatch [:open-modal :community-requests-to-join community])) | |||
There was a problem hiding this comment.
Should we pass the argument as line above?
instead of comunity we use {:community-id id}?
There was a problem hiding this comment.
The community map is huge, even containing encoded images. We should avoid passing it around if possible because the data (screen params) is going to be stored in the app db and used by a subscription and the view too. This puts more stress on re-frame and Reagent to compute if something needs to rendered. So here I changed the code to pass the community ID to the screen params so that the view layer can get the community from a subscription.
FFFra
approved these changes
Dec 6, 2023
I mentioned this in the PR description @ajayesivan:
I've seen this problem somewhere, it's not right. |
|
Thank you @ilmotta. I missed that part 🙃 |
ajayesivan
approved these changes
Dec 6, 2023
ilmotta
force-pushed
the
feat/show-community-name
branch
from
2d3b523 to
be6870d
Compare
71% of end-end tests have passedFailed tests (8)Click to expandClass TestDeepLinksOneDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
Expected to fail tests (6)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Passed tests (34)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Class TestDeepLinksOneDevice:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePR:
|
ilmotta
force-pushed
the
feat/show-community-name
branch
from
be6870d to
3038a44
Compare
ilmotta
force-pushed
the
feat/show-community-name
branch
from
3038a44 to
c4ddf07
Compare
|
@status-im/mobile-qa, I merged this PR because all its code runs behind a disabled feature toggle (we enable only during development). For the next couple weeks we will probably continue to rely mostly on e2e tests and our manual checks to make sure we respect the feature toggle and not cause any regression. The flows for joining communities shouldn't be affected at all. In the cases where we do touch code outside the toggle's umbrella we will definitely ask for your reviews :) |
yevh-berdnyk
pushed a commit
that referenced
this pull request
Dec 8, 2023
Samyoul
added
the
community-account-selection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18025
Summary
This is a quick PR to make the account selection screen more in line with Figma, but more importantly to show the community context tag and a screen title.
The feature is behind a feature toggle , disabled in
develop.Before
Demo
There's a known bug where the background of the context tag extends up to the available width of the parent container. This PR is not fixing that.
Screen_recording_20231205_124555.webm
Areas that may be impacted
None because the feature toggle is disabled in
develop. e2e tests will be run as usual.Steps to test
status-im2.config/community-accounts-selection-enabled?status: ready