Added support for different currencies in token price calculation #18078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (43)
|
smohamedjavid
force-pushed
the
feature/wallet-currency
branch
6 times, most recently
from
ab49638 to
0f61265
Compare
smohamedjavid
requested review from
tumanov-alex,
briansztamfater,
J-Son89,
OmarBasem,
mmilad75 and
ulisesmac
smohamedjavid
force-pushed
the
feature/wallet-currency
branch
from
0f61265 to
041a7d4
Compare
ulisesmac
reviewed
Dec 8, 2023
OmarBasem
approved these changes
Dec 12, 2023
smohamedjavid
force-pushed
the
feature/wallet-currency
branch
from
041a7d4 to
e7bad19
Compare
ulisesmac
approved these changes
Dec 13, 2023
smohamedjavid
force-pushed
the
feature/wallet-currency
branch
2 times, most recently
from
75cbfd1 to
0825a2e
Compare
smohamedjavid
force-pushed
the
feature/wallet-currency
branch
from
0825a2e to
f8bd043
Compare
81% of end-end tests have passedFailed tests (3)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
Expected to fail tests (6)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
Passed tests (39)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
|
J-Son89
reviewed
Dec 14, 2023
| :<- [:profile/currency] | ||
| :<- [:profile/currency-symbol] | ||
| (fn [[{:keys [tokens color]} currency currency-symbol]] | ||
| (mapv #(calc-token-value % color currency currency-symbol) tokens))) |
There was a problem hiding this comment.
@smohamedjavid is this taking into account the different network configuration of a given account? 🤔
There was a problem hiding this comment.
@J-Son89 - Not at this moment. Will work on that separately. 👍
50% of end-end tests have passedFailed tests (1)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (1)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
|
|
hi @smohamedjavid thank you for PR. No issues from my side. PR is ready to be merged |
…rice calculation Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
Thank you for testing the PR @VolodLytvynenko. Were you able to see the |
smohamedjavid
force-pushed
the
feature/wallet-currency
branch
from
f8bd043 to
87afbf4
Compare
@smohamedjavid yes. The usdc.e is shown. Thank you! |
|
@smohamedjavid, I missed one question and included a follow-up issue: link. |
@VolodLytvynenko - No worries, I will check that issue 👍
No, this was not in the scope of this PR, and this requires an update in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #17984 & #18160
Summary
This PR
wallet.-.currency.mp4
Testing notes
The new wallet home screen displays
€0.00in the cumulative balance of all wallet accounts and tokens as its temporary data.Platforms
Steps to test
Advanced > Set currencystatus: ready