Account switcher for send flow #18100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (37)
|
smohamedjavid
force-pushed
the
feature/account-switcher-for-send-flow
branch
from
76a186f to
7dc1987
Compare
smohamedjavid
requested review from
briansztamfater,
J-Son89,
OmarBasem,
mmilad75 and
ulisesmac
OmarBasem
approved these changes
Dec 8, 2023
smohamedjavid
force-pushed
the
feature/account-switcher-for-send-flow
branch
from
7dc1987 to
bac5653
Compare
ulisesmac
approved these changes
Dec 8, 2023
Comment on lines
20
to
21
| (-> account | ||
| (assoc :watch-only? (= (:type account) :watch)))) |
There was a problem hiding this comment.
I usually suggest avoiding threading macros for only one step. I think they worth using when we have at least two steps,
smohamedjavid
force-pushed
the
feature/account-switcher-for-send-flow
branch
2 times, most recently
from
dc8e221 to
dd41e7d
Compare
|
@VolodLytvynenko - this pr handles the account switcher in the send flow. @smohamedjavid can you ensure that this doesn't allow switching to a watch only account 🙏 |
J-Son89
reviewed
Dec 11, 2023
J-Son89
reviewed
Dec 11, 2023
|
something not working with github so I can't approve - pr LGTM 👍 |
Done 👍
Yeah 😅 . I have been facing it too. Reloading the page works. |
smohamedjavid
force-pushed
the
feature/account-switcher-for-send-flow
branch
2 times, most recently
from
51304b2 to
195b8cf
Compare
smohamedjavid
force-pushed
the
feature/account-switcher-for-send-flow
branch
from
195b8cf to
4ac66da
Compare
63% of end-end tests have passedFailed tests (12)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Expected to fail tests (6)Click to expandClass TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (31)Click to expandClass TestCommunityOneDeviceMerged:
Class TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
|
61% of end-end tests have passedFailed tests (12)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Expected to fail tests (7)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Passed tests (30)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestDeepLinksOneDevice:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
|
smohamedjavid
force-pushed
the
feature/account-switcher-for-send-flow
branch
from
4ac66da to
67b75cc
Compare
smohamedjavid
force-pushed
the
feature/account-switcher-for-send-flow
branch
from
67b75cc to
4eafae9
Compare
100% of end-end tests have passedPassed tests (12)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePR:
|
|
@smohamedjavid thank you for the PR! Ready for merge. |
Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
Thanks for testing this PR real quick, @pavloburykh. |
smohamedjavid
force-pushed
the
feature/account-switcher-for-send-flow
branch
from
4eafae9 to
2dbc407
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #18052 & #18144
Summary
This PR:
Select accountbottom sheet) of account switcher for send flowwatch-only?key in the account to prevent repetitive account type checks across the codebaseAccount-switcher.mp4
Platforms
Steps to test
Sendbutton to open the send flowstatus: ready