Upgrade clang and patch Glog for fixing iOS builds on MacOS Sonoma, Xcode 15 #18108

siddarthkay · 2023-12-07T07:42:43Z

After upgrading MacOS to Sonoma and Xcode to 15, pod install stage would fail with clang errors.
Turns out that react-native's configure glog script sets 2 additional flags, CC and CXX which conflicts with flags already set in nix iOS shell.

In this PR we :

bump clang from 10.0.0 to 15.0.7
patch glog configure script to avoid setting those flags

This fixes the iOS builds.

status: ready

status-im-auto · 2023-12-07T07:52:22Z

Jenkins Builds

Click to see older builds (10)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`2bd9fca`	#1	2023-12-07 07:52:22	~9 min	`ios`	📱`ipa` 📲
✔️	`2bd9fca`	#1	2023-12-07 07:55:20	~12 min	`tests`	📄`log`
✔️	`2bd9fca`	#1	2023-12-07 07:55:20	~12 min	`android-e2e`	🤖`apk` 📲
✔️	`2bd9fca`	#1	2023-12-07 07:55:23	~12 min	`android`	🤖`apk` 📲

✔️	`10c946d`	#2	2023-12-07 09:00:28	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`10c946d`	#2	2023-12-07 09:00:30	~6 min	`android`	🤖`apk` 📲
✔️	`10c946d`	#2	2023-12-07 09:06:02	~12 min	`tests`	📄`log`
✔️	`10c946d`	#2	2023-12-07 09:07:43	~14 min	`ios`	📱`ipa` 📲

✔️	`6644a98`	#3	2023-12-07 09:32:36	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`6644a98`	#3	2023-12-07 09:32:48	~6 min	`android`	🤖`apk` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	`b90c0b1`	#4	2023-12-07 09:40:23	~3 min	`tests`	📄`log`
✔️	`b90c0b1`	#4	2023-12-07 09:43:28	~7 min	`android`	🤖`apk` 📲
✔️	`b90c0b1`	#4	2023-12-07 09:43:31	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`b90c0b1`	#4	2023-12-07 09:44:31	~8 min	`ios`	📱`ipa` 📲

✔️	`4afd104`	#5	2023-12-07 09:56:21	~6 min	`android`	🤖`apk` 📲
✔️	`4afd104`	#5	2023-12-07 09:58:29	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`4afd104`	#5	2023-12-07 10:01:24	~11 min	`tests`	📄`log`
✔️	`4afd104`	#5	2023-12-07 10:04:25	~14 min	`ios`	📱`ipa` 📲

nix/shell.nix

nix/deps/nodejs-patched/default.nix

jakubgs

What do you men by:

which conflicts with flags already set in nix iOS shell.

Which flags set in Nix iOS shell?

status-im-auto · 2023-12-07T08:38:55Z

69% of end-end tests have passed

Total executed tests: 49
Failed tests: 9
Expected to fail tests: 6
Passed tests: 34

IDs of failed tests: 702809,702784,702851,702948,702783,703496,702786,702845,703629

IDs of expected to fail tests: 702732,702894,703503,702846,702731,702808

Failed tests (9)

Click to expand

Rerun failed tests

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Test setup failed: critical/chats/test_1_1_public_chats.py:548: in prepare_devices self.chat_1.send_message('hey') ../views/chat_view.py:1003: in send_message self.chat_message_input.wait_for_element(wait_chat_input_sec) ../views/base_element.py:121: in wait_for_element raise TimeoutException( Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element
2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device 1: ChatMessageInput element not found Device 1: Sending message 'hey' Test setup failed: critical/chats/test_1_1_public_chats.py:548: in prepare_devices self.chat_1.send_message('hey') ../views/chat_view.py:1003: in send_message self.chat_message_input.wait_for_element(wait_chat_input_sec) ../views/base_element.py:121: in wait_for_element raise TimeoutException( Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element [[Data delivery issue]] Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
3. test_1_1_chat_mute_chat, id: 703496
Test setup failed: critical/chats/test_1_1_public_chats.py:548: in prepare_devices self.chat_1.send_message('hey') ../views/chat_view.py:1003: in send_message self.chat_message_input.wait_for_element(wait_chat_input_sec) ../views/base_element.py:121: in wait_for_element raise TimeoutException( Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_markdown_support, id: 702809
Test setup failed: ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:155: in wait_for_rendering_ended_and_click self.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: Button by xpath: `//[contains(@text, 'user_1')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception During handling of the above exception, another exception occurred: critical/chats/test_public_chat_browsing.py:822: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:392: in handle_contact_request self.driver.fail("No contact request received from %s" % username) base_test_case.py:179: in fail pytest.fail('Device %s: %s' % (self.number, text)) E Failed: Device 2: No contact request received from user_1
2. test_community_hashtag_links_to_community_channels, id: 702948
Test setup failed: ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:155: in wait_for_rendering_ended_and_click self.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: Button by xpath: `//[contains(@text, 'user_1')]/ancestor::[@content-desc='activity']/[@content-desc="accept-contact-request"]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception During handling of the above exception, another exception occurred: critical/chats/test_public_chat_browsing.py:822: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:392: in handle_contact_request self.driver.fail("No contact request received from %s" % username) base_test_case.py:179: in fail pytest.fail('Device %s: %s' % (self.number, text)) E Failed: Device 2: No contact request received from user_1 [[Can't navigate to a channel by hashtag link, https://github.com//issues/18095]]*
3. test_community_mentions_push_notification, id: 702786
Device 2: Tap on found: Button Device 2: Attempt 0 is successful clicking close-activity-center Test setup failed: ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:155: in wait_for_rendering_ended_and_click self.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: Button by xpath: `//[contains(@text, 'user_1')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception During handling of the above exception, another exception occurred: critical/chats/test_public_chat_browsing.py:822: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:392: in handle_contact_request self.driver.fail("No contact request received from %s" % username) base_test_case.py:179: in fail pytest.fail('Device %s: %s' % (self.number, text)) E Failed: Device 2: No contact request received from user_1 Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
4. test_community_leave, id: 702845
Test setup failed: ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:155: in wait_for_rendering_ended_and_click self.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: Button by xpath: `//[contains(@text, 'user_1')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception During handling of the above exception, another exception occurred: critical/chats/test_public_chat_browsing.py:822: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:392: in handle_contact_request self.driver.fail("No contact request received from %s" % username) base_test_case.py:179: in fail pytest.fail('Device %s: %s' % (self.number, text)) E Failed: Device 2: No contact request received from user_1
5. test_community_join_when_node_owner_offline, id: 703629
Test setup failed: ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:155: in wait_for_rendering_ended_and_click self.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: Button by xpath: `//[contains(@text, 'user_1')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception During handling of the above exception, another exception occurred: critical/chats/test_public_chat_browsing.py:822: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:392: in handle_contact_request self.driver.fail("No contact request received from %s" % username) base_test_case.py:179: in fail pytest.fail('Device %s: %s' % (self.number, text)) E Failed: Device 2: No contact request received from user_1

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851

Device 2: Find Button by accessibility id: tab-contacts
Device 2: Tap on found: Button

activity_center/test_activity_center.py:136: in test_activity_center_contact_request_accept_swipe_mark_all_as_read
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Contact was not added to contact list after accepting contact request (as sender)

Device sessions

Device 1:

Device 2:

Expected to fail tests (6)

Click to expand

Class TestCommunityOneDeviceMerged:

1. test_community_discovery, id: 703503
`Test is not run, e2e blocker` [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]
2. test_community_navigate_to_channel_when_relaunch, id: 702846
`Test is not run, e2e blocker` [[reason: [NOTRUN] Issue #18075]]

Class TestCommunityMultipleDeviceMerged:

1. test_community_contact_block_unblock_offline, id: 702894
Device 1: Find `ProfileSendMessageButton` by `accessibility id`: `Chat-item-button` Device 1: Sending message 'piy' `critical/chats/test_public_chat_browsing.py:742: in test_community_contact_block_unblock_offline self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Chat with unblocked user was not enabled after 1 minute` [[Message can be missed after unblock: https://github.com//issues/16873]] Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
`Test is not run, e2e blocker` [[reason: [NOTRUN] Pin feature is in development]]
2. test_group_chat_offline_pn, id: 702808
Device 3: Looking for a message by text: message from old member Device 3: Looking for a message by text: message from new member `critical/chats/test_group_chat.py:323: in test_group_chat_offline_pn self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Messages PN was not fetched from offline` [[Data delivery issue]] Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_pin_messages, id: 702731
`Test is not run, e2e blocker` [[reason: [NOTRUN] Pin feature is in development]]

Passed tests (34)

Click to expand

Class TestDeepLinksOneDevice:

1. test_links_open_universal_links_from_chat, id: 704613
Device sessions Device 1: Steps, video, logs
2. test_links_open_universal_links_from_other_apps, id: 704614
Device sessions Device 1: Steps, video, logs
3. test_links_deep_links, id: 702775
Device sessions Device 1: Steps, video, logs

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_mute_chat, id: 703495
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_send_image_save_and_share, id: 703297
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_reactions, id: 703202
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
4. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_edit_delete_message_when_offline, id: 704615
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_message_send_check_timestamps_sender_username, id: 702838
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs
2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
3. test_community_undo_delete_message, id: 702869
Device sessions Device 1: Steps, video, logs
4. test_community_mute_community_and_channel, id: 703382
Device sessions Device 1: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_send_image_save_and_share, id: 703391
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_add_contact_field_validation, id: 702777
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

jakubgs

That's better, but I would be worried about weird future failures if we unser CC.

mohsen-ghafouri

Well done :)

siddarthkay · 2023-12-07T09:27:05Z

That's better, but I would be worried about weird future failures if we unser CC.

I understand, the new patch makes it more explicit that we're just avoid 2 flags being set by react-native :

CC
CXX
since they interfere with flags already set by nix.

siddarthkay · 2023-12-07T09:38:18Z

@status-im/mobile-qa : we don't need QA for this since this PR just fixes build issues for MacOS Sonoma.

shivekkhurana · 2023-12-07T16:40:13Z

I was facing the glog issue while trying to run make pod-install. Now that is gone, but I get another error:

1251   │ The following build commands failed:
1252   │     SwiftCompile normal arm64 Compiling\ Util.swift /Users/shivekkhurana/Wip/status-im/status-mobile/ios/Pods/Keycard/Sources/Keycard/Util.swift (in target 'Keycard' from project 'Po
       │ ds')
1253   │     SwiftCompile normal arm64 /Users/shivekkhurana/Wip/status-im/status-mobile/ios/Pods/Keycard/Sources/Keycard/Util.swift (in target 'Keycard' from project 'Pods')
1254   │     SwiftCompile normal arm64 Compiling\ CashApplicationInfo.swift,\ CashCommandSet.swift /Users/shivekkhurana/Wip/status-im/status-mobile/ios/Pods/Keycard/Sources/Keycard/CashApplic
       │ ationInfo.swift /Users/shivekkhurana/Wip/status-im/status-mobile/ios/Pods/Keycard/Sources/Keycard/CashCommandSet.swift (in target 'Keycard' from project 'Pods')
1255   │     SwiftCompile normal arm64 /Users/shivekkhurana/Wip/status-im/status-mobile/ios/Pods/Keycard/Sources/Keycard/CashApplicationInfo.swift (in target 'Keycard' from project 'Pods')
1256   │     SwiftCompile normal arm64 /Users/shivekkhurana/Wip/status-im/status-mobile/ios/Pods/Keycard/Sources/Keycard/CashCommandSet.swift (in target 'Keycard' from project 'Pods')
1257   │     SwiftCompile normal arm64 Compiling\ MnemonicEnglish.swift,\ Pairing.swift /Users/shivekkhurana/Wip/status-im/status-mobile/ios/Pods/Keycard/Sources/Keycard/MnemonicEnglish.swift
       │  /Users/shivekkhurana/Wip/status-im/status-mobile/ios/Pods/Keycard/Sources/Keycard/Pairing.swift (in target 'Keycard' from project 'Pods')
1258   │     SwiftCompile normal arm64 /Users/shivekkhurana/Wip/status-im/status-mobile/ios/Pods/Keycard/Sources/Keycard/MnemonicEnglish.swift (in target 'Keycard' from project 'Pods')
1259   │     SwiftCompile normal arm64 /Users/shivekkhurana/Wip/status-im/status-mobile/ios/Pods/Keycard/Sources/Keycard/Pairing.swift (in target 'Keycard' from project 'Pods')
1260   │     SwiftCompile normal arm64 Compiling\ StatusWord.swift /Users/shivekkhurana/Wip/status-im/status-mobile/ios/Pods/Keycard/Sources/Keycard/StatusWord.swift (in target 'Keycard' from
       │  project 'Pods')
1261   │     SwiftCompile normal arm64 /Users/shivekkhurana/Wip/status-im/status-mobile/ios/Pods/Keycard/Sources/Keycard/StatusWord.swift (in target 'Keycard' from project 'Pods')
1262   │     SwiftCompile normal arm64 Compiling\ Metadata.swift,\ Mnemonic.swift /Users/shivekkhurana/Wip/status-im/status-mobile/ios/Pods/Keycard/Sources/Keycard/Metadata.swift /Users/shive
       │ kkhurana/Wip/status-im/status-mobile/ios/Pods/Keycard/Sources/Keycard/Mnemonic.swift (in target 'Keycard' from project 'Pods')
1263   │     SwiftCompile normal arm64 /Users/shivekkhurana/Wip/status-im/status-mobile/ios/Pods/Keycard/Sources/Keycard/Metadata.swift (in target 'Keycard' from project 'Pods')
1264   │     SwiftCompile normal arm64 /Users/shivekkhurana/Wip/status-im/status-mobile/ios/Pods/Keycard/Sources/Keycard/Mnemonic.swift (in target 'Keycard' from project 'Pods')
1265   │     SwiftCompile normal arm64 Compiling\ ApplicationInfo.swift,\ ApplicationStatus.swift /Users/shivekkhurana/Wip/status-im/status-mobile/ios/Pods/Keycard/Sources/Keycard/Application
       │ Info.swift /Users/shivekkhurana/Wip/status-im/status-mobile/ios/Pods/Keycard/Sources/Keycard/ApplicationStatus.swift (in target 'Keycard' from project 'Pods')
1266   │     SwiftCompile normal arm64 /Users/shivekkhurana/Wip/status-im/status-mobile/ios/Pods/Keycard/Sources/Keycard/ApplicationInfo.swift (in target 'Keycard' from project 'Pods')
1267   │     SwiftCompile normal arm64 /Users/shivekkhurana/Wip/status-im/status-mobile/ios/Pods/Keycard/Sources/Keycard/ApplicationStatus.swift (in target 'Keycard' from project 'Pods')
1268   │     SwiftCompile normal arm64 Compiling\ CardChannel.swift,\ CardError.swift /Users/shivekkhurana/Wip/status-im/status-mobile/ios/Pods/Keycard/Sources/Keycard/CardChannel.swift /User
       │ s/shivekkhurana/Wip/status-im/status-mobile/ios/Pods/Keycard/Sources/Keycard/CardError.swift (in target 'Keycard' from project 'Pods')
1269   │     SwiftCompile normal arm64 /Users/shivekkhurana/Wip/status-im/status-mobile/ios/Pods/Keycard/Sources/Keycard/CardChannel.swift (in target 'Keycard' from project 'Pods')
1270   │     SwiftCompile normal arm64 /Users/shivekkhurana/Wip/status-im/status-mobile/ios/Pods/Keycard/Sources/Keycard/CardError.swift (in target 'Keycard' from project 'Pods')
1271   │     SwiftCompile normal arm64 Compiling\ APDUCommand.swift,\ APDUResponse.swift /Users/shivekkhurana/Wip/status-im/status-mobile/ios/Pods/Keycard/Sources/Keycard/APDUCommand.swift /U
       │ sers/shivekkhurana/Wip/status-im/status-mobile/ios/Pods/Keycard/Sources/Keycard/APDUResponse.swift (in target 'Keycard' from project 'Pods')
1272   │     SwiftCompile normal arm64 /Users/shivekkhurana/Wip/status-im/status-mobile/ios/Pods/Keycard/Sources/Keycard/APDUCommand.swift (in target 'Keycard' from project 'Pods')
1273   │     SwiftCompile normal arm64 /Users/shivekkhurana/Wip/status-im/status-mobile/ios/Pods/Keycard/Sources/Keycard/APDUResponse.swift (in target 'Keycard' from project 'Pods')
1274   │     SwiftCompile normal arm64 Compiling\ RecoverableSignature.swift,\ SCP02.swift /Users/shivekkhurana/Wip/status-im/status-mobile/ios/Pods/Keycard/Sources/Keycard/RecoverableSignatu
       │ re.swift /Users/shivekkhurana/Wip/status-im/status-mobile/ios/Pods/Keycard/Sources/Keycard/SCP02.swift (in target 'Keycard' from project 'Pods')
1275   │     SwiftCompile normal arm64 /Users/shivekkhurana/Wip/status-im/status-mobile/ios/Pods/Keycard/Sources/Keycard/RecoverableSignature.swift (in target 'Keycard' from project 'Pods')
1276   │     SwiftCompile normal arm64 /Users/shivekkhurana/Wip/status-im/status-mobile/ios/Pods/Keycard/Sources/Keycard/SCP02.swift (in target 'Keycard' from project 'Pods')
1277   │     SwiftEmitModule normal arm64 Emitting\ module\ for\ Keycard (in target 'Keycard' from project 'Pods')
1278   │ (26 failures)
1279   │

Here's the complete log file.
log.txt

Did anyone else face this issue ?

siddarthkay · 2023-12-07T16:49:50Z

@flexsurfer : faced this

flexsurfer · 2023-12-08T05:47:34Z

hey @shivekkhurana glad to see you :) so i don't know what helped but i cleaned entire project,
removed node_modules, removed ios build and pods, run make xcode-clean , open xcode and from menu clean build folder, and then it worked ;)

shivekkhurana · 2023-12-08T14:37:52Z

Glad to see you too Andrey 👋👋
I'll try that out.

After upgrading MacOS to Sonoma and Xcode to 15, pod install stage would fail with clang errors. Turns out that react-native's configure glog script sets 2 additional flags, CC and CXX which conflicts with flags already set in nix iOS shell. In this commit we : - bump clang from 10.0.0 to 15.0.7 - patch glog configure script to avoid setting those flags This fixes the iOS builds.

siddarthkay self-assigned this Dec 7, 2023

siddarthkay requested a review from jakubgs as a code owner December 7, 2023 07:42

flexsurfer reviewed Dec 7, 2023

View reviewed changes

nix/shell.nix Outdated Show resolved Hide resolved

flexsurfer approved these changes Dec 7, 2023

View reviewed changes

siddarthkay mentioned this pull request Dec 7, 2023

make pod-install command fails for MacOS Sonoma & Xcode 15 #17682

Closed

jakubgs reviewed Dec 7, 2023

View reviewed changes

nix/deps/nodejs-patched/default.nix Outdated Show resolved Hide resolved

jakubgs requested changes Dec 7, 2023

View reviewed changes

siddarthkay force-pushed the upgrade-clang branch from 2bd9fca to 10c946d Compare December 7, 2023 08:53

jakubgs approved these changes Dec 7, 2023

View reviewed changes

mohsen-ghafouri approved these changes Dec 7, 2023

View reviewed changes

siddarthkay force-pushed the upgrade-clang branch from 10c946d to 6644a98 Compare December 7, 2023 09:25

siddarthkay force-pushed the upgrade-clang branch from 6644a98 to b90c0b1 Compare December 7, 2023 09:36

nix: bump clang to 15 & patch Glog for CC,CXX flag

4afd104

siddarthkay force-pushed the upgrade-clang branch from b90c0b1 to 4afd104 Compare December 7, 2023 09:49

siddarthkay added E:Mobile Developer Experience 2023 ios nix labels Dec 7, 2023

siddarthkay merged commit 3ad3455 into develop Dec 7, 2023
6 checks passed

siddarthkay deleted the upgrade-clang branch December 7, 2023 10:06

ilmotta added developer-xp and removed E:Mobile Developer Experience 2023 labels Aug 28, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade clang and patch Glog for fixing iOS builds on MacOS Sonoma, Xcode 15 #18108

Upgrade clang and patch Glog for fixing iOS builds on MacOS Sonoma, Xcode 15 #18108

siddarthkay commented Dec 7, 2023 •

edited

Loading

status-im-auto commented Dec 7, 2023 •

edited

Loading

jakubgs left a comment

status-im-auto commented Dec 7, 2023

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestCommunityOneDeviceMerged:

Class TestCommunityMultipleDeviceMerged:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestDeepLinksOneDevice:

Class TestActivityMultipleDevicePRTwo:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityMultipleDeviceMerged:

Class TestActivityMultipleDevicePR:

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestActivityCenterContactRequestMultipleDevicePR:

jakubgs left a comment

mohsen-ghafouri left a comment

siddarthkay commented Dec 7, 2023

siddarthkay commented Dec 7, 2023 •

edited

Loading

shivekkhurana commented Dec 7, 2023

siddarthkay commented Dec 7, 2023

flexsurfer commented Dec 8, 2023

shivekkhurana commented Dec 8, 2023

Upgrade clang and patch Glog for fixing iOS builds on MacOS Sonoma, Xcode 15 #18108

Upgrade clang and patch Glog for fixing iOS builds on MacOS Sonoma, Xcode 15 #18108

Conversation

siddarthkay commented Dec 7, 2023 • edited Loading

status-im-auto commented Dec 7, 2023 • edited Loading

Jenkins Builds

jakubgs left a comment

Choose a reason for hiding this comment

status-im-auto commented Dec 7, 2023

69% of end-end tests have passed

Failed tests (9)

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestActivityCenterContactRequestMultipleDevicePR:

Expected to fail tests (6)

Class TestCommunityOneDeviceMerged:

Class TestCommunityMultipleDeviceMerged:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Passed tests (34)

Class TestDeepLinksOneDevice:

Class TestActivityMultipleDevicePRTwo:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityMultipleDeviceMerged:

Class TestActivityMultipleDevicePR:

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestActivityCenterContactRequestMultipleDevicePR:

jakubgs left a comment

Choose a reason for hiding this comment

mohsen-ghafouri left a comment

Choose a reason for hiding this comment

siddarthkay commented Dec 7, 2023

siddarthkay commented Dec 7, 2023 • edited Loading

shivekkhurana commented Dec 7, 2023

siddarthkay commented Dec 7, 2023

flexsurfer commented Dec 8, 2023

shivekkhurana commented Dec 8, 2023

siddarthkay commented Dec 7, 2023 •

edited

Loading

status-im-auto commented Dec 7, 2023 •

edited

Loading

siddarthkay commented Dec 7, 2023 •

edited

Loading